[PATCH 3/4] hw_random: core: Rearranging start_khwrngd to remove forward declaration

[PrasannaKumar Muralidharan]

Rearrange start_khwrngd such that its forward declaration is not
required.

Signed-off-by: PrasannaKumar Muralidharan <prasannatsmku...@gmail.com>
---
 drivers/char/hw_random/core.c | 75 +++++++++++++++++++++----------------------
 1 file changed, 37 insertions(+), 38 deletions(-)

diff --git a/drivers/char/hw_random/core.c b/drivers/char/hw_random/core.c
index 7e2b1a7..534c2ae 100644
--- a/drivers/char/hw_random/core.c
+++ b/drivers/char/hw_random/core.c
@@ -50,7 +50,6 @@ MODULE_PARM_DESC(default_quality,
                 "default entropy content of hwrng per mill");
 
 static int hwrng_init(struct hwrng *rng);
-static void start_khwrngd(void);
 
 static size_t rng_buffer_size(void)
 {
@@ -153,6 +152,43 @@ static void put_rng(struct hwrng *rng)
        mutex_unlock(&rng_mutex);
 }
 
+static int hwrng_fillfn(void *unused)
+{
+       long rc;
+
+       while (!kthread_should_stop()) {
+               struct hwrng *rng;
+
+               rng = get_current_rng();
+               if (IS_ERR(rng) || !rng)
+                       break;
+               mutex_lock(&reading_mutex);
+               rc = rng_get_data(rng, rng_fillbuf,
+                                 rng_buffer_size(), 1);
+               mutex_unlock(&reading_mutex);
+               put_rng(rng);
+               if (rc <= 0) {
+                       pr_warn("hwrng: no data available\n");
+                       msleep_interruptible(10000);
+                       continue;
+               }
+               /* Outside lock, sure, but y'know: randomness. */
+               add_hwgenerator_randomness((void *)rng_fillbuf, rc,
+                                          rc * current_quality * 8 >> 10);
+       }
+       hwrng_fill = NULL;
+       return 0;
+}
+
+static void start_khwrngd(void)
+{
+       hwrng_fill = kthread_run(hwrng_fillfn, NULL, "hwrng");
+       if (IS_ERR(hwrng_fill)) {
+               pr_err("hwrng_fill thread creation failed");
+               hwrng_fill = NULL;
+       }
+}
+
 static int hwrng_init(struct hwrng *rng)
 {
        if (kref_get_unless_zero(&rng->ref))
@@ -387,43 +423,6 @@ static int __init register_miscdev(void)
        return misc_register(&rng_miscdev);
 }
 
-static int hwrng_fillfn(void *unused)
-{
-       long rc;
-
-       while (!kthread_should_stop()) {
-               struct hwrng *rng;
-
-               rng = get_current_rng();
-               if (IS_ERR(rng) || !rng)
-                       break;
-               mutex_lock(&reading_mutex);
-               rc = rng_get_data(rng, rng_fillbuf,
-                                 rng_buffer_size(), 1);
-               mutex_unlock(&reading_mutex);
-               put_rng(rng);
-               if (rc <= 0) {
-                       pr_warn("hwrng: no data available\n");
-                       msleep_interruptible(10000);
-                       continue;
-               }
-               /* Outside lock, sure, but y'know: randomness. */
-               add_hwgenerator_randomness((void *)rng_fillbuf, rc,
-                                          rc * current_quality * 8 >> 10);
-       }
-       hwrng_fill = NULL;
-       return 0;
-}
-
-static void start_khwrngd(void)
-{
-       hwrng_fill = kthread_run(hwrng_fillfn, NULL, "hwrng");
-       if (IS_ERR(hwrng_fill)) {
-               pr_err("hwrng_fill thread creation failed");
-               hwrng_fill = NULL;
-       }
-}
-
 int hwrng_register(struct hwrng *rng)
 {
        int err = -EINVAL;
-- 
2.10.0