drivers/crypto/cavium/cpt/cptvf_reqmanager.c:312:2-8: WARNING: NULL check
before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive
or usb_free_urb is not needed. Maybe consider reorganizing relevant code to
avoid passing NULL values.
drivers/crypto/cavium/cpt/cptvf_reqmanager.c:315:2-8: WARNING: NULL check
before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive
or usb_free_urb is not needed. Maybe consider reorganizing relevant code to
avoid passing NULL values.
drivers/crypto/cavium/cpt/cptvf_reqmanager.c:318:2-8: WARNING: NULL check
before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive
or usb_free_urb is not needed. Maybe consider reorganizing relevant code to
avoid passing NULL values.
drivers/crypto/cavium/cpt/cptvf_reqmanager.c:321:2-8: WARNING: NULL check
before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive
or usb_free_urb is not needed. Maybe consider reorganizing relevant code to
avoid passing NULL values.
NULL check before some freeing functions is not needed.
Based on checkpatch warning
"kfree(NULL) is safe this check is probably not required"
and kfreeaddr.cocci by Julia Lawall.
Generated by: scripts/coccinelle/free/ifnullfree.cocci
CC: George Cherian <george.cher...@cavium.com>
Signed-off-by: Fengguang Wu <fengguang...@intel.com>
---
cptvf_reqmanager.c | 12 ++++--------
1 file changed, 4 insertions(+), 8 deletions(-)
--- a/drivers/crypto/cavium/cpt/cptvf_reqmanager.c
+++ b/drivers/crypto/cavium/cpt/cptvf_reqmanager.c
@@ -308,17 +308,13 @@ void do_request_cleanup(struct cpt_vf *c
}
}
- if (info->scatter_components)
- kzfree(info->scatter_components);
+ kzfree(info->scatter_components);
- if (info->gather_components)
- kzfree(info->gather_components);
+ kzfree(info->gather_components);
- if (info->out_buffer)
- kzfree(info->out_buffer);
+ kzfree(info->out_buffer);
- if (info->in_buffer)
- kzfree(info->in_buffer);
+ kzfree(info->in_buffer);
if (info->completion_addr)
kzfree((void *)info->completion_addr);
--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
