-----Original Message-----
From: Herbert Xu [mailto:herb...@gondor.apana.org.au] 
Sent: Tuesday, June 7, 2016 3:35 AM
To: Dey, Megha <megha....@intel.com>
Cc: tim.c.c...@linux.intel.com; da...@davemloft.net; 
linux-crypto@vger.kernel.org; linux-ker...@vger.kernel.org; Yu, Fenghua 
<fenghua...@intel.com>; Megha Dey <megha....@linux.intel.com>
Subject: Re: [PATCH V2 2/2] crypto : async implementation for sha1-mb

On Thu, Jun 02, 2016 at 07:53:50PM -0700, Megha Dey wrote:
>
> +     struct ahash_alg *shash = crypto_ahash_alg(tfm);
>  
>       /* alignment is to be done by multi-buffer crypto algorithm if 
> needed */
>  
> -     return shash->finup(desc, NULL, 0, req->result);
> +     return shash->finup(desc);

You're still poking in the guts of the API.  Now that it's a real ahash you 
don't need to do that.

Just do crypto_ahash_finup.  That way you don't need to export crypto_ahsh_alg 
either.

> I have made these changes and re-sent the patch.

Thanks,
--
Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: 
http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to