On Mon, Jun 15, 2015 at 04:52:49PM -0700, Victoria Milhoan wrote: > > @@ -202,6 +214,13 @@ static void caam_jr_dequeue(unsigned long devarg) > userdesc = jrp->entinfo[sw_idx].desc_addr_virt; > userstatus = jrp->outring[hw_idx].jrstatus; > > + /* > + * Make sure all information from the job has been obtained > + * before telling CAAM that the job has been removed from the > + * output ring. > + */ > + smp_mb();
So you're not actually guarding against another CPU here, right? In that case shouldn't this be mb()? Cheers, -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
