On Thu, May 16, 2013 at 11:03:32AM -0700, Tim Chen wrote: > > Need to also add select CRYPTO for CRC_T10DIF. Updated fix below: > > > Signed-off-by: Tim Chen <tim.c.c...@linux.intel.com> > --- > diff --git a/crypto/Kconfig b/crypto/Kconfig > index d1ca631..015df24 100644 > --- a/crypto/Kconfig > +++ b/crypto/Kconfig > @@ -379,6 +379,7 @@ config CRYPTO_CRC32_PCLMUL > config CRYPTO_CRCT10DIF > tristate "CRCT10DIF algorithm" > select CRYPTO_HASH > + depends on CRC_T10DIF > help > CRC T10 Data Integrity Field computation is being cast as > a crypto transform. This allows for faster crc t10 diff > diff --git a/lib/Kconfig b/lib/Kconfig > index 0cee056..6407793 100644 > --- a/lib/Kconfig > +++ b/lib/Kconfig > @@ -63,7 +63,8 @@ config CRC16 > > config CRC_T10DIF > tristate "CRC calculation for the T10 Data Integrity Field" > - select CRYPTO_CRCT10DIF > + select CRYPTO > + select CRYPTO_HASH > help > This option is only needed if a module that's not in the > kernel tree needs to calculate CRC checks for use with the
Nope this is still broken. We need to move the actual crct10dif code into crypto/. I'll fix up the patch in the tree. Also I'm going to get rid of crc_t10dif_update_lib function. If you still want to maintain the ordering you should do so using the *_init constructs. Cheers, -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
