On Thu, May 26, 2011 at 04:20:58PM -0700, Mandeep Singh Baines wrote: > David Miller (da...@davemloft.net) wrote: > > > > The temp[] buffer is explicitly places inside the inner most > > basic block so that the compiler doesn't allocate the stack > > space unless that code path is taken. > > > > Fixed in V2 (this patch). Thanks for the review. > > -- >8 -- (snip) > > Plus some other minor cleanup.
I don't really like the cleanups. In any case, mixing up the use of SHA1_BLOCK_SIZE with cleanups increases the chance of introducing a bug. So please redo the patch with only the addition of SHA1_BLOCK_SIZE and nothing else. Thanks, -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
