Mimi Zohar <[email protected]> wrote:
> Reviewd-by: Mimi Zohar <[email protected]>
You've missed an 'e'.
> +int tpm_send(u32 chip_num, char *cmd, int buflen)
> +{
> ...
> + rc = transmit_cmd(chip, (struct tpm_cmd_t *)cmd, buflen,
> + "attempting tpm_cmd");
Make cmd 'void *' to obviate the cast. Preferably it should be const too.
> + module_put(chip->dev->driver->owner);
Where's the corresponding module_get()? I suspect this should be wrapped to
match tpm_chip_find_get().
David
--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
