Miloslav Trmač wrote:
> --- /dev/null
> +++ b/include/linux/ncr.h
[...]
> +struct ncr_session_input_data {
> +     const void __user *data;
> +     __kernel_size_t data_size;
> +};
> +
> +struct ncr_session_output_buffer {
> +     void __user *buffer;
> +     __kernel_size_t buffer_size;
> +     __kernel_size_t __user *result_size_ptr;
> +};

Why not using fixed-size fit-all members?

struct ncr_session_input_data {
        __u64 data;             /* user pointer, cast to/from u64 */
        __u32 data_size;        /* or __u64? */
};

struct ncr_session_output_buffer {
        __u64 buffer;
        __u64 result_size_ptr;  /* can't this be a direct output member? */
        __u32 buffer_size;      /* or __u64? */
};

And then get rid of all the COMAPT code paths.
-- 
Stefan Richter
-=====-==-=- =--- =-=--
http://arcgraph.de/sr/
--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to