On Thu, Jan 15, 2009 at 04:28:33PM +0800, Huang Ying wrote: > > + tfm = crypto_alloc_ablkcipher(cryptd_alg_name, type, mask); > + BUG_ON(crypto_ablkcipher_tfm(tfm)->__crt_alg->cra_module != > + THIS_MODULE);
You need to check whether tfm is an error before dereferencing it. Also it's probably better to free the tfm and return an error rather than invoking BUG. > --- a/include/crypto/algapi.h > +++ b/include/crypto/algapi.h Please create a new file for this, e.g., include/crypto/cryptd.h. Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
