On Thu, Nov 15, 2007 at 10:10:05PM +0100, Sebastian Siewior wrote:
>
> In this case, the s390 has the same bug (they copy the IV back after
> blkcipher_walk_done()). Howevere it will probably never get triggered
> because they have an aligment of 0 (what gets pushed to 3 by the crypto
> API if I remenber correcrtly). 

It only gets pushed to 3 if you use the generic CBC template, they
don't so they will stay at 0.  In their case I also see why they
can't just use walk->iv directly.

> So a general question: Is it a must (requirement by the crypto API) to
> copy the IV back or not? I guess not if we move completely to async (one
> day) :)

You must copy it back to allow chaining.  Even when we go async
someone may wish to chain.  So in that sense you've just found a
bug in the hifn driver :)

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
-
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to