On Wed, Jul 19, 2006 at 04:23:04PM +1200, Michal Ludvig wrote: > > How about aligmmaskmask = ALIGN_CTX | ALIGN_IV | ALIGN_DATA | ALIGN_KEY > > It is possible that some engines may require different alignment for > these things but it shouldn't harm if to eventually align them all to > the strictest mask. > > OK?
The space used by potential extra alignment is no problem. However, if we ever have to copy data unnecessarily just because the ctx/iv/key needed a bigger alignment, then it's bad. Since we're not really running short of space in the alg object (remember, there is only one in the entire system for each algorithm), I think distinct masks are better. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
