On Tuesday 06 June 2006 00:28, Dag Arne Osvik wrote: > Joachim Fritschi wrote: > > Can you give me any hint what to improve or maybe provide a suggestion on > > how > > to improve the overall readabilty. > > It looks better on second reading, but I have some comments: > > Remove load_s - it's needless and (slightly) confusing Done > There are some cases of missing ## D Oops, fixed. > Why semicolon after closing parenthesis in macro definitions? Braindamage on my part. > Try to align operands in columns Done > It would be nice to have some explanation of macro parameter names Done for the non trivial stuff > Btw, why do you keep zeroing tmp registers when you don't need to? > 32-bit ops zero the top half of the destination register. Again braindamage :). Fixed it according to your suggestions.
Thanks for the comments. Will post a new patches in a few minutes. -Joachim - To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
