> I didn't know this builder would test flang as well: which stage of the build 
> is doing so?

It tests it only for stage 2, and the 1 stage bot checks stage 1. So
we do have some of that focus you talked about between
clang-aarch64-sve-vla (which is the 1 stage) and
clang-aarch64-sve-vla-2stage. We also have plain AArch64 bots checking
flang, but the point here is to exercise SVE codegen.

You are right that the 2 stage bot could skip building flang in stage
1 because it's not going to test it. In theory our ccaching means this
isn't a big deal (it does now, thanks again!) but we could explicitly
disable it and save a lot of linking at least.

We will do our best to improve the build times but ultimately we are
limited by hardware availability which is a more difficult problem to
fix.

On Fri, 22 Jul 2022 at 10:16, Mehdi AMINI <joker....@gmail.com> wrote:
>
> On Fri, Jul 22, 2022 at 5:46 AM Thiago Jung Bauermann <
> thiago.bauerm...@linaro.org> wrote:
>
> >
> > Hello Mehdi,
> >
> > Mehdi AMINI <joker....@gmail.com> writes:
> >
> > > I don't know if you are maintaining also clang-aarch64-sve-vla-2stage
> > > but it takes far too long right now (>10 hours).
> >
> > Yes, I actually increased its ccache size on July 6th but only from 5 GB
> > to 20 GB because the machine running that builder is also a development
> > box. Looking at the build times graph it looks like it helped a bit but
> > not a lot.
> >
> > I now increased the size again to 40 GB. I'll monitor to see if there's
> > an impact.
> >
> > > It notifies for large number of people which is overly noisy right now.
> > > See: https://lab.llvm.org/buildbot/#/builders/198/builds/1234
> >
> > Does adding a “depends_on_projects” argument help reduce the number of
> > notified people? Or is there something else that could/should be done
> > about that?
> >
>
> It will at least eliminate people who commit in unrelated projects.
>
>
> >
> > > One thing I noticed is that it seems to be missing the
> > > `depends_on_projects` for the buildbot configuration: that means it'll
> > > include commits that touches part of the codebase totally unrelated to
> > > what it is testing (like flang and mlir). That would be a first easy
> > > step to reduce the number of unrelated changes that get flagged
> > > incorrectly.
> >
> > Thank you for the suggestion, I see that many builders running on Linaro
> > workers don't have it. I'll prepare a patch to add “depends_on_projects”
> > arguments to them.
> >
> > Though specifically for clang-aarch64-sve-vla-2stage IIUC its value
> > would be ["llvm", "mlir", "clang", "flang"] (since it's meant to test
> > flang as well), so perhaps it wouldn't change much in practice?
> >
>
> I didn't know this builder would test flang as well: which stage of the
> build is doing so?
> In general I try to keep builder configs more focused to avoid that bug in
> one components hides regression in another one (for example MLIR breaking
> stage1 for this bot for a day and in the meantime you get a stage-2
> regression that won't be detected)
>
> In any case, this will still help people contributing outside this list
> (libc++, lldb, lld, compiler-rt), unless you also need these.
>
> Cheers,
>
> --
> Mehdi
> _______________________________________________
> linaro-toolchain mailing list -- linaro-toolchain@lists.linaro.org
> To unsubscribe send an email to linaro-toolchain-le...@lists.linaro.org
_______________________________________________
linaro-toolchain mailing list -- linaro-toolchain@lists.linaro.org
To unsubscribe send an email to linaro-toolchain-le...@lists.linaro.org

Reply via email to