Successfully identified regression in *glibc* in CI configuration
tcwg_cross/gnu-master-aarch64-build_cross. So far, this commit has regressed
CI configurations:
- tcwg_cross/gnu-master-aarch64-build_cross
Culprit:
<cut>
commit cf2256196cc843b574e39eb05b77fc0c00024aa1
Author: Adhemerval Zanella <adhemerval.zane...@linaro.org>
Date: Mon Jul 5 12:48:48 2021 +0000
linux: Fix setsockopt fallback
The final 2 arguments for SO_TIMESTAMP/SO_TIMESTAMPNS are being set
wrongly.
Checked on x86_64-linux-gnu and i686-linux-gnu.
</cut>
Results regressed to (for first_bad == cf2256196cc843b574e39eb05b77fc0c00024aa1)
# reset_artifacts:
-10
# true:
0
# build_abe binutils:
1
# build_abe stage1:
2
# build_abe linux:
3
# First few build errors in logs:
# 00:00:16 make[2]: ***
[/home/tcwg-buildslave/workspace/tcwg_gnu_1/abe/builds/x86_64-pc-linux-gnu/aarch64-linux-gnu/glibc-glibc.git~master/sysd-rules:483:
/home/tcwg-buildslave/workspace/tcwg_gnu_1/abe/builds/x86_64-pc-linux-gnu/aarch64-linux-gnu/glibc-glibc.git~master/csu/start.o]
Error 1
# 00:00:16 make[2]: ***
[/home/tcwg-buildslave/workspace/tcwg_gnu_1/abe/builds/x86_64-pc-linux-gnu/aarch64-linux-gnu/glibc-glibc.git~master/sysd-rules:499:
/home/tcwg-buildslave/workspace/tcwg_gnu_1/abe/builds/x86_64-pc-linux-gnu/aarch64-linux-gnu/glibc-glibc.git~master/csu/start.os]
Error 1
# 00:00:16 make[2]: ***
[/home/tcwg-buildslave/workspace/tcwg_gnu_1/abe/builds/x86_64-pc-linux-gnu/aarch64-linux-gnu/glibc-glibc.git~master/sysd-rules:483:
/home/tcwg-buildslave/workspace/tcwg_gnu_1/abe/builds/x86_64-pc-linux-gnu/aarch64-linux-gnu/glibc-glibc.git~master/csu/crti.o]
Error 1
# 00:00:16 make[2]: ***
[/home/tcwg-buildslave/workspace/tcwg_gnu_1/abe/builds/x86_64-pc-linux-gnu/aarch64-linux-gnu/glibc-glibc.git~master/sysd-rules:483:
/home/tcwg-buildslave/workspace/tcwg_gnu_1/abe/builds/x86_64-pc-linux-gnu/aarch64-linux-gnu/glibc-glibc.git~master/csu/crtn.o]
Error 1
# 00:00:16 make[2]: *** [../o-iterator.mk:9:
/home/tcwg-buildslave/workspace/tcwg_gnu_1/abe/builds/x86_64-pc-linux-gnu/aarch64-linux-gnu/glibc-glibc.git~master/csu/check_fds.o]
Error 1
# 00:00:16 make[2]: *** [../o-iterator.mk:9:
/home/tcwg-buildslave/workspace/tcwg_gnu_1/abe/builds/x86_64-pc-linux-gnu/aarch64-linux-gnu/glibc-glibc.git~master/csu/check_fds.os]
Error 1
# 00:00:16 ../sysdeps/aarch64/nptl/tls.h:91:19: error:
‘__builtin_thread_pointer’ is not supported on this target
# 00:00:16 make[2]: ***
[/home/tcwg-buildslave/workspace/tcwg_gnu_1/abe/builds/x86_64-pc-linux-gnu/aarch64-linux-gnu/glibc-glibc.git~master/sysd-rules:485:
/home/tcwg-buildslave/workspace/tcwg_gnu_1/abe/builds/x86_64-pc-linux-gnu/aarch64-linux-gnu/glibc-glibc.git~master/csu/libc-tls.o]
Error 1
# 00:00:16 ../sysdeps/unix/sysv/linux/aarch64/sysdep.h:190:17: error: invalid
register name for ‘_x0’
# 00:00:16 ../sysdeps/unix/sysv/linux/aarch64/sysdep.h:174:22: error: invalid
register name for ‘_x8’
from (for last_good == f7de21498dc6c517969315dcb3a675072c2cc87f)
# reset_artifacts:
-10
# true:
0
# build_abe binutils:
1
# build_abe stage1:
2
# build_abe linux:
3
# build_abe glibc:
4
# build_abe stage2:
5
# build_abe qemu:
6
Artifacts of last_good build:
https://ci.linaro.org/job/tcwg_cross-bisect-gnu-master-aarch64-build_cross/26/artifact/artifacts/build-f7de21498dc6c517969315dcb3a675072c2cc87f/
Artifacts of first_bad build:
https://ci.linaro.org/job/tcwg_cross-bisect-gnu-master-aarch64-build_cross/26/artifact/artifacts/build-cf2256196cc843b574e39eb05b77fc0c00024aa1/
Build top page/logs:
https://ci.linaro.org/job/tcwg_cross-bisect-gnu-master-aarch64-build_cross/26/
Configuration details:
Reproduce builds:
<cut>
mkdir investigate-glibc-cf2256196cc843b574e39eb05b77fc0c00024aa1
cd investigate-glibc-cf2256196cc843b574e39eb05b77fc0c00024aa1
git clone https://git.linaro.org/toolchain/jenkins-scripts
mkdir -p artifacts/manifests
curl -o artifacts/manifests/build-baseline.sh
https://ci.linaro.org/job/tcwg_cross-bisect-gnu-master-aarch64-build_cross/26/artifact/artifacts/manifests/build-baseline.sh
--fail
curl -o artifacts/manifests/build-parameters.sh
https://ci.linaro.org/job/tcwg_cross-bisect-gnu-master-aarch64-build_cross/26/artifact/artifacts/manifests/build-parameters.sh
--fail
curl -o artifacts/test.sh
https://ci.linaro.org/job/tcwg_cross-bisect-gnu-master-aarch64-build_cross/26/artifact/artifacts/test.sh
--fail
chmod +x artifacts/test.sh
# Reproduce the baseline build (build all pre-requisites)
./jenkins-scripts/tcwg_gnu-build.sh @@ artifacts/manifests/build-baseline.sh
cd glibc
# Reproduce first_bad build
git checkout --detach cf2256196cc843b574e39eb05b77fc0c00024aa1
../artifacts/test.sh
# Reproduce last_good build
git checkout --detach f7de21498dc6c517969315dcb3a675072c2cc87f
../artifacts/test.sh
cd ..
</cut>
History of pending regressions and results:
https://git.linaro.org/toolchain/ci/base-artifacts.git/log/?h=linaro-local/ci/tcwg_cross/gnu-master-aarch64-build_cross
Artifacts:
https://ci.linaro.org/job/tcwg_cross-bisect-gnu-master-aarch64-build_cross/26/artifact/artifacts/
Build log:
https://ci.linaro.org/job/tcwg_cross-bisect-gnu-master-aarch64-build_cross/26/consoleText
Full commit (up to 1000 lines):
<cut>
commit cf2256196cc843b574e39eb05b77fc0c00024aa1
Author: Adhemerval Zanella <adhemerval.zane...@linaro.org>
Date: Mon Jul 5 12:48:48 2021 +0000
linux: Fix setsockopt fallback
The final 2 arguments for SO_TIMESTAMP/SO_TIMESTAMPNS are being set
wrongly.
Checked on x86_64-linux-gnu and i686-linux-gnu.
---
sysdeps/unix/sysv/linux/setsockopt.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/sysdeps/unix/sysv/linux/setsockopt.c
b/sysdeps/unix/sysv/linux/setsockopt.c
index a4780a9d33..2792f1b5a1 100644
--- a/sysdeps/unix/sysv/linux/setsockopt.c
+++ b/sysdeps/unix/sysv/linux/setsockopt.c
@@ -78,7 +78,9 @@ setsockopt32 (int fd, int level, int optname, const void
*optval,
optname = COMPAT_SO_TIMESTAMP_OLD;
if (optname == COMPAT_SO_TIMESTAMPNS_NEW)
optname = COMPAT_SO_TIMESTAMPNS_OLD;
- r = setsockopt_syscall (fd, level, optname, NULL, 0);
+ /* The expected type for the option is an 'int' for both types of
+ timestamp formats, so there is no need to convert it. */
+ r = setsockopt_syscall (fd, level, optname, optval, len);
}
break;
}
</cut>
_______________________________________________
linaro-toolchain mailing list
linaro-toolchain@lists.linaro.org
https://lists.linaro.org/mailman/listinfo/linaro-toolchain
