On Wed, Jul 12, 2023 at 03:26:14PM -0600, Jim Fehlig wrote: > For unknown reasons, the libxl driver attempts to resume a domain in the > confirm phase when a migration operation has been canceled. This has shown > to be problematic when simulating scenarios that result in a canceled > migration. In all scenarios, the domain was in a running state when entering > libxlDomainMigrationSrcConfirm, causing the call to libxl_domain_resume to > fail. Making matters worse, the domain state is changed to paused when in > fact it's running. And finally, libxlDomainMigrationSrcConfirm incorrectly > returns an error. > > Remove this incorrect logic from libxlDomainMigrationSrcConfirm. On a > canceled migration it's sufficient to resume the lock process that was > paused in the perform phase. > > Signed-off-by: Jim Fehlig <[email protected]> > --- > src/libxl/libxl_migration.c | 16 +--------------- > 1 file changed, 1 insertion(+), 15 deletions(-)
Reviewed-by: Daniel P. Berrangé <[email protected]> With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
