On 6/21/23 2:01 PM, Thomas Huth wrote:
index a19902988c..dfdc95bfa5 100644
--- a/src/qemu/qemu_command.c
+++ b/src/qemu/qemu_command.c
@@ -10166,6 +10166,18 @@ qemuBuildCryptoCommandLine(virCommand *cmd,
  }
+static int
+qemuBuildTeardownCommandLine(virCommand *cmd,
+                                  virQEMUCaps *qemuCaps)
+{
+    if (ARCH_IS_S390(virArchFromHost()) &&
+        virQEMUCapsGet(qemuCaps, QEMU_CAPS_RUN_WITH_ASYNC_TEARDOWN))
+        virCommandAddArgList(cmd, "-run-with", "async-teardown=yes", NULL);

Using "=on" seems to be more common than using "=yes", so I'd maybe switch to "=on" here instead.

+    return 0;
+}

Apart from that, patches look fine to me, so feel free to add:
Reviewed-by: Thomas Huth <[email protected]>

Thanks Thomas,
I will change "=yes" into "=on" in the next version.
The series needs to be reworked anyway.

--
Mit freundlichen Grüßen/Kind regards
   Boris Fiuczynski

IBM Deutschland Research & Development GmbH
Vorsitzender des Aufsichtsrats: Gregor Pillen
Geschäftsführung: David Faller
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294

Reply via email to