>-----Original Message----- >From: Sean V Kelley [mailto:[email protected]] >Sent: Friday, November 18, 2016 12:47 AM >To: Emil Velikov <[email protected]>; Xiang, Haihao ><[email protected]> >Cc: Daniel Vetter <[email protected]>; [email protected]; David >Herrmann <[email protected]> >Subject: Re: [Libva] [PATCH] drm: remove va_drm_is_authenticated check > >On Thu, 2016-11-17 at 16:42 +0000, Emil Velikov wrote: >> On 17 November 2016 at 15:38, Xiang, Haihao <[email protected]> >> wrote: >> > > From: Libva [mailto:[email protected]] On Behalf >> > > Of Emil Velikov >> > > Sent: Tuesday, November 15, 2016 11:24 PM >> > > To: [email protected] >> > > Cc: Daniel Vetter <[email protected]>; David Herrmann >> > > <[email protected]> >> > > Subject: [Libva] [PATCH] drm: remove va_drm_is_authenticated check >> > > >> > > If we do not use a render node we must authenticate. >> > >> > It is not true. A root or master user can access /dev/dri/card0 >> > without authentication in drm. >> > va_drm_is_authenticated() is used to check for this cases. >> > >> >> Surely you're not suggesting that running your video player as root is >> a wise idea ;-) > >Agreed.
I also agree we should run video player as a normal user, however some customer prefers root. > >> >> Regardless, there's something _really_ fishy with libva if it needs >> va_drm_is_authenticated. >> Any other software out there does not need to (or do so) - some >> examples include Xorg, Wayland and other Weston compositors, Mesa, IGT >> (a ton of GPU tests) ... be that as root, user or otherwise. > > >We don't need it, in my opinion. We can still run VAAPI application as root to access /dev/dri/card0 with this patch, but cannot run 2+ VAAPI applications at the same time. We can suggest customer to use render node first because authentication isn't needed for render node. I am fine to apply the patch. > >Sean > >> >> Emil >> _______________________________________________ >> Libva mailing list >> [email protected] >> https://lists.freedesktop.org/mailman/listinfo/libva _______________________________________________ Libva mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/libva
