>-----Original Message----- >From: Libva [mailto:[email protected]] On Behalf Of Zhao >Yakui >Sent: Thursday, November 17, 2016 8:59 PM >To: [email protected] >Subject: Re: [Libva] [Libva-intel-driver][PATCH 09/17] Rename >gen9_gpe_media_object_walker() to gen8_gpe_media_object_walker() > >On 11/17/2016 04:35 PM, Xiang, Haihao wrote: >> This function can be used on GEN8 too > >Based on HW spec, Broadwell and Gen9 have some difference about the >MEDIA_OBJECT_WALKER commands.
>So it will be better to add a new wrapper of media_object_walker for gen8. Yes there are a few different fields in the command between gen8 and gen9. But they are the same for all used fields in the driver So I prefer the same function. We can change it if we will use the different fields in the future. >Thanks >> >> Signed-off-by: Xiang, Haihao<[email protected]> >> --- >> src/gen9_post_processing.c | 2 +- >> src/gen9_vp9_encoder.c | 2 +- >> src/i965_gpe_utils.c | 2 +- >> src/i965_gpe_utils.h | 2 +- >> 4 files changed, 4 insertions(+), 4 deletions(-) >> >> diff --git a/src/gen9_post_processing.c b/src/gen9_post_processing.c >> index 2128697..e9b8f86 100644 >> --- a/src/gen9_post_processing.c >> +++ b/src/gen9_post_processing.c >> @@ -608,7 +608,7 @@ >gen9_run_kernel_media_object_walker(VADriverContextP ctx, >> intel_batchbuffer_emit_mi_flush(batch); >> >> gen9_gpe_pipeline_setup(ctx, gpe_context, batch); >> - gen9_gpe_media_object_walker(ctx, gpe_context, batch, param); >> + gen8_gpe_media_object_walker(ctx, gpe_context, batch, param); >> gen8_gpe_media_state_flush(ctx, gpe_context, batch); >> >> gen9_gpe_pipeline_end(ctx, gpe_context, batch); diff --git >> a/src/gen9_vp9_encoder.c b/src/gen9_vp9_encoder.c index >> 0b66565..34d09a6 100644 >> --- a/src/gen9_vp9_encoder.c >> +++ b/src/gen9_vp9_encoder.c >> @@ -1129,7 +1129,7 @@ >gen9_run_kernel_media_object_walker(VADriverContextP ctx, >> gen9_gpe_mi_store_data_imm(ctx, batch,&mi_store_data_imm); >> >> gen9_gpe_pipeline_setup(ctx, gpe_context, batch); >> - gen9_gpe_media_object_walker(ctx, gpe_context, batch, param); >> + gen8_gpe_media_object_walker(ctx, gpe_context, batch, param); >> gen8_gpe_media_state_flush(ctx, gpe_context, batch); >> >> gen9_gpe_pipeline_end(ctx, gpe_context, batch); diff --git >> a/src/i965_gpe_utils.c b/src/i965_gpe_utils.c index b20857b..c2d06b2 >> 100644 >> --- a/src/i965_gpe_utils.c >> +++ b/src/i965_gpe_utils.c >> @@ -2103,7 +2103,7 @@ gen8_gpe_media_object(VADriverContextP ctx, >> } >> >> void >> -gen9_gpe_media_object_walker(VADriverContextP ctx, >> +gen8_gpe_media_object_walker(VADriverContextP ctx, >> struct i965_gpe_context *gpe_context, >> struct intel_batchbuffer *batch, >> struct >> gpe_media_object_walker_parameter *param) diff --git >> a/src/i965_gpe_utils.h b/src/i965_gpe_utils.h index 22165da..b58a02c >> 100644 >> --- a/src/i965_gpe_utils.h >> +++ b/src/i965_gpe_utils.h >> @@ -506,7 +506,7 @@ gen8_gpe_media_state_flush(VADriverContextP ctx, >> struct intel_batchbuffer *batch); >> >> extern void >> -gen9_gpe_media_object_walker(VADriverContextP ctx, >> +gen8_gpe_media_object_walker(VADriverContextP ctx, >> struct i965_gpe_context *gpe_context, >> struct intel_batchbuffer *batch, >> struct >> gpe_media_object_walker_parameter *param); > >_______________________________________________ >Libva mailing list >[email protected] >https://lists.freedesktop.org/mailman/listinfo/libva _______________________________________________ Libva mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/libva
