Make sense!
May be better to change the comment for VA_RT_FORMAT_YUV420_10BPP to
"YUV formats with 16 bits per channel memory layout (P010, P016)"
On 10.12.2015 00:24, Bian, Jonathan wrote:
Right now 10BPP RT means 2 bytes per component. This was created to support
P010 and P016 which have the same memory layout. But there might be hardware
out there that can do 10-bit packed for example.
We can keep the existing 10BPP definition with a clearer description, and add
10BPP_PACKED, 12BPP_PACKED etc. in the future if needed.
Jonathan
-----Original Message-----
From: Libva [mailto:[email protected]] On Behalf Of Sean V
Kelley
Sent: Wednesday, December 9, 2015 1:39 PM
To: Balachandran, Sreerenj
Cc: [email protected]
Subject: Re: [Libva] [PATCH] Keep backward compatibility with VA API 0.38.1
Hi,
On Dec 9, 2015, at 8:38 AM, Sreerenj <[email protected]> wrote:
On 09.12.2015 04:27, Xiang, Haihao wrote:
On Mon, 2015-12-07 at 18:51 +0200, Sreerenj wrote:
IMHO, the name "VA_RT_FORMAT_YUV420_10BPP" is confusing...
This chroma type is not just for 10Bitsper channel , but includes
the whole set of "> 8bitis per channel 420 formats", right?
Yes.
Then it is better to opt some other name, since it is really
misleading :)
egs: VA_RT_FORMAT_YUV420_8PLUS_BPP , VA_RT_FORMAT_YUV420_MORETHAN_8BPP
or something better…
I see your point, but I find those also confusing, quite honestly. If we were
to add 12bit support, then we would add a new type as well?
I would almost prefer to see
*_10BPP
*_12BPP
with comments explaining the range of support. But I’m open to more
suggestions.
Thanks,
Sean
On 07.12.2015 07:20, Xiang, Haihao wrote:
I mean Keep backward compatibility with VA API 0.38.0 :(
Signed-off-by: Xiang, Haihao <[email protected]>
---
src/va_backend_compat.h | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/src/va_backend_compat.h b/src/va_backend_compat.h
index 8767153..7f0a607 100644
--- a/src/va_backend_compat.h
+++ b/src/va_backend_compat.h
@@ -50,4 +50,12 @@
# define VAProfileH264StereoHigh 16
#endif
+#if !VA_CHECK_VERSION(0,38,1)
+
+# define VA_RT_FORMAT_YUV420_10BPP 0x00000100
+# define VA_FOURCC_P010 0x30313050
+# define VA_FOURCC_P016 0x36313050
+
+#endif
+
#endif /* VA_BACKEND_COMPAT_H */
_______________________________________________
Libva mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/libva
--
Thanks
Sree
---------------------------------------------------------------------
Intel Finland Oy
Registered Address: PL 281, 00181 Helsinki Business Identity Code:
0357606 - 4 Domiciled in Helsinki This e-mail and any attachments may
contain confidential material for the sole use of the intended
recipient(s). Any review or distribution by others is strictly
prohibited. If you are not the intended recipient, please contact the sender
and delete all copies.
_______________________________________________
Libva mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/libva
_______________________________________________
Libva mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/libva
--
Thanks
Sree
---------------------------------------------------------------------
Intel Finland Oy
Registered Address: PL 281, 00181 Helsinki
Business Identity Code: 0357606 - 4
Domiciled in Helsinki
This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.
_______________________________________________
Libva mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/libva
