> On Nov 4, 2015, at 7:09 AM, Lionel Landwerlin <[email protected]> > wrote: > > I believe there could be space in there to put all the coefficients. > But that would make the code pretty unreadable. > > I've basically offset all the registers in patch 4 & 5 and I agree that 3, 4 > & 5 should be merged together for bisect.
thanks. > > Gen5 & 6 are using a different register mapping and different shaders (struct > pp_static_parameter instead of struct gen7_pp_static_parameter) so this serie > shouldn't have any impact on those gens. agree. > > Would merging 3, 4 and 5 into a single patch be enough? that works for me. > > Thanks, > > - > Lionel > > On 04/11/15 00:34, Zhao Yakui wrote: >> On 11/04/2015 12:56 AM, Lionel Landwerlin wrote: >> >> Is it possible to find the unused field to store the corresponding >> conversion matrix of YUV<->RGB? Otherwise we need to adjust the register >> offset for every VPP shaders. >> >> Even if the constant buffer is increased to hold the conversion matrix, it >> will be better that this patch is added after the patch 04(remap the VPP >> registers). This will help to reduce the effect of git-bisect. >> >>> --- > > _______________________________________________ > Libva mailing list > [email protected] > http://lists.freedesktop.org/mailman/listinfo/libva _______________________________________________ Libva mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/libva
