Ah you’re right, that’s much cleaner.  I’ve updated the patch on github—thanks.

--Matt

From: [email protected] [mailto:[email protected]] On Behalf Of Arun 
Sharma
Sent: Saturday, May 11, 2013 12:25 PM
To: Fischer, Matt
Cc: [email protected]
Subject: Re: [Libunwind-devel] QNX support

On Tue, May 7, 2013 at 3:40 PM, Fischer, Matt 
<[email protected]<mailto:[email protected]>> wrote:
Ok, I’ve finally gotten the actual QNX patch put together.  It took longer than 
I was hoping due to some deficiencies in QNX’s map file support, which led to a 
less-than-ideal implementation of one part of the patch (see comments for 
details).  Other than that, the rest of the patch should hopefully be pretty 
straightforward--just added a new OS type in 
configure.ac/Makefile.am<http://configure.ac/Makefile.am>, as well as a couple 
compiler flag details and some issues with include paths.  I’ve posted the 
change to https://github.com/mattfischer/libunwind, branch 'qnx'.  I'd 
appreciate any comments.

Could you just AC_CHECK_HEADERS for sys/elf.h and sys/link.h and have fewer  
#ifdef __QNX__ in the patch?

 -Arun

________________________________

CONFIDENTIALITY NOTICE: This email and any attachments are for the sole use of 
the intended recipient(s) and contain information that may be confidential 
and/or legally privileged. If you have received this email in error, please 
notify the sender by reply email and delete the message. Any disclosure, 
copying, distribution or use of this communication (including attachments) by 
someone other than the intended recipient is prohibited. Thank you.
_______________________________________________
Libunwind-devel mailing list
[email protected]
https://lists.nongnu.org/mailman/listinfo/libunwind-devel

Reply via email to