Hello Peter, * Peter Rosin wrote on Sun, Jul 18, 2010 at 06:45:53PM CEST: > Next in the MSVC queue. It's getting short quickly! > > These two patches are commits > ee8c181987478752a9432a903cf7febbf761d034 > dllimport when the lib is shared and not linking with -static > > and > > 5ff2e6e4e5a1f05df59ccf11ba881de9df895cb5 > dllimport variables for MSVC in stresstest.at > > Previous review: > http://lists.gnu.org/archive/html/libtool-patches/2008-08/msg00056.html > [...] > The second patch is very similar to how things are done in export.at, > see commit b28132eabade54dbb9ff18a5761be445d916e148 and the recent > thread at > http://lists.gnu.org/archive/html/libtool-patches/2010-07/msg00026.html
The two patches are ok, thanks. However, both of them are another instance of the "if a developer not familiar with MSVC and/or w32 semantics wants to create code portable to this system, then the Libtool manual needs to provide more documentation in order to make this clear" TODO item. Charles, I'm with Peter in that you should prioritize as you please, independently of this. Thanks, Ralf > 2010-07-18 Peter Rosin <[email protected]> > > * tests/stresstest.at: Link with main.lo when liba is shared > and linking main with -no-install. > 2010-07-18 Peter Rosin <[email protected]> > > * tests/stresstest.at [MSVC]: dllimport all imported > variables.
