On Sun, 2007-06-17 at 20:39 +0200, Ralf Wildenhues wrote:
> * Charles Wilson wrote on Sun, Jun 17, 2007 at 08:32:33PM CEST:
> > OK to apply (both branches)?
> 
> Of course.  Thanks.  And no need for my name in the ChangeLog entry.
> 
> Cheers,
> Ralf
> 
> > 2007-06-17  Charles Wilson  <...>
> >             Ralf Wildenhues  <...>
> > 
> >     * libltdl/m4/libtool.m4 (LT_CMD_MAX_LEN): ensure error is
> >     redirected even when getconf does not exist.

I noticed that when I tried this with 'getconf' changed to some
non-existing utility I got errors from expr. Turns out that we need to
quote the string for test -n.

Applied to HEAD and branch-1-5.

Peter

2007-06-17  Peter O'Gorman  <[EMAIL PROTECTED]>

	* libltdl/m4/libtool.m4 (LT_CMD_MAX_LEN): add quotes to
	the test -n.

Index: libltdl/m4/libtool.m4
===================================================================
RCS file: /sources/libtool/libtool/libltdl/m4/libtool.m4,v
retrieving revision 1.106
diff -u -r1.106 libtool.m4
--- libltdl/m4/libtool.m4	17 Jun 2007 20:16:03 -0000	1.106
+++ libltdl/m4/libtool.m4	18 Jun 2007 00:42:17 -0000
@@ -1438,7 +1438,7 @@
     ;;
   *)
     lt_cv_sys_max_cmd_len=`(getconf ARG_MAX) 2> /dev/null`
-    if test -n $lt_cv_sys_max_cmd_len; then
+    if test -n "$lt_cv_sys_max_cmd_len"; then
       lt_cv_sys_max_cmd_len=`expr $lt_cv_sys_max_cmd_len \/ 4`
       lt_cv_sys_max_cmd_len=`expr $lt_cv_sys_max_cmd_len \* 3`
     else

Reply via email to