Hello Peter,
* Peter O'Gorman wrote on Wed, Jun 06, 2007 at 07:22:56AM CEST:
> On Mac OS X it is getting fairly common to configure with -isysroot
> in CFLAGS (hopefully will become less common again when all systems
> are fully fat in 10.5), this patch solves the issue that there are
> no .la files in the sysroots, but there are in /.
It seems weird that this should be fixed on Darwin only but remain
broken everywhere else. IIRC there were reports for other systems, too.
OTOH, your patch isn't a whole fix: it will cause libtool to put the
wrong paths into new installed .la files. Things get even worse if in
the sysroot there are already installed .la files (because then
/sys/root/.../lib*.la will end up in dependency_libs). So the fact that
there are no .la files there helps a wee bit but not fully. A full
solution would keep in mind the sysroot prefix and carry the information
through all the way. That's definitely post next release I would say
though.
So maybe after all there is a reason to accept it for Darwin but nowhere
else. Hmm. I'm quite undecided here. What a mess.
A small style nit: please do not use sed and awk in one pipe. Drop the
case construct and either something like
_lt_root=`echo $ac_link" " | sed -n 's/.* -isysroot \([^ ]*\) .*/\1/p`
if test -n "$_lt_root"; then
...
fi
or just walk the arguments (for lt_arg in $ac_link ...)
Cheers,
Ralf
