Hi,
I have submitted a patch for review:
https://gerrit.libreoffice.org/4140
To pull it, you can do:
git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/40/4140/1
fix for unused return value.
This code was introduced by:
commit d09dd8986436f17717443823ef18bd8552fdf408
Author: Frank Schoenheit [fs] <[email protected]>
Date: Wed Sep 15 13:55:34 2010 +0200
dba34a: export/import min-/max-/default-/value for date/time as
XML-Schema conformant strings
It looks like it intended to use determineDefaultServiceName(), but
neglected to store the return value.
Change-Id: I1607f39cf771b594389492785c7e72478d44843a
---
M xmloff/source/forms/elementimport.cxx
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/xmloff/source/forms/elementimport.cxx
b/xmloff/source/forms/elementimport.cxx
index 9d180b0..443209f 100644
--- a/xmloff/source/forms/elementimport.cxx
+++ b/xmloff/source/forms/elementimport.cxx
@@ -184,7 +184,7 @@
}
if ( m_sServiceName.isEmpty() )
- determineDefaultServiceName();
+ m_sServiceName = determineDefaultServiceName();
// create the object *now*. This allows setting properties in the
various handleAttribute methods.
// (Though currently not all code is migrated to this pattern, most
attributes are still handled
--
To view, visit https://gerrit.libreoffice.org/4140
To unsubscribe, visit https://gerrit.libreoffice.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1607f39cf771b594389492785c7e72478d44843a
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Noel Grandin <[email protected]>
_______________________________________________
LibreOffice mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/libreoffice
