ucb/source/regexp/regexp.cxx | 3 +++
1 file changed, 3 insertions(+)
New commits:
commit a07505865b624b9c9fc5a33e7604ba982302c794
Author: Chr. Rossmanith <[email protected]>
Date: Sat Apr 6 16:50:34 2013 +0200
Add comment the RTL_CONSTASCII_STRINGPARAM should be kept in regexp.cxx
Change-Id: I3cd2129d98c3d936d8ec31f89554b37f12427c1c
diff --git a/ucb/source/regexp/regexp.cxx b/ucb/source/regexp/regexp.cxx
index 58ba065..ffa318c 100644
--- a/ucb/source/regexp/regexp.cxx
+++ b/ucb/source/regexp/regexp.cxx
@@ -374,6 +374,9 @@ Regexp Regexp::parse(rtl::OUString const & rRegexp)
if (p == pEnd)
throw lang::IllegalArgumentException();
+ // This and the matchString() calls below are some of the few places where
+ // RTL_CONSTASCII_STRINGPARAM() should NOT be removed.
+ // (c.f. https://gerrit.libreoffice.org/3117)
if (matchString(&p, pEnd, RTL_CONSTASCII_STRINGPARAM(".*")))
{
if (p != pEnd)
_______________________________________________
Libreoffice-commits mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
