Hi Peter, I fixed it with c13c500630746ba035e0b48c0cbd276aa436db2b. dmake-based build system had option for static link (DYNAMIC_CRT=""), but I could solve it in gbuild, too, with a little hack, i.e. by adding defines, cxx flags and linker flags. The only problem that we get warnings: cl : Command line warning D9025 : overriding '/D_DLL' with '/U_DLL' cl : Command line warning D9025 : overriding '/MD' with '/MT'
Best regards, Andras On Wed, Feb 13, 2013 at 11:39 PM, Peter Foley <[email protected]> wrote: > Andras, > > I'm not sure exactly why it changed or what the problem is. > Do you know how I would force msvcrt to be linked staticly? > > Thanks, > > Peter > > -----Original Message----- From: Andras Timar Sent: Wednesday, February 13, > 2013 6:13 AM To: Peter Foley Cc: libreoffice Subject: Re: [PATCH] convert > setup_native to gbuild and add to tail_build > Hi Peter, > > Thanks, it was a good fix, I did the same for all CustomActions. Just > one more problem: now MSVCRT is linked dinamically. It is not good, > because MSVCRT is not part of the default Windows installation. We > need to link it statically like we did that before. > > Thanks, > Andras > > > On Mon, Feb 11, 2013 at 11:03 PM, Peter Foley <[email protected]> wrote: >> >> Andras, >> >> I just pushed a patch that should fix it. >> Could you test it? >> >> Thanks, >> >> Peter >> >> -----Original Message----- From: Andras Timar Sent: Monday, February 11, >> 2013 7:37 AM To: Peter Foley Cc: libreoffice Subject: Re: [PATCH] convert >> setup_native to gbuild and add to tail_build >> Hi Peter, >> >> On Sat, Feb 9, 2013 at 3:54 PM, Peter Foley (via Code Review) >> <[email protected]> wrote: >>> >>> >>> Hi, >>> >>> I have submitted a patch for review: >>> >>> https://gerrit.libreoffice.org/2063 >>> >> >> I tested you patch and it does not work for me. >> Windows Installer cannot execure any of the CustomActions. E.g.: >> MSI (c) (9C:B0) [13:23:41:427]: Invoking remote custom action. DLL: >> C:\Users\timar\AppData\Local\Temp\MSIAF36.tmp, Entrypoint: >> SelectLanguage >> CustomAction SelectLanguage returned actual error code 1154 but will >> be translated to success due to continue marking >> The problem is that in newly built DLLs the names are mangled, I see >> _SelectLanguage@4 instead of SelectLanguage in Dependency Walker. >> >> Best regards, >> Andras _______________________________________________ LibreOffice mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/libreoffice
