Hello,
Cppcheck reported this:
shell/qa/zip/testimpl/testzipimpl.cxx
57 duplicateExpression style Same expression on both sides of '=='.
52 bool TestZipImpl::test_directory()
53 {
54 ZipFile::DirectoryPtr_t contents = zipFile.GetDirectory();
55 vector<string> &stringVector = *contents.get();
56 sort(stringVector.begin(), stringVector.end());
57 return expectedContents == expectedContents;
58 }
Shouldn't it be
return expectedContents == stringVector;
?
Julien
--
View this message in context:
http://nabble.documentfoundation.org/Cppcheck-Same-expression-in-testzipimpl-cxx-tp4030658.html
Sent from the Dev mailing list archive at Nabble.com.
_______________________________________________
LibreOffice mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/libreoffice
