sc/source/ui/docshell/dbdocfun.cxx | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
New commits: commit 6da661ab5e705973f4d10d6b4755875f6da3b3f5 Author: Kohei Yoshida <[email protected]> Date: Fri Jan 11 12:51:13 2013 -0500 Let's not return here to prevent memory leak. There are several heap objects that are deleted at the end of the method. Returning prematurely would leak those objects. Change-Id: If70cb3c9c02e47229d10b30f1542f7b25534d593 Reviewed-on: https://gerrit.libreoffice.org/1653 Reviewed-by: Markus Mohrhard <[email protected]> Tested-by: Markus Mohrhard <[email protected]> diff --git a/sc/source/ui/docshell/dbdocfun.cxx b/sc/source/ui/docshell/dbdocfun.cxx index 3b1db2f..9f4d58d 100644 --- a/sc/source/ui/docshell/dbdocfun.cxx +++ b/sc/source/ui/docshell/dbdocfun.cxx @@ -1319,8 +1319,7 @@ bool ScDBDocFunc::DataPilotUpdate( ScDPObject* pOldObj, const ScDPObject* pNewOb if ( pDestObj ) { pDestObj->ReloadGroupTableData(); - if (!pDestObj->SyncAllDimensionMembers()) - return false; + pDestObj->SyncAllDimensionMembers(); pDestObj->InvalidateData(); // before getting the new output area // make sure the table has a name (not set by dialog) _______________________________________________ Libreoffice-commits mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
