Hi,

> Anyway, about killing the --directx-home option, even if that is
> done,
> that does not mean having and building against the DirectX SDK (June
> 2010, or some earlier version) would be mandatory. It would just mean
> that if the standard DXSDK_DIR environment variable does not exist,
> then DirectX use is not built, i.e. like --disable-directx.

From packager side I'd strongly recommend against such magic logic,
as it hurts reproducability. Instead all options affecting the build
output should be available as ./configure flags.

So my suggestion is:

* --enable-/--disable-directx should really force building with/without directx.
  default enabled is probably the best choice).
* only if it's enabled, check for the dxsdk. using an environment
  variable instead of separate flag is fine, IMHO, as long as
  that variable is properly documented in ./configure --help output.
* when enabled, but no proper dxsdk found, ./configure fails w/ a
  proper error message

cu
-- 
Mit freundlichen Grüßen / Kind regards 

Enrico Weigelt 
VNC - Virtual Network Consult GmbH 
Head Of Development 

Pariser Platz 4a, D-10117 Berlin
Tel.: +49 (30) 3464615-20
Fax: +49 (30) 3464615-59

[email protected]; www.vnc.de 
_______________________________________________
LibreOffice mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Reply via email to