Hi Noel,
On Wed, 2012-10-03 at 10:15 +0100, Noel Power wrote:
> please consider this patch
>
> http://cgit.freedesktop.org/libreoffice/core/commit/?id=fdb42c397f1d15d05a74492a233df72d832cab1c
Pushed; IIRC using:
- if ( aProps[ i ].Name.equals( "TextPreRotateAngle" ) ..
+ if ( aProps[ i ].Name == "TextPreRotateAngle" ...
Is more efficient (by the power of Lubos' cunning), avoiding a dynamic
allocation, and a couple of atomic operations each comparison. Though
perhaps I remember wrong.
If that's right, would it make sense to have an easy-hack to go over
all re-based modules hunting and replacing .equals with == ?
$ git grep 'equals(' | grep \.cxx | less
Or am I loosing it ;-)
ATB,
Michael.
--
[email protected] <><, Pseudo Engineer, itinerant idiot
_______________________________________________
LibreOffice mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/libreoffice
