svx/source/dialog/hdft.cxx | 17 +++++++++++++---- 1 file changed, 13 insertions(+), 4 deletions(-)
New commits: commit ef1acd9cba6521ae00f71f7bb8336f9e20d72796 Author: Sahil Gautam <[email protected]> AuthorDate: Fri Feb 27 17:21:56 2026 +0530 Commit: Mike Kaganski <[email protected]> CommitDate: Tue Mar 3 09:31:32 2026 +0100 fix: don't use set_buildable_name with LOKit as it crashes JSWidget::set_buildable_name isn't handled on the online side, it has an assert(false) which is reached because of changes introduced in commit f04247351a22d77f4f219342fdc425a832e711df Change-Id: Ie4942d0f38e2c8bbb784b0f7132f3c6da0d89bc6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/200610 Tested-by: Jenkins Reviewed-by: Mike Kaganski <[email protected]> diff --git a/svx/source/dialog/hdft.cxx b/svx/source/dialog/hdft.cxx index 45e877c2221c..9c66bb50cac6 100644 --- a/svx/source/dialog/hdft.cxx +++ b/svx/source/dialog/hdft.cxx @@ -19,6 +19,7 @@ #include <sal/config.h> +#include <comphelper/lok.hxx> #include <o3tl/unit_conversion.hxx> #include <svl/itemiter.hxx> #include <sfx2/objsh.hxx> @@ -172,8 +173,12 @@ SvxHFPage::SvxHFPage(weld::Container* pPage, weld::DialogController* pController m_xBackgroundBtn->set_help_id( u"SVX_HID_FOOTER_BUTTONMORE"_ustr ); // uitest - m_xCntSharedBox->set_buildable_name(m_xCntSharedBox->get_buildable_name() + "-footer"); - m_xCntSharedFirstBox->set_buildable_name(m_xCntSharedFirstBox->get_buildable_name() + "-footer"); + if (!comphelper::LibreOfficeKit::isActive()) + { + m_xCntSharedBox->set_buildable_name(m_xCntSharedBox->get_buildable_name() + "-footer"); + m_xCntSharedFirstBox->set_buildable_name(m_xCntSharedFirstBox->get_buildable_name() + + "-footer"); + } } else //Header { @@ -183,8 +188,12 @@ SvxHFPage::SvxHFPage(weld::Container* pPage, weld::DialogController* pController m_xTurnOnBox = m_xBuilder->weld_check_button(u"checkHeaderOn"_ustr); // uitest - m_xCntSharedBox->set_buildable_name(m_xCntSharedBox->get_buildable_name() + "-header"); - m_xCntSharedFirstBox->set_buildable_name(m_xCntSharedFirstBox->get_buildable_name() + "-header"); + if (!comphelper::LibreOfficeKit::isActive()) + { + m_xCntSharedBox->set_buildable_name(m_xCntSharedBox->get_buildable_name() + "-header"); + m_xCntSharedFirstBox->set_buildable_name(m_xCntSharedFirstBox->get_buildable_name() + + "-header"); + } } m_xTurnOnBox->show();
