sc/qa/unit/tiledrendering/SheetViewTest.cxx | 33 ---------------------------- sc/source/ui/unoobj/docuno.cxx | 4 --- 2 files changed, 37 deletions(-)
New commits: commit 96f6b63a6369e63232904122762465410a315e63 Author: Tomaž Vajngerl <[email protected]> AuthorDate: Thu Feb 26 14:47:37 2026 +0900 Commit: Miklos Vajna <[email protected]> CommitDate: Tue Mar 3 09:03:34 2026 +0100 sc: Remove sheet view ID from the render state This is not needed anymore as the sheet views are now handled as tabs, not using the default view tab for rendering and sheet view tab to get the data. Change-Id: I655064f1fcb3a8a4c2e231c229206bd14d55615d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/200751 Tested-by: Jenkins CollaboraOffice <[email protected]> Reviewed-by: Miklos Vajna <[email protected]> diff --git a/sc/qa/unit/tiledrendering/SheetViewTest.cxx b/sc/qa/unit/tiledrendering/SheetViewTest.cxx index ef5fc57d52c0..81f76a5f9c59 100644 --- a/sc/qa/unit/tiledrendering/SheetViewTest.cxx +++ b/sc/qa/unit/tiledrendering/SheetViewTest.cxx @@ -851,39 +851,6 @@ CPPUNIT_TEST_FIXTURE(SheetViewTest, testRemoveSheetViewHolderTable) } } -CPPUNIT_TEST_FIXTURE(SheetViewTest, testRenderStateInSheetView) -{ - // Check the View Render State is set correctly when in sheet view. - // When in sheet view, we expect the sheet view ID to be set in the state. - - ScModelObj* pModelObj = createDoc("empty.ods"); - - // View 1 - ScTestViewCallback aView1; - - // View 1 - default state - CPPUNIT_ASSERT_EQUAL("S;Default"_ostr, pModelObj->getViewRenderState()); - - // View 2 - SfxLokHelper::createView(); - ScTestViewCallback aView2; - - // View 2 - default state - CPPUNIT_ASSERT_EQUAL("S;Default"_ostr, pModelObj->getViewRenderState()); - - // Create a sheet view in View 2 - createNewSheetViewInCurrentView(); - - // View 2 - state includes view sheet ID - CPPUNIT_ASSERT_EQUAL("S;Default;VS:0"_ostr, pModelObj->getViewRenderState()); - - // Switch to View 1 - SfxLokHelper::setView(aView1.getViewID()); - - // View 1 - still default state - CPPUNIT_ASSERT_EQUAL("S;Default"_ostr, pModelObj->getViewRenderState()); -} - CPPUNIT_TEST_FIXTURE(SheetViewTest, testSyncAfterSorting_DefaultViewSort) { // Two related scenarios tested: diff --git a/sc/source/ui/unoobj/docuno.cxx b/sc/source/ui/unoobj/docuno.cxx index 3a7545db4f60..350e838704f3 100644 --- a/sc/source/ui/unoobj/docuno.cxx +++ b/sc/source/ui/unoobj/docuno.cxx @@ -521,10 +521,6 @@ static OString getTabViewRenderState(ScTabViewShell& rTabViewShell) OString aThemeName = OUStringToOString(rViewRenderingOptions.GetColorSchemeName(), RTL_TEXTENCODING_UTF8); aState.append(aThemeName); - sc::SheetViewID nSheetViewID = rTabViewShell.GetViewData().GetSheetViewID(); - if (nSheetViewID >= 0) - aState.append(";VS:" + OString::number(nSheetViewID)); - return aState.makeStringAndClear(); }
