sw/source/ui/misc/docfnote.cxx | 2 +- sw/uiconfig/swriter/ui/endnotepage.ui | 6 +++--- sw/uiconfig/swriter/ui/footnotepage.ui | 8 ++++---- 3 files changed, 8 insertions(+), 8 deletions(-)
New commits: commit 4ef198714b1bb7d685619710abb54ce902c6251c Author: Parth Raiyani <[email protected]> AuthorDate: Wed Jan 28 16:08:08 2026 +0530 Commit: Caolán McNamara <[email protected]> CommitDate: Thu Feb 26 21:33:22 2026 +0100 a11y: fix accessibility issue in footnote and endnote page ui - rename conflicting label ids - add mnemonic-widget in GtkLabel to correctly reference relevant object Signed-off-by: Parth Raiyani <[email protected]> Change-Id: I8fc046cd364b3968e65bbf0253eac643b556e465 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/198316 Reviewed-by: Caolán McNamara <[email protected]> Tested-by: Jenkins CollaboraOffice <[email protected]> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/200506 diff --git a/sw/source/ui/misc/docfnote.cxx b/sw/source/ui/misc/docfnote.cxx index 96e05cf8eeda..3091bb71711a 100644 --- a/sw/source/ui/misc/docfnote.cxx +++ b/sw/source/ui/misc/docfnote.cxx @@ -78,7 +78,7 @@ SwEndNoteOptionPage::SwEndNoteOptionPage(weld::Container* pPage, weld::DialogCon , m_pSh(nullptr) , m_bPosDoc(false) , m_bEndNote(bEN) - , m_xNumViewBox(new SwNumberingTypeListBox(m_xBuilder->weld_combo_box(u"numberinglb"_ustr))) + , m_xNumViewBox(new SwNumberingTypeListBox(m_xBuilder->weld_combo_box(bEN ? u"endnotenumberinglb"_ustr : u"footnotenumberinglb"_ustr))) , m_xOffsetLbl(m_xBuilder->weld_label(u"offset"_ustr)) , m_xOffsetField(m_xBuilder->weld_spin_button(u"offsetnf"_ustr)) , m_xNumCountBox(m_xBuilder->weld_combo_box(u"countinglb"_ustr)) diff --git a/sw/uiconfig/swriter/ui/endnotepage.ui b/sw/uiconfig/swriter/ui/endnotepage.ui index dbb927d75963..861a8809819a 100644 --- a/sw/uiconfig/swriter/ui/endnotepage.ui +++ b/sw/uiconfig/swriter/ui/endnotepage.ui @@ -37,8 +37,8 @@ <property name="can-focus">False</property> <property name="label" translatable="yes" context="endnotepage|label19">Numbering</property> <property name="use-underline">True</property> - <property name="mnemonic-widget">numberinglb</property> <property name="xalign">0</property> + <property name="mnemonic-widget">endnotenumberinglb</property> </object> <packing> <property name="left-attach">0</property> @@ -46,11 +46,11 @@ </packing> </child> <child> - <object class="GtkComboBoxText" id="numberinglb"> + <object class="GtkComboBoxText" id="endnotenumberinglb"> <property name="visible">True</property> <property name="can-focus">False</property> <child internal-child="accessible"> - <object class="AtkObject" id="numberinglb-atkobject"> + <object class="AtkObject" id="endnotenumberinglb-atkobject"> <property name="AtkObject::accessible-description" translatable="yes" context="endnotepage|extended_tip|numberinglb">Enter the number for the first endnote in the document.</property> </object> </child> diff --git a/sw/uiconfig/swriter/ui/footnotepage.ui b/sw/uiconfig/swriter/ui/footnotepage.ui index 721b3d17b1b8..c680c752f8a9 100644 --- a/sw/uiconfig/swriter/ui/footnotepage.ui +++ b/sw/uiconfig/swriter/ui/footnotepage.ui @@ -36,12 +36,12 @@ <property name="row-spacing">3</property> <property name="column-spacing">6</property> <child> - <object class="GtkLabel" id="label6"> + <object class="GtkLabel" id="footnotelabel6"> <property name="visible">True</property> <property name="can-focus">False</property> <property name="label" translatable="yes" context="footnotepage|label6">Numbering:</property> <property name="use-underline">True</property> - <property name="mnemonic-widget">numberinglb</property> + <property name="mnemonic-widget">footnotenumberinglb</property> <property name="xalign">0</property> </object> <packing> @@ -50,11 +50,11 @@ </packing> </child> <child> - <object class="GtkComboBoxText" id="numberinglb"> + <object class="GtkComboBoxText" id="footnotenumberinglb"> <property name="visible">True</property> <property name="can-focus">False</property> <child internal-child="accessible"> - <object class="AtkObject" id="numberinglb-atkobject"> + <object class="AtkObject" id="footnotenumberinglb-atkobject"> <property name="AtkObject::accessible-description" translatable="yes" context="footnotepage|extended_tip|numberinglb">Select the numbering scheme that you want to use.</property> </object> </child>
