cui/source/tabpages/chardlg.cxx | 2 +- cui/uiconfig/ui/charnamepage.ui | 15 +++++++++++++++ cui/uiconfig/ui/effectspage.ui | 9 +++++++-- cui/uiconfig/ui/twolinespage.ui | 12 ++++++++++++ sw/source/ui/frmdlg/frmpage.cxx | 2 +- sw/uiconfig/swriter/ui/frmaddpage.ui | 6 +++--- sw/uiconfig/swriter/ui/frmtypepage.ui | 4 ++++ sw/uiconfig/swriter/ui/insertbookmark.ui | 5 +++++ sw/uiconfig/swriter/ui/insertcaption.ui | 2 +- sw/uiconfig/swriter/ui/wrappage.ui | 2 +- 10 files changed, 50 insertions(+), 9 deletions(-)
New commits: commit fe1ade3d0537196f882cff2d097656458c9f5e89 Author: Parth Raiyani <[email protected]> AuthorDate: Wed Jan 28 15:33:56 2026 +0530 Commit: Caolán McNamara <[email protected]> CommitDate: Thu Feb 26 20:51:14 2026 +0100 a11y: enhance accessibility in frmaddpage.ui and frmtypepage.ui - add static role in GtkLabel for better accessibility - rename conflicting label ids - add mnemonic-widget in GtkLabel to correctly reference relevant object Signed-off-by: Parth Raiyani <[email protected]> Change-Id: If5a1f1cac6fe9698a5fd7e64f2759a169acc9bfe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/198307 Reviewed-by: Caolán McNamara <[email protected]> Tested-by: Jenkins CollaboraOffice <[email protected]> Tested-by: Caolán McNamara <[email protected]> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/200481 diff --git a/cui/source/tabpages/chardlg.cxx b/cui/source/tabpages/chardlg.cxx index 910eb2e535ef..c5795973b180 100644 --- a/cui/source/tabpages/chardlg.cxx +++ b/cui/source/tabpages/chardlg.cxx @@ -1331,7 +1331,7 @@ SvxCharEffectsPage::SvxCharEffectsPage(weld::Container* pPage, weld::DialogContr , m_xFontTransparencyFT(m_xBuilder->weld_label(u"fonttransparencyft"_ustr)) , m_xFontTransparencyMtr( m_xBuilder->weld_metric_spin_button(u"fonttransparencymtr"_ustr, FieldUnit::PERCENT)) - , m_xEffectsFT(m_xBuilder->weld_label(u"effectsft"_ustr)) + , m_xEffectsFT(m_xBuilder->weld_label(u"caseft"_ustr)) , m_xEffectsLB(m_xBuilder->weld_combo_box(u"effectslb"_ustr)) , m_xReliefFT(m_xBuilder->weld_label(u"reliefft"_ustr)) , m_xReliefLB(m_xBuilder->weld_combo_box(u"relieflb"_ustr)) diff --git a/cui/uiconfig/ui/charnamepage.ui b/cui/uiconfig/ui/charnamepage.ui index 3864223029d8..40e7cc367c65 100644 --- a/cui/uiconfig/ui/charnamepage.ui +++ b/cui/uiconfig/ui/charnamepage.ui @@ -315,6 +315,11 @@ <attributes> <attribute name="scale" value="0.9"/> </attributes> + <child internal-child="accessible"> + <object class="AtkObject" id="lbWestFontinfo-atkobject"> + <property name="AtkObject::accessible-role">static</property> + </object> + </child> </object> <packing> <property name="left-attach">1</property> @@ -594,6 +599,11 @@ <attributes> <attribute name="scale" value="0.9"/> </attributes> + <child internal-child="accessible"> + <object class="AtkObject" id="lbCJKFontinfo-atkobject"> + <property name="AtkObject::accessible-role">static</property> + </object> + </child> </object> <packing> <property name="left-attach">1</property> @@ -848,6 +858,11 @@ <attributes> <attribute name="scale" value="0.9"/> </attributes> + <child internal-child="accessible"> + <object class="AtkObject" id="lbCTLFontinfo-atkobject"> + <property name="AtkObject::accessible-role">static</property> + </object> + </child> </object> <packing> <property name="left-attach">1</property> diff --git a/cui/uiconfig/ui/effectspage.ui b/cui/uiconfig/ui/effectspage.ui index 3b61fae6dfe1..11d1b28109f3 100644 --- a/cui/uiconfig/ui/effectspage.ui +++ b/cui/uiconfig/ui/effectspage.ui @@ -69,7 +69,7 @@ <property name="row-spacing">6</property> <property name="column-spacing">12</property> <child> - <object class="GtkLabel" id="effectsft"> + <object class="GtkLabel" id="caseft"> <property name="visible">True</property> <property name="can-focus">False</property> <property name="label" translatable="yes" context="effectspage|effectsft">_Case:</property> @@ -621,6 +621,11 @@ <property name="wrap">True</property> <property name="max-width-chars">50</property> <property name="xalign">0</property> + <child internal-child="accessible"> + <object class="AtkObject" id="a11ywarning-atkobject"> + <property name="AtkObject::accessible-role">static</property> + </object> + </child> </object> <packing> <property name="left-attach">1</property> @@ -691,7 +696,7 @@ <object class="GtkSizeGroup" id="sizegroup1"> <property name="ignore-hidden">True</property> <widgets> - <widget name="effectsft"/> + <widget name="caseft"/> <widget name="reliefft"/> <widget name="positionft"/> <widget name="emphasisft"/> diff --git a/cui/uiconfig/ui/twolinespage.ui b/cui/uiconfig/ui/twolinespage.ui index 164f43e4103f..8ffd95ebbede 100644 --- a/cui/uiconfig/ui/twolinespage.ui +++ b/cui/uiconfig/ui/twolinespage.ui @@ -85,6 +85,12 @@ <property name="visible">True</property> <property name="can_focus">False</property> <property name="label" translatable="yes" context="twolinespage|label29">Initial character</property> + <property name="mnemonic-widget">startbracket</property> + <child internal-child="accessible"> + <object class="AtkObject" id="label29-atkobject"> + <property name="AtkObject::accessible-role">static</property> + </object> + </child> </object> <packing> <property name="left_attach">0</property> @@ -96,6 +102,12 @@ <property name="visible">True</property> <property name="can_focus">False</property> <property name="label" translatable="yes" context="twolinespage|label30">Final character</property> + <property name="mnemonic-widget">endbracket</property> + <child internal-child="accessible"> + <object class="AtkObject" id="label30-atkobject"> + <property name="AtkObject::accessible-role">static</property> + </object> + </child> </object> <packing> <property name="left_attach">1</property> diff --git a/sw/uiconfig/swriter/ui/insertbookmark.ui b/sw/uiconfig/swriter/ui/insertbookmark.ui index f925aff4788d..67684e7e0ac5 100644 --- a/sw/uiconfig/swriter/ui/insertbookmark.ui +++ b/sw/uiconfig/swriter/ui/insertbookmark.ui @@ -88,6 +88,11 @@ <property name="hexpand">True</property> <property name="label" translatable="no" context="insertbookmark|lbForbiddenChars">Forbidden characters:</property> <property name="single-line-mode">True</property> + <child internal-child="accessible"> + <object class="AtkObject" id="lbForbiddenChars-atkobject"> + <property name="AtkObject::accessible-role">static</property> + </object> + </child> </object> <packing> <property name="left-attach">1</property> diff --git a/sw/uiconfig/swriter/ui/insertcaption.ui b/sw/uiconfig/swriter/ui/insertcaption.ui index 199261997465..47de9de1de74 100644 --- a/sw/uiconfig/swriter/ui/insertcaption.ui +++ b/sw/uiconfig/swriter/ui/insertcaption.ui @@ -297,7 +297,7 @@ </packing> </child> <child> - <object class="GtkLabel" id="label4"> + <object class="GtkLabel" id="iclabel4"> <property name="visible">True</property> <property name="can_focus">False</property> <property name="halign">start</property> diff --git a/sw/uiconfig/swriter/ui/wrappage.ui b/sw/uiconfig/swriter/ui/wrappage.ui index 710d6de3a590..2c6d4a427aeb 100644 --- a/sw/uiconfig/swriter/ui/wrappage.ui +++ b/sw/uiconfig/swriter/ui/wrappage.ui @@ -497,7 +497,7 @@ </packing> </child> <child> - <object class="GtkLabel" id="label7"> + <object class="GtkLabel" id="wraplabel7"> <property name="visible">True</property> <property name="can-focus">False</property> <property name="label" translatable="yes" context="wrappage|label7">_Bottom:</property> commit 5edb4cbca151dca762acab2bbcdd663e4f120532 Author: Parth Raiyani <[email protected]> AuthorDate: Wed Jan 28 15:26:22 2026 +0530 Commit: Caolán McNamara <[email protected]> CommitDate: Thu Feb 26 20:51:07 2026 +0100 a11y: enhance accessibility in frmaddpage.ui and frmtypepage.ui - add mnemonic-widget in GtkLabel to correctly reference relevant object - rename conflicting label ids Change-Id: I36fe46335faa93b068ef1c59ea5743134b4e0a4b Signed-off-by: Parth Raiyani <[email protected]> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/198306 Tested-by: Jenkins CollaboraOffice <[email protected]> Reviewed-by: Caolán McNamara <[email protected]> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/200474 diff --git a/sw/source/ui/frmdlg/frmpage.cxx b/sw/source/ui/frmdlg/frmpage.cxx index ef931a4ca65d..4b7d66a7b193 100644 --- a/sw/source/ui/frmdlg/frmpage.cxx +++ b/sw/source/ui/frmdlg/frmpage.cxx @@ -2988,7 +2988,7 @@ SwFrameAddPage::SwFrameAddPage(weld::Container* pPage, weld::DialogController* p , m_bFormat(false) , m_bNew(false) , m_xNameFrame(m_xBuilder->weld_widget(u"nameframe"_ustr)) - , m_xNameFT(m_xBuilder->weld_label(u"name_label"_ustr)) + , m_xNameFT(m_xBuilder->weld_label(u"frm_add_name_label"_ustr)) , m_xNameED(m_xBuilder->weld_entry(u"name"_ustr)) , m_xAltNameFT(m_xBuilder->weld_label(u"altname_label"_ustr)) , m_xAltNameED(m_xBuilder->weld_entry(u"altname"_ustr)) diff --git a/sw/uiconfig/swriter/ui/frmaddpage.ui b/sw/uiconfig/swriter/ui/frmaddpage.ui index 0c72dbe3e883..f700c2f07910 100644 --- a/sw/uiconfig/swriter/ui/frmaddpage.ui +++ b/sw/uiconfig/swriter/ui/frmaddpage.ui @@ -92,7 +92,7 @@ </packing> </child> <child> - <object class="GtkLabel" id="name_label"> + <object class="GtkLabel" id="frm_add_name_label"> <property name="visible">True</property> <property name="can-focus">False</property> <property name="label" translatable="yes" context="frmaddpage|name_label">_Name:</property> @@ -230,7 +230,7 @@ <property name="margin-top">6</property> <property name="column-spacing">12</property> <child> - <object class="GtkLabel" id="label2"> + <object class="GtkLabel" id="frm_add_label2"> <property name="visible">True</property> <property name="can-focus">False</property> <property name="label" translatable="yes" context="frmaddpage|label2">_Vertical alignment:</property> @@ -498,7 +498,7 @@ <object class="GtkSizeGroup" id="sizegroup1"> <property name="ignore-hidden">True</property> <widgets> - <widget name="name_label"/> + <widget name="frm_add_name_label"/> <widget name="altname_label"/> <widget name="description_label"/> <widget name="textflow_label"/> diff --git a/sw/uiconfig/swriter/ui/frmtypepage.ui b/sw/uiconfig/swriter/ui/frmtypepage.ui index 14e24f34b93d..ac16ab7c528c 100644 --- a/sw/uiconfig/swriter/ui/frmtypepage.ui +++ b/sw/uiconfig/swriter/ui/frmtypepage.ui @@ -71,6 +71,7 @@ <property name="visible">True</property> <property name="can-focus">False</property> <property name="label" translatable="yes" context="frmtypepage|widthft">_Width</property> + <property name="mnemonic-widget">width</property> <property name="use-underline">True</property> <property name="xalign">0</property> </object> @@ -85,6 +86,7 @@ <property name="visible">True</property> <property name="can-focus">False</property> <property name="label" translatable="yes" context="frmtypepage|autowidthft">_Width (at least)</property> + <property name="mnemonic-widget">width</property> <property name="use-underline">True</property> <property name="xalign">0</property> </object> @@ -194,6 +196,7 @@ <property name="visible">True</property> <property name="can-focus">False</property> <property name="label" translatable="yes" context="frmtypepage|heightft">H_eight</property> + <property name="mnemonic-widget">height</property> <property name="use-underline">True</property> <property name="xalign">0</property> </object> @@ -208,6 +211,7 @@ <property name="visible">True</property> <property name="can-focus">False</property> <property name="label" translatable="yes" context="frmtypepage|autoheightft">H_eight (at least)</property> + <property name="mnemonic-widget">height</property> <property name="use-underline">True</property> <property name="xalign">0</property> </object>
