Noel Power píše v Pá 06. 07. 2012 v 14:41 +0100: > On 28/06/12 19:02, Jan Holesovsky wrote: > I ask > for a review here. > > the changes in question are : > http://cgit.freedesktop.org/libreoffice/core/commit/?id=a1345cd93a57ec7d9352f2c71ec2664332ce5e76 > http://cgit.freedesktop.org/libreoffice/core/commit/?id=2bc2d09bba2e3f34e8ce13571de9ff7007e1c2b6
The change makes sense. The patches look reasonable. It works. I checked few things in the UI and did not find any side effects. It seems that you did lots checks to do not break things => pushed into 3-6 branch: http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-6&id=99cad9fd7f413adecffc527d334eff616799cc4b http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-6&id=aea425a8cd851e6bee02247673c8996b58789484 Best Regards, Petr _______________________________________________ LibreOffice mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/libreoffice
