vcl/jsdialog/enabled.cxx | 29 +++++++++++++++++++++++++++++ 1 file changed, 29 insertions(+)
New commits: commit bb3e02671e27f0130335eb46a77b0dd36b1a1c83 Author: Caolán McNamara <[email protected]> AuthorDate: Mon Jan 26 16:40:32 2026 +0000 Commit: Caolán McNamara <[email protected]> CommitDate: Fri Feb 13 21:53:56 2026 +0100 add the 'Other' category into coverage report Change-Id: I509dc47fd66da92ac4a4a9d2f4e76f9080b2c85c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/198171 Reviewed-by: Miklos Vajna <[email protected]> Tested-by: Jenkins CollaboraOffice <[email protected]> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/199327 Reviewed-by: Caolán McNamara <[email protected]> Tested-by: Jenkins diff --git a/vcl/jsdialog/enabled.cxx b/vcl/jsdialog/enabled.cxx index d333b7d38fb5..f9cd0388c890 100644 --- a/vcl/jsdialog/enabled.cxx +++ b/vcl/jsdialog/enabled.cxx @@ -721,6 +721,10 @@ std::vector<OUString> completeCommonDialogList(const o3tl::sorted_vector<OUStrin // Skip this one, I don't think it can appear in practice if (entry == u"sfx/ui/cmisinfopage.ui") continue; + // Skip this one, I think it can only happen on loading + // an archaic wordperfect file + else if (entry == u"writerperfect/ui/wpftencodingdialog.ui") + continue; // Skip this one, I don't think it can appear in practice else if (entry == u"cui/ui/colorpickerdialog.ui") continue; @@ -750,6 +754,30 @@ std::vector<OUString> completeCommonDialogList(const o3tl::sorted_vector<OUStrin // from calc. else if (entry == u"cui/ui/eventassigndialog.ui") continue; + // Skip this one, it is disabled in filter/source/pdf/impdialog.cxx + // for kit mode + else if (entry == u"filter/ui/pdfsignpage.ui") + continue; + // This, for the chart wizard, it is really only available in calc + else if (entry == u"vcl/ui/wizard.ui") + continue; + // The warn dialog appears to be somewhat broken, at least the + // existing tests for it are currently disabled and it doesn't + // work for me + else if (entry == u"uui/ui/macrowarnmedium.ui") + continue; + // This, for the forumula dialog, are really only available in calc + else if (entry == u"formula/ui/formuladialog.ui" || + entry == u"formula/ui/functionpage.ui" || + entry == u"formula/ui/parameter.ui" || + entry == u"formula/ui/structpage.ui") + { + continue; + } + // Testing this requires hosting an image, or similar, with + // a username+password + else if (entry == u"uui/ui/logindialog.ui") + continue; OUString sEntry(entry); if (!entries.contains(sEntry)) missing.push_back(sEntry); @@ -757,6 +785,7 @@ std::vector<OUString> completeCommonDialogList(const o3tl::sorted_vector<OUStrin }; processCategory(CuiDialogList); processCategory(SfxDialogList); + processCategory(OtherDialogList); return missing; }
