editeng/source/items/CustomPropertyField.cxx | 5 -- editeng/source/items/flditem.cxx | 46 --------------------------- include/editeng/CustomPropertyField.hxx | 2 - include/editeng/flditem.hxx | 15 -------- 4 files changed, 68 deletions(-)
New commits: commit ea064cc802c874062c7526781502611e341d8401 Author: Noel Grandin <[email protected]> AuthorDate: Thu Aug 14 09:48:00 2025 +0200 Commit: Noel Grandin <[email protected]> CommitDate: Thu Aug 14 11:56:15 2025 +0200 createBeginComment is unused since commit 83ffcdd964611c739e5235e829d015c4965b55d7 Author: Armin Le Grand (collabora) <[email protected]> Date: Mon Aug 4 14:15:15 2025 +0200 StripPortions: Further simplify EditEngine Change-Id: Ib58613186a8bd169ea15b1958066006e3437bf34 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189567 Tested-by: Jenkins Reviewed-by: Noel Grandin <[email protected]> diff --git a/editeng/source/items/CustomPropertyField.cxx b/editeng/source/items/CustomPropertyField.cxx index 463f128ea2f1..79594749c1bb 100644 --- a/editeng/source/items/CustomPropertyField.cxx +++ b/editeng/source/items/CustomPropertyField.cxx @@ -43,11 +43,6 @@ bool CustomPropertyField::operator==(const SvxFieldData& rOther) const msCurrentPresentation == rOtherField.msCurrentPresentation); } -MetaAction* CustomPropertyField::createBeginComment() const -{ - return new MetaCommentAction("FIELD_SEQ_BEGIN"_ostr); -} - const OUString & CustomPropertyField::GetFormatted(uno::Reference<document::XDocumentProperties> const & xDocumentProperties) { if (msName.isEmpty()) diff --git a/editeng/source/items/flditem.cxx b/editeng/source/items/flditem.cxx index 6f51528519d0..e28582a6d93b 100644 --- a/editeng/source/items/flditem.cxx +++ b/editeng/source/items/flditem.cxx @@ -266,16 +266,6 @@ bool SvxFieldData::operator==( const SvxFieldData& rFld ) const } -MetaAction* SvxFieldData::createBeginComment() const -{ - return new MetaCommentAction( "FIELD_SEQ_BEGIN"_ostr ); -} - -MetaAction* SvxFieldData::createEndComment() -{ - return new MetaCommentAction( "FIELD_SEQ_END"_ostr ); -} - void SvxFieldData::dumpAsXml(xmlTextWriterPtr pWriter) const { (void)xmlTextWriterStartElement(pWriter, BAD_CAST("SvxFieldData")); @@ -443,11 +433,6 @@ OUString SvxDateField::GetFormatted( Date const & aDate, SvxDateFormat eFormat, return aStr; } -MetaAction* SvxDateField::createBeginComment() const -{ - return new MetaCommentAction( "FIELD_SEQ_BEGIN"_ostr ); -} - SvxURLField::SvxURLField() { eFormat = SvxURLFormat::Url; @@ -480,15 +465,6 @@ bool SvxURLField::operator==( const SvxFieldData& rOther ) const } -MetaAction* SvxURLField::createBeginComment() const -{ - // #i46618# Adding target URL to metafile comment - return new MetaCommentAction( "FIELD_SEQ_BEGIN"_ostr, - 0, - reinterpret_cast<const sal_uInt8*>(aURL.getStr()), - 2*aURL.getLength() ); -} - void SvxURLField::dumpAsXml(xmlTextWriterPtr pWriter) const { (void)xmlTextWriterStartElement(pWriter, BAD_CAST("SvxURLField")); @@ -517,11 +493,6 @@ bool SvxPageTitleField::operator==( const SvxFieldData& rCmp ) const return ( dynamic_cast< const SvxPageTitleField *>(&rCmp) != nullptr ); } -MetaAction* SvxPageTitleField::createBeginComment() const -{ - return new MetaCommentAction( "FIELD_SEQ_BEGIN;PageTitleField"_ostr ); -} - // // SvxPagesField // @@ -540,12 +511,6 @@ bool SvxPageField::operator==( const SvxFieldData& rCmp ) const return ( dynamic_cast< const SvxPageField *>(&rCmp) != nullptr ); } -MetaAction* SvxPageField::createBeginComment() const -{ - return new MetaCommentAction( "FIELD_SEQ_BEGIN;PageField"_ostr ); -} - - SvxPagesField::SvxPagesField() {} std::unique_ptr<SvxFieldData> SvxPagesField::Clone() const @@ -570,11 +535,6 @@ bool SvxTimeField::operator==( const SvxFieldData& rCmp ) const return ( dynamic_cast< const SvxTimeField *>(&rCmp) != nullptr); } -MetaAction* SvxTimeField::createBeginComment() const -{ - return new MetaCommentAction( "FIELD_SEQ_BEGIN"_ostr ); -} - SvxFileField::SvxFileField() {} std::unique_ptr<SvxFieldData> SvxFileField::Clone() const @@ -715,12 +675,6 @@ OUString SvxExtTimeField::GetFormatted( tools::Time const & aTime, SvxTimeFormat return aStr; } -MetaAction* SvxExtTimeField::createBeginComment() const -{ - return new MetaCommentAction( "FIELD_SEQ_BEGIN"_ostr ); -} - - // SvxExtFileField diff --git a/include/editeng/CustomPropertyField.hxx b/include/editeng/CustomPropertyField.hxx index 9608ccb9c8bb..e4b1bcc2c98b 100644 --- a/include/editeng/CustomPropertyField.hxx +++ b/include/editeng/CustomPropertyField.hxx @@ -39,8 +39,6 @@ public: virtual std::unique_ptr<SvxFieldData> Clone() const override; virtual bool operator==(const SvxFieldData&) const override; - virtual MetaAction* createBeginComment() const override; - const OUString & GetFormatted(css::uno::Reference<css::document::XDocumentProperties> const & xDocumentProperties); OUString const & GetName() const diff --git a/include/editeng/flditem.hxx b/include/editeng/flditem.hxx index 76a1e3749a93..a901336b54a4 100644 --- a/include/editeng/flditem.hxx +++ b/include/editeng/flditem.hxx @@ -57,9 +57,6 @@ public: virtual std::unique_ptr<SvxFieldData> Clone() const; virtual bool operator==( const SvxFieldData& ) const; virtual void dumpAsXml(xmlTextWriterPtr pWriter) const; - - virtual MetaAction* createBeginComment() const; - static MetaAction* createEndComment(); }; /** @@ -133,8 +130,6 @@ public: virtual std::unique_ptr<SvxFieldData> Clone() const override; virtual bool operator==( const SvxFieldData& ) const override; - - virtual MetaAction* createBeginComment() const override; }; @@ -178,8 +173,6 @@ public: virtual std::unique_ptr<SvxFieldData> Clone() const override; virtual bool operator==( const SvxFieldData& ) const override; void dumpAsXml(xmlTextWriterPtr pWriter) const override; - - virtual MetaAction* createBeginComment() const override; }; class EDITENG_DLLPUBLIC SvxPageField final: public SvxFieldData @@ -190,8 +183,6 @@ public: virtual std::unique_ptr<SvxFieldData> Clone() const override; virtual bool operator==( const SvxFieldData& ) const override; - - virtual MetaAction* createBeginComment() const override; }; class EDITENG_DLLPUBLIC SvxPageTitleField final: public SvxFieldData @@ -203,8 +194,6 @@ public: virtual std::unique_ptr<SvxFieldData> Clone() const override; virtual bool operator==( const SvxFieldData& ) const override; - - virtual MetaAction* createBeginComment() const override; }; class EDITENG_DLLPUBLIC SvxPagesField final: public SvxFieldData @@ -227,8 +216,6 @@ public: virtual std::unique_ptr<SvxFieldData> Clone() const override; virtual bool operator==( const SvxFieldData& ) const override; - - virtual MetaAction* createBeginComment() const override; }; class EDITENG_DLLPUBLIC SvxFileField final: public SvxFieldData @@ -309,8 +296,6 @@ public: virtual std::unique_ptr<SvxFieldData> Clone() const override; virtual bool operator==( const SvxFieldData& ) const override; - - virtual MetaAction* createBeginComment() const override; };
