chart2/source/tools/ExplicitCategoriesProvider.cxx | 2 +-
connectivity/source/commontools/FDatabaseMetaDataResultSet.cxx | 2 +-
connectivity/source/drivers/file/FDatabaseMetaData.cxx | 2 +-
dbaccess/source/ui/querydesign/JoinController.cxx | 2 +-
emfio/source/reader/mtftools.cxx | 2 +-
framework/source/fwe/classes/addonsoptions.cxx | 2 +-
include/basegfx/range/b2dconnectedranges.hxx | 2 +-
oox/inc/drawingml/scene3dhelper.hxx | 2 +-
oox/source/drawingml/scene3dhelper.cxx | 9 ++++-----
sc/source/filter/orcus/autofilter.cxx | 2 +-
sd/source/console/PresenterTextView.cxx | 2 +-
sw/source/core/text/itradj.cxx | 4 ++--
sw/source/filter/ww8/ww8scan.cxx | 2 +-
sw/source/filter/ww8/ww8toolbar.cxx | 4 ++--
sw/source/ui/dbui/createaddresslistdialog.cxx | 2 +-
sw/source/writerfilter/dmapper/DomainMapper_Impl.cxx | 2 +-
unotools/source/config/fontcfg.cxx | 2 +-
xmloff/source/chart/SchXMLChartContext.cxx | 2 +-
xmloff/source/chart/SchXMLSeries2Context.cxx | 2 +-
xmlscript/source/xmllib_imexp/xmllib_import.cxx | 2 +-
xmlsecurity/source/helper/xsecsign.cxx | 2 +-
21 files changed, 26 insertions(+), 27 deletions(-)
New commits:
commit d02fde021cfca40783cb5c7e87a8ed686fec89c1
Author: Caolán McNamara <caolan.mcnam...@collabora.com>
AuthorDate: Mon Aug 11 08:37:11 2025 +0100
Commit: Caolán McNamara <caolan.mcnam...@collabora.com>
CommitDate: Mon Aug 11 13:16:28 2025 +0200
cid#1659748 Variable copied when it could be moved
and
cid#1659754 Variable copied when it could be moved
cid#1659755 Variable copied when it could be moved
cid#1659756 Variable copied when it could be moved
cid#1659766 Variable copied when it could be moved
cid#1659767 Variable copied when it could be moved
cid#1659769 Variable copied when it could be moved
cid#1659770 Variable copied when it could be moved
cid#1659777 Variable copied when it could be moved
cid#1659787 Variable copied when it could be moved
cid#1659790 Variable copied when it could be moved
cid#1659793 Variable copied when it could be moved
cid#1659802 Variable copied when it could be moved
cid#1659818 Variable copied when it could be moved
cid#1659822 Variable copied when it could be moved
cid#1659824 Variable copied when it could be moved
cid#1659825 Variable copied when it could be moved
cid#1659826 Variable copied when it could be moved
cid#1659842 Variable copied when it could be moved
cid#1659849 Variable copied when it could be moved
cid#1659850 Variable copied when it could be moved
Change-Id: I70729aaf6e229518a9a50ac18311286ab5b05b53
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189348
Reviewed-by: Caolán McNamara <caolan.mcnam...@collabora.com>
Tested-by: Jenkins
diff --git a/chart2/source/tools/ExplicitCategoriesProvider.cxx
b/chart2/source/tools/ExplicitCategoriesProvider.cxx
index df431908f3f3..4fdb742da390 100644
--- a/chart2/source/tools/ExplicitCategoriesProvider.cxx
+++ b/chart2/source/tools/ExplicitCategoriesProvider.cxx
@@ -372,7 +372,7 @@ static Sequence< OUString > lcl_getExplicitSimpleCategories(
while( nCount-- )
aSingleLevel.push_back(elem);
}
- aComplexCatsPerIndex.push_back( aSingleLevel );
+ aComplexCatsPerIndex.push_back(std::move(aSingleLevel));
}
if(nMaxCategoryCount)
diff --git a/connectivity/source/commontools/FDatabaseMetaDataResultSet.cxx
b/connectivity/source/commontools/FDatabaseMetaDataResultSet.cxx
index b2f7f8d86e51..67d6bd871756 100644
--- a/connectivity/source/commontools/FDatabaseMetaDataResultSet.cxx
+++ b/connectivity/source/commontools/FDatabaseMetaDataResultSet.cxx
@@ -777,7 +777,7 @@ void SAL_CALL ODatabaseMetaDataResultSet::initialize( const
Sequence< Any >& _aA
}
aRowToSet.push_back(aValue);
}
- aRowsToSet.push_back(aRowToSet);
+ aRowsToSet.push_back(std::move(aRowToSet));
} // for (; pRowsIter != pRowsEnd;++pRowsIter
setRows(std::move(aRowsToSet));
}
diff --git a/connectivity/source/drivers/file/FDatabaseMetaData.cxx
b/connectivity/source/drivers/file/FDatabaseMetaData.cxx
index f06e7d63f5c3..533b5c15e658 100644
--- a/connectivity/source/drivers/file/FDatabaseMetaData.cxx
+++ b/connectivity/source/drivers/file/FDatabaseMetaData.cxx
@@ -301,7 +301,7 @@ Reference< XResultSet > SAL_CALL
ODatabaseMetaData::getTables(
aRow.push_back(new ORowSetValueDecorator(aTable));
aRow.push_back(ODatabaseMetaDataResultSet::getEmptyValue());
- aRows.push_back(aRow);
+ aRows.push_back(std::move(aRow));
}
}
diff --git a/dbaccess/source/ui/querydesign/JoinController.cxx
b/dbaccess/source/ui/querydesign/JoinController.cxx
index cac9082a0903..c8cdf45492c9 100644
--- a/dbaccess/source/ui/querydesign/JoinController.cxx
+++ b/dbaccess/source/ui/querydesign/JoinController.cxx
@@ -347,7 +347,7 @@ void OJoinController::loadTableWindow( const
::comphelper::NamedValueCollection&
pData->SetPosition(Point(nX,nY));
pData->SetSize( Size( nWidth, nHeight ) );
pData->ShowAll(bShowAll);
- m_vTableData.push_back(pData);
+ m_vTableData.push_back(std::move(pData));
if ( m_aMinimumTableViewSize.X() < (nX+nWidth) )
m_aMinimumTableViewSize.setX( nX+nWidth );
if ( m_aMinimumTableViewSize.Y() < (nY+nHeight) )
diff --git a/emfio/source/reader/mtftools.cxx b/emfio/source/reader/mtftools.cxx
index a6409d0257b4..74b358e111c2 100644
--- a/emfio/source/reader/mtftools.cxx
+++ b/emfio/source/reader/mtftools.cxx
@@ -2462,7 +2462,7 @@ namespace emfio
SAL_INFO("emfio", " DevOrg: " << mnDevOrgX << ", " <<
mnDevOrgY);
SAL_INFO("emfio", " DevWidth/Height: " << mnDevWidth << "
x " << mnDevHeight);
SAL_INFO("emfio", " LineStyle: " << maLineStyle.aLineColor
<< " FillStyle: " << maFillStyle.aFillColor );
- mvSaveStack.push_back( pSave );
+ mvSaveStack.push_back(std::move(pSave));
}
void MtfTools::Pop( const sal_Int32 nSavedDC )
diff --git a/framework/source/fwe/classes/addonsoptions.cxx
b/framework/source/fwe/classes/addonsoptions.cxx
index e2826b30f451..2dd3f6d33b1a 100644
--- a/framework/source/fwe/classes/addonsoptions.cxx
+++ b/framework/source/fwe/classes/addonsoptions.cxx
@@ -979,7 +979,7 @@ void AddonsOptions_Impl::ReadMenuMergeInstructions(
MergeMenuInstructionContaine
ReadMergeMenuData( aMergeAddonInstructionBase,
aMergeMenuInstruction.aMergeMenu );
- aContainer.push_back( aMergeMenuInstruction );
+ aContainer.push_back(std::move(aMergeMenuInstruction));
}
}
}
diff --git a/include/basegfx/range/b2dconnectedranges.hxx
b/include/basegfx/range/b2dconnectedranges.hxx
index f452fffb5404..fa442d62fb82 100644
--- a/include/basegfx/range/b2dconnectedranges.hxx
+++ b/include/basegfx/range/b2dconnectedranges.hxx
@@ -200,7 +200,7 @@ namespace basegfx
// add aNewConnectedComponent as a new entry to
// maDisjunctAggregatesList
- maDisjunctAggregatesList.push_back( aNewConnectedComponent );
+
maDisjunctAggregatesList.push_back(std::move(aNewConnectedComponent));
}
/** Apply a functor to each of the disjunct component
diff --git a/oox/inc/drawingml/scene3dhelper.hxx
b/oox/inc/drawingml/scene3dhelper.hxx
index d0c9598157ba..562d471de4fc 100644
--- a/oox/inc/drawingml/scene3dhelper.hxx
+++ b/oox/inc/drawingml/scene3dhelper.hxx
@@ -37,7 +37,7 @@ public:
@return Returns true if extrusion properties are generated. Returns
false if there is no 3D
or if rendering without 3D is currently better. rPropertyMap is
unchanged in such case.
*/
- bool setExtrusionProperties(const oox::drawingml::Shape3DPropertiesPtr
p3DProperties,
+ bool setExtrusionProperties(const oox::drawingml::Shape3DPropertiesPtr&
p3DProperties,
const sal_Int32& rnMSOShapeRotation,
oox::PropertyMap& rPropertyMap,
double& rRotZ, oox::drawingml::Color&
rExtrusionColor,
const bool bBlockExtrusion = false);
diff --git a/oox/source/drawingml/scene3dhelper.cxx
b/oox/source/drawingml/scene3dhelper.cxx
index 6e0fb0b107a2..534f07d47152 100644
--- a/oox/source/drawingml/scene3dhelper.cxx
+++ b/oox/source/drawingml/scene3dhelper.cxx
@@ -378,11 +378,10 @@ void Scene3DHelper::addProjectionGeometryToMap(
// shift of the viewpoint in relation to the shapes of the group, for
example.
}
-bool Scene3DHelper::setExtrusionProperties(const
oox::drawingml::Shape3DPropertiesPtr p3DProperties,
- const sal_Int32& rnMSOShapeRotation,
- oox::PropertyMap& rPropertyMap,
double& rRotZ,
- oox::drawingml::Color&
rExtrusionColor,
- const bool bBlockExtrusion)
+bool Scene3DHelper::setExtrusionProperties(
+ const oox::drawingml::Shape3DPropertiesPtr& p3DProperties, const
sal_Int32& rnMSOShapeRotation,
+ oox::PropertyMap& rPropertyMap, double& rRotZ, oox::drawingml::Color&
rExtrusionColor,
+ const bool bBlockExtrusion)
{
// We convert rnMSOShapeRotation, so that Shape::createAndInsert() can use
rRotZ the same way in
// all cases.
diff --git a/sc/source/filter/orcus/autofilter.cxx
b/sc/source/filter/orcus/autofilter.cxx
index 17b54ea21c5f..52eb305cfdde 100644
--- a/sc/source/filter/orcus/autofilter.cxx
+++ b/sc/source/filter/orcus/autofilter.cxx
@@ -176,7 +176,7 @@ void ScOrcusAutoFilterNode::append_item(os::col_t field,
os::auto_filter_op_t op
OUString aStr(value.data(), value.size(),
mrGlobalSettings.getTextEncoding());
aEntry.GetQueryItem().maString = mrDoc.GetSharedStringPool().intern(aStr);
- maEntries.push_back(aEntry);
+ maEntries.push_back(std::move(aEntry));
if (regex)
mbHasRegex = true;
diff --git a/sd/source/console/PresenterTextView.cxx
b/sd/source/console/PresenterTextView.cxx
index 8812e7670f9b..0fccf5380055 100644
--- a/sd/source/console/PresenterTextView.cxx
+++ b/sd/source/console/PresenterTextView.cxx
@@ -124,7 +124,7 @@ void PresenterTextView::SetText (const
Reference<text::XText>& rxText)
pParagraph->SetupCellArray(mpFont);
pParagraph->SetCharacterOffset(nCharacterCount);
nCharacterCount += pParagraph->GetCharacterCount();
- maParagraphs.push_back(pParagraph);
+ maParagraphs.push_back(std::move(pParagraph));
}
if (mpCaret)
diff --git a/sw/source/core/text/itradj.cxx b/sw/source/core/text/itradj.cxx
index 79df28d0c1b1..3a1a956f4059 100644
--- a/sw/source/core/text/itradj.cxx
+++ b/sw/source/core/text/itradj.cxx
@@ -153,10 +153,10 @@ static bool lcl_ComputeKashidaPositions(SwTextSizeInfo&
rInf, SwTextIter& rItr,
tools::Long nMaxKashidaWidth = 0;
// Parse the text, and apply the kashida insertion rules
- std::function<LanguageType(sal_Int32, sal_Int32, bool)> const
pGetLangOfChar(
+ std::function<LanguageType(sal_Int32, sal_Int32, bool)> pGetLangOfChar(
[&rInf](sal_Int32 const nBegin, sal_uInt16 const nScript, bool const
bNoChar)
{ return rInf.GetTextFrame()->GetLangOfChar(TextFrameIndex{ nBegin },
nScript, bNoChar); });
- SwScanner aScanner(pGetLangOfChar, rInf.GetText(), nullptr,
ModelToViewHelper(),
+ SwScanner aScanner(std::move(pGetLangOfChar), rInf.GetText(), nullptr,
ModelToViewHelper(),
i18n::WordType::DICTIONARY_WORD, sal_Int32(nIdx),
sal_Int32(nEnd));
std::vector<bool> aValidPositions;
diff --git a/sw/source/filter/ww8/ww8scan.cxx b/sw/source/filter/ww8/ww8scan.cxx
index a4ee1b641488..31a8e6804b35 100644
--- a/sw/source/filter/ww8/ww8scan.cxx
+++ b/sw/source/filter/ww8/ww8scan.cxx
@@ -6845,7 +6845,7 @@ void WW8SmartTagData::Read(SvStream& rStream, WW8_FC
fcFactoidData, sal_uInt32 l
MSOPropertyBag aPropertyBag;
if (!aPropertyBag.Read(rStream))
break;
- m_aPropBags.push_back(aPropertyBag);
+ m_aPropBags.push_back(std::move(aPropertyBag));
}
rStream.Seek(nOldPosition);
diff --git a/sw/source/filter/ww8/ww8toolbar.cxx
b/sw/source/filter/ww8/ww8toolbar.cxx
index aa8f351fbbb9..c88df2216468 100644
--- a/sw/source/filter/ww8/ww8toolbar.cxx
+++ b/sw/source/filter/ww8/ww8toolbar.cxx
@@ -136,7 +136,7 @@ bool SwCTBWrapper::Read( SvStream& rS )
SwTBC aTBC;
if ( !aTBC.Read( rS ) )
return false;
- m_rtbdc.push_back( aTBC );
+ m_rtbdc.push_back(std::move(aTBC));
bytesToRead = m_cbDTBC - ( rS.Tell() - nStart );
} while ( bytesToRead > 0 );
}
@@ -163,7 +163,7 @@ bool SwCTBWrapper::Read( SvStream& rS )
Customization aCust( this );
if ( !aCust.Read( rS ) )
return false;
- m_rCustomizations.push_back( aCust );
+ m_rCustomizations.push_back(std::move(aCust));
}
}
for ( const auto& rIndex : m_dropDownMenuIndices )
diff --git a/sw/source/ui/dbui/createaddresslistdialog.cxx
b/sw/source/ui/dbui/createaddresslistdialog.cxx
index 2fb50dc90121..9d75508a1ee6 100644
--- a/sw/source/ui/dbui/createaddresslistdialog.cxx
+++ b/sw/source/ui/dbui/createaddresslistdialog.cxx
@@ -303,7 +303,7 @@ SwCreateAddressListDialog::SwCreateAddressListDialog(
m_pCSVData->aDBColumnHeaders.push_back(rAddressHeader[nHeader].first);
std::vector<OUString> aNewData;
aNewData.insert(aNewData.begin(), nCount, OUString());
- m_pCSVData->aDBData.push_back(aNewData);
+ m_pCSVData->aDBData.push_back(std::move(aNewData));
}
//now fill the address control
m_xAddressControl->SetData(*m_pCSVData);
diff --git a/sw/source/writerfilter/dmapper/DomainMapper_Impl.cxx
b/sw/source/writerfilter/dmapper/DomainMapper_Impl.cxx
index 4c7384697659..262d9f41b53c 100644
--- a/sw/source/writerfilter/dmapper/DomainMapper_Impl.cxx
+++ b/sw/source/writerfilter/dmapper/DomainMapper_Impl.cxx
@@ -2954,7 +2954,7 @@ void DomainMapper_Impl::finishParagraph( const
PropertyMapPtr& pPropertyMap, con
AnchoredObjectsInfo aInfo;
aInfo.m_xParagraph = xTextRange;
aInfo.m_aAnchoredObjects =
rAppendContext.m_aAnchoredObjects;
- m_aAnchoredObjectAnchors.push_back(aInfo);
+ m_aAnchoredObjectAnchors.push_back(std::move(aInfo));
rAppendContext.m_aAnchoredObjects.clear();
}
diff --git a/unotools/source/config/fontcfg.cxx
b/unotools/source/config/fontcfg.cxx
index c24e3710aeea..8edb1a54cc24 100644
--- a/unotools/source/config/fontcfg.cxx
+++ b/unotools/source/config/fontcfg.cxx
@@ -1032,7 +1032,7 @@ void FontSubstConfiguration::readLocaleSubst( const
OUString& rBcp47 ) const
aAttr.Type = getSubstType( xFont, aSubstTypeStr );
// finally insert this entry
- it->second.aSubstAttributes.push_back( aAttr );
+ it->second.aSubstAttributes.push_back(std::move(aAttr));
}
std::sort( it->second.aSubstAttributes.begin(),
it->second.aSubstAttributes.end(), StrictStringSort() );
}
diff --git a/xmloff/source/chart/SchXMLChartContext.cxx
b/xmloff/source/chart/SchXMLChartContext.cxx
index b7b9ff090be0..82bf3344cd56 100644
--- a/xmloff/source/chart/SchXMLChartContext.cxx
+++ b/xmloff/source/chart/SchXMLChartContext.cxx
@@ -506,7 +506,7 @@ struct NewDonutSeries
}
if( !aPointStyle.msSeriesStyleNameForDonuts.isEmpty()
|| !aPointStyle.msStyleName.isEmpty() )
- aRet.push_back( aPointStyle );
+ aRet.push_back(std::move(aPointStyle));
++nPointIndex;
}
diff --git a/xmloff/source/chart/SchXMLSeries2Context.cxx
b/xmloff/source/chart/SchXMLSeries2Context.cxx
index 7022fb6db9ce..04c5508c447b 100644
--- a/xmloff/source/chart/SchXMLSeries2Context.cxx
+++ b/xmloff/source/chart/SchXMLSeries2Context.cxx
@@ -637,7 +637,7 @@ void SchXMLSeries2Context::endFastElement(sal_Int32 )
-1, 1,
msAutoStyleName, mnAttachedAxis );
aStyle.mbSymbolSizeForSeriesIsMissingInFile=mbSymbolSizeIsMissingInFile;
- mrStyleVector.push_back( aStyle );
+ mrStyleVector.push_back(std::move(aStyle));
}
// And styles for a data-label child element too. In contrast to
data-labels as child of data points,
// an information about absolute position is useless here. We need
only style information.
diff --git a/xmlscript/source/xmllib_imexp/xmllib_import.cxx
b/xmlscript/source/xmllib_imexp/xmllib_import.cxx
index 9e2c22d20e2a..49494941b573 100644
--- a/xmlscript/source/xmllib_imexp/xmllib_import.cxx
+++ b/xmlscript/source/xmllib_imexp/xmllib_import.cxx
@@ -172,7 +172,7 @@ Reference< xml::input::XElement >
LibrariesElement::startChildElement(
getBoolAttr(&aDesc.bReadOnly, u"readonly"_ustr, xAttributes,
mxImport->XMLNS_LIBRARY_UID );
getBoolAttr(&aDesc.bPasswordProtected, u"passwordprotected"_ustr,
xAttributes, mxImport->XMLNS_LIBRARY_UID );
- mLibDescriptors.push_back( aDesc );
+ mLibDescriptors.push_back(std::move(aDesc));
return new LibraryElement( rLocalName, xAttributes, this,
mxImport.get() );
}
else
diff --git a/xmlsecurity/source/helper/xsecsign.cxx
b/xmlsecurity/source/helper/xsecsign.cxx
index 8c564c456868..caa0cff75491 100644
--- a/xmlsecurity/source/helper/xsecsign.cxx
+++ b/xmlsecurity/source/helper/xsecsign.cxx
@@ -310,7 +310,7 @@ void XSecController::setSignatureLineId(sal_Int32
nSecurityId, const OUString& r
{
InternalSignatureInformation aInformation(nSecurityId, nullptr);
aInformation.signatureInfor.ouSignatureLineId = rSignatureLineId;
- m_vInternalSignatureInformations.push_back(aInformation);
+ m_vInternalSignatureInformations.push_back(std::move(aInformation));
}
else
{
