xmlsecurity/source/dialogs/digitalsignaturesdialog.cxx | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
New commits: commit 1cb5d4338d8467645494b5723b35aba031aea51b Author: Caolán McNamara <[email protected]> AuthorDate: Thu Jul 3 19:58:37 2025 +0100 Commit: Szymon Kłos <[email protected]> CommitDate: Fri Jul 4 07:59:15 2025 +0200 column width missing in signature treeview column list which causes some problems. reproduce on desktop with: SAL_USE_VCLPLUGIN=gen ./instdir/program/soffice xmlsecurity/qa/unit/signing/data/signatureline.odt and the column with heading "Signature type" appears blank unless you select the seperator between it and Description and move it, at which point "XAdES" appears while in lokit there is a out-of-bound crash: #8 0x00007f830d436902 in abort () from target:/lib64/libc.so.6 #9 0x00007f830d6a84e9 in __gnu_debug::_Error_formatter::_M_error() const [clone .cold] () from target:/lib64/libstdc++.so.6 #10 0x00007f830518aa13 in std::__debug::vector<std::unique_ptr<SvLBoxTab, std::default_delete<SvLBoxTab> >, std::allocator<std::unique_ptr<SvLBoxTab, std::default_delete<SvLBoxTab> > > >::operator[] (this=0x4e31dfa8, __n=6) at /usr/include/c++/14/debug/vector:517 #11 0x00007f8305183b4d in SvTreeListBox::GetTab (this=0x4e31dbb0, pEntry=0x4e349e00, pItem=0x4b857ab0) at vcl/source/treelist/treelistbox.cxx:3203 #12 0x00007f830513529c in lcl_DumpEntryAndSiblings (rJsonWriter=..., pEntry=0x4e349e00, pTabListBox=0x4e31dbb0, bCheckButtons=false) at vcl/source/treelist/svtabbx.cxx:102 #13 0x00007f8305135f7b in SvTabListBox::DumpAsPropertyTree (this=0x4e31dbb0, rJsonWriter=...) at vcl/source/treelist/svtabbx.cxx:217 #14 0x00007f830513868b in SvHeaderTabListBox::DumpAsPropertyTree (this=0x4e31dbb0, rJsonWriter=...) at vcl/source/treelist/svtabbx.cxx:647 #15 0x00007f83058951b1 in JSDialogNotifyIdle::generateWidgetUpdate (this=0x4e32b530, pWindow=...) at vcl/jsdialog/jsdialogsender.cxx:111 Change-Id: Ia617d18c9cdf1170f50cbda3082e548777196dcd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187351 Tested-by: Jenkins CollaboraOffice <[email protected]> Reviewed-by: Szymon Kłos <[email protected]> diff --git a/xmlsecurity/source/dialogs/digitalsignaturesdialog.cxx b/xmlsecurity/source/dialogs/digitalsignaturesdialog.cxx index 6fef34748469..e69e5fd95eca 100644 --- a/xmlsecurity/source/dialogs/digitalsignaturesdialog.cxx +++ b/xmlsecurity/source/dialogs/digitalsignaturesdialog.cxx @@ -225,7 +225,8 @@ DigitalSignaturesDialog::DigitalSignaturesDialog( // Give the first column 6 percent, try to distribute the rest equally. std::vector<int> aWidths; aWidths.push_back(6*nControlWidth/100); - auto nColWidth = (nControlWidth - aWidths[0]) / 4; + auto nColWidth = (nControlWidth - aWidths[0]) / 5; + aWidths.push_back(nColWidth); aWidths.push_back(nColWidth); aWidths.push_back(nColWidth); aWidths.push_back(nColWidth);
