include/toolkit/awt/vclxwindow.hxx | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
New commits: commit 5e18a357fb0f8d476d869bf0f0ce26e7ccf3a8dc Author: Michael Weghorn <[email protected]> AuthorDate: Thu Jun 19 19:44:07 2025 +0200 Commit: Michael Weghorn <[email protected]> CommitDate: Thu Jun 19 19:49:14 2025 +0200 toolkit a11y: Fix clang plugin build This fixes the following lolugin build error caused by an a11y change series of mine colliding with commit 8c333826916948c9267d644df01b359870736bf1 Date: Tue Jun 17 12:26:32 2025 +0200 loplugin:unnecessaryvirtual and not caught by CI because my series was based on an older master not containing that commit yet. In file included from /home/michi/development/git/libreoffice/toolkit/source/awt/vclxwindow.cxx:35: /home/michi/development/git/libreoffice/include/toolkit/awt/vclxwindow.hxx:80:21: error: this member function can be declared static [loplugin:staticmethods] 79 | css::uno::Reference< css::accessibility::XAccessibleContext > | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 80 | CreateAccessibleContext(); | ^~~~~~~~~~~~~~~~~~~~~~~~~ /home/michi/development/git/libreoffice/toolkit/source/awt/vclxwindow.cxx:861:65: note: defined here: [loplugin:staticmethods] 861 | uno::Reference< accessibility::XAccessibleContext > VCLXWindow::CreateAccessibleContext() | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ 862 | { | ~ 863 | assert(false && "This code path shouldn't be reached any more."); | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 864 | return {}; | ~~~~~~~~~~ 865 | } | ~ 1 error generated. Change-Id: Ia645d2c81331dc5d8e871b105804722bfe9168eb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186723 Reviewed-by: Michael Weghorn <[email protected]> Tested-by: Michael Weghorn <[email protected]> diff --git a/include/toolkit/awt/vclxwindow.hxx b/include/toolkit/awt/vclxwindow.hxx index ea715c625137..f8a495887866 100644 --- a/include/toolkit/awt/vclxwindow.hxx +++ b/include/toolkit/awt/vclxwindow.hxx @@ -76,8 +76,7 @@ protected: DECL_DLLPRIVATE_LINK(WindowEventListener, VclWindowEvent&, void ); virtual void ProcessWindowEvent( const VclWindowEvent& rVclWindowEvent ); - css::uno::Reference< css::accessibility::XAccessibleContext > - CreateAccessibleContext(); + static css::uno::Reference<css::accessibility::XAccessibleContext> CreateAccessibleContext(); void SetSynthesizingVCLEvent( bool b ); bool IsSynthesizingVCLEvent() const;
