tools/source/fsys/urlobj.cxx |    3 +++
 1 file changed, 3 insertions(+)

New commits:
commit 8b263f3a0bdc87790267ee6f8a59c3fe90f08e29
Author:     Stephan Bergmann <[email protected]>
AuthorDate: Thu Apr 3 10:25:15 2025 +0200
Commit:     Stephan Bergmann <[email protected]>
CommitDate: Thu Apr 3 11:46:56 2025 +0200

    SAL_INFO when vnd.sun.star.expand is considered exotic
    
    As discussed in the appertaining comments at
    
<https://gerrit.libreoffice.org/c/core/+/176645/3#message-1209b271ac4a330311eb90b2d6c16bbff57842ef>,
    836d73a65180d89a077e36457f1f3aa1698c2058 "consider VndSunStarExpand an 
exotic
    protocol" may have been a bit brittle:  "[vnd.sun.star.expand] originated 
from
    the UNO configuration infrastructure, but indeed hard to tell if it then 
found
    reasonable uses outside that area.  I guess the best we can do is get it in,
    maybe mention it in the release notes, and see."  Turns out it is used at 
least
    to handle %origin% in extensions, where that change caused
    <https://bugs.documentfoundation.org/show_bug.cgi?id=165851> "Installing 
custom
    default template via extension stopped working".
    
    So to be better prepared to track down potential further breakage caused by 
that
    change, note cases where it (legitimately or problematically) hits with a
    SAL_INFO.
    
    Change-Id: If742f4f0b0f223e5acf346d294567ccc09eaf49b
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183659
    Tested-by: Jenkins
    Reviewed-by: Stephan Bergmann <[email protected]>

diff --git a/tools/source/fsys/urlobj.cxx b/tools/source/fsys/urlobj.cxx
index 7f6e43cfc322..dd5ef4837b99 100644
--- a/tools/source/fsys/urlobj.cxx
+++ b/tools/source/fsys/urlobj.cxx
@@ -4896,6 +4896,9 @@ bool INetURLObject::IsExoticProtocol() const
         isSchemeEqualTo(u"vnd.sun.star.script") ||
         isSchemeEqualTo(u"service"))
     {
+        SAL_INFO_IF(
+            m_eScheme == INetProtocol::VndSunStarExpand, "tools.urlobj",
+            "<" << m_aAbsURIRef.toString() << "> considered exotic");
         return true;
     }
     if (m_eScheme == INetProtocol::VndSunStarPkg) {

Reply via email to