postprocess/signing/signing.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
New commits: commit a07a6d9705c105956a5320d85fed77e03b89257c Author: Thorsten Behrens <[email protected]> AuthorDate: Tue Mar 25 15:16:01 2025 +0100 Commit: Thorsten Behrens <[email protected]> CommitDate: Thu Mar 27 05:10:49 2025 +0100 windows signing: fail build on signtool failure Previous code relied on brittle stderr parsing to detect signtool failures. Let's keep that heuristic, but additionally evaluate exit code, too. Change-Id: I367b5b4dc67569398e1e26891302274f3fb0b30f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183304 Reviewed-by: Thorsten Behrens <[email protected]> Tested-by: Jenkins diff --git a/postprocess/signing/signing.pl b/postprocess/signing/signing.pl index 793900ca074c..7d18de8ac80e 100644 --- a/postprocess/signing/signing.pl +++ b/postprocess/signing/signing.pl @@ -218,7 +218,7 @@ sub execute #11.07.2007 10:02 print LOG "$result" if ($opt_log); $errorlines .= $result if ($result =~ /SignTool Error\:/); } # while - close PIPE; + close PIPE or print_error("Exit status $? from signtool! "); print_error( "$errorlines " ) if ($errorlines); } ##execute
