sw/source/core/layout/frmtool.cxx | 2 +- sw/source/ui/dbui/mmdocselectpage.cxx | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
New commits: commit 32e3427cd0da18eab825d3015a60d4329b47bd59 Author: Xisco Fauli <[email protected]> AuthorDate: Wed Oct 23 00:48:13 2024 +0200 Commit: Xisco Fauli <[email protected]> CommitDate: Wed Oct 23 09:22:50 2024 +0200 tdf#163486: PVS: Expression is always true V560 A part of conditional expression is always true: pFlt. Change-Id: Ia05e42b8700ceb3dc1ab23becf71fd281695924e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175449 Tested-by: Jenkins Reviewed-by: Xisco Fauli <[email protected]> diff --git a/sw/source/ui/dbui/mmdocselectpage.cxx b/sw/source/ui/dbui/mmdocselectpage.cxx index b07890d4b337..d877eb538b1a 100644 --- a/sw/source/ui/dbui/mmdocselectpage.cxx +++ b/sw/source/ui/dbui/mmdocselectpage.cxx @@ -140,7 +140,7 @@ IMPL_LINK(SwMailMergeDocSelectPage, FileSelectHdl, weld::Button&, rButton, void) std::shared_ptr<const SfxFilter> pFlt = aIter.First(); while( pFlt ) { - if( pFlt && pFlt->IsAllowedAsTemplate() ) + if( pFlt->IsAllowedAsTemplate() ) { const OUString sWild = pFlt->GetWildcard().getGlob(); xFP->appendFilter( pFlt->GetUIName(), sWild ); commit f431b0c5cfa7801efd4e5aa12d0877d01a28403e Author: Xisco Fauli <[email protected]> AuthorDate: Wed Oct 23 00:57:01 2024 +0200 Commit: Xisco Fauli <[email protected]> CommitDate: Wed Oct 23 09:22:35 2024 +0200 tdf#163486: PVS: Expression is always true V560 A part of conditional expression is always true: pSection. Change-Id: If097740c8ea3b89da42c07c4e419fee731948fe7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175453 Tested-by: Jenkins Reviewed-by: Xisco Fauli <[email protected]> diff --git a/sw/source/core/layout/frmtool.cxx b/sw/source/core/layout/frmtool.cxx index 05b968737cc3..3f6afd46e5ef 100644 --- a/sw/source/core/layout/frmtool.cxx +++ b/sw/source/core/layout/frmtool.cxx @@ -1618,7 +1618,7 @@ void InsertCnt_( SwLayoutFrame *pLay, SwDoc *pDoc, { if (SwSectionFrame *const pSection = pLay->FindSctFrame()) { - if (pSection && pSection->ContainsAny() == pFrame) + if (pSection->ContainsAny() == pFrame) { // tdf#146258 section PrtArea depends on paragraph upper margin pSection->InvalidatePrt(); }
