dbaccess/source/ui/dlg/DbAdminImpl.cxx |    4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

New commits:
commit c64ac05bedd442066caee33c8137eebda99d0b8c
Author:     Xisco Fauli <[email protected]>
AuthorDate: Fri Oct 18 16:21:52 2024 +0200
Commit:     Xisco Fauli <[email protected]>
CommitDate: Sun Oct 20 10:32:47 2024 +0200

    tdf#163486: PVS: variable is assigned values twice successively
    
    V519    The 'sNewUrl' variable is assigned values twice successively. 
Perhaps this is a mistake. Check lines: 527, 554.
    
    Change-Id: I35e1b9e78f71958e99586385ba0c86e553e65997
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175140
    Reviewed-by: Xisco Fauli <[email protected]>
    Tested-by: Jenkins

diff --git a/dbaccess/source/ui/dlg/DbAdminImpl.cxx 
b/dbaccess/source/ui/dlg/DbAdminImpl.cxx
index 78a19a9dd813..2a137566c379 100644
--- a/dbaccess/source/ui/dlg/DbAdminImpl.cxx
+++ b/dbaccess/source/ui/dlg/DbAdminImpl.cxx
@@ -524,7 +524,6 @@ OUString 
ODbDataSourceAdministrationHelper::getConnectionURL() const
             break;
         case ::dbaccess::DST_POSTGRES:
             {
-                sNewUrl = pCollection->cutPrefix(pUrlItem->GetValue());
                 OUString 
rURL(comphelper::string::stripEnd(pUrlItem->GetValue(), '*'));
                 const SfxStringItem* pHostName = 
m_pItemSetHelper->getOutputSet()->GetItem<SfxStringItem>(DSID_CONN_HOSTNAME);
                 const SfxInt32Item* pPortNumber = 
m_pItemSetHelper->getOutputSet()->GetItem<SfxInt32Item>(DSID_POSTGRES_PORTNUMBER);
@@ -551,8 +550,7 @@ OUString 
ODbDataSourceAdministrationHelper::getConnectionURL() const
                     dbname = "'" + dbname + "'";
                     rURL += " dbname=" + dbname;
                 }
-                sNewUrl = rURL;
-                return sNewUrl;
+                return rURL;
             }
             break;
         case  ::dbaccess::DST_JDBC:

Reply via email to