chart2/source/model/template/ChartTypeTemplate.cxx | 5 +---- chart2/source/tools/AxisHelper.cxx | 3 +-- 2 files changed, 2 insertions(+), 6 deletions(-)
New commits: commit 5ddac2a6e263a43741e2843068631e0d84561bd1 Author: Xisco Fauli <[email protected]> AuthorDate: Thu Oct 17 14:12:21 2024 +0200 Commit: Xisco Fauli <[email protected]> CommitDate: Thu Oct 17 21:01:03 2024 +0200 tdf#163486: PVS: identical conditional expressions V581: The conditional expressions of the 'if' statements situated alongside each other are identical. Check lines: 422, 426. Change-Id: Ib2bcd4b170b827c325628e0e7eabe6a19ca399ff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175086 Tested-by: Jenkins Reviewed-by: Xisco Fauli <[email protected]> diff --git a/chart2/source/tools/AxisHelper.cxx b/chart2/source/tools/AxisHelper.cxx index bd87f95b195e..72e818e81395 100644 --- a/chart2/source/tools/AxisHelper.cxx +++ b/chart2/source/tools/AxisHelper.cxx @@ -422,9 +422,8 @@ void AxisHelper::showGrid( sal_Int32 nDimensionIndex, sal_Int32 nCooSysIndex, bo if(!xAxis.is()) { //hhhh todo create axis without axis visibility - } - if(!xAxis.is()) return; + } if( bMainGrid ) AxisHelper::makeGridVisible( xAxis->getGridProperties2() ); commit ad09bf747794ee591c62b5ce4e369cfb039c86c5 Author: Xisco Fauli <[email protected]> AuthorDate: Thu Oct 17 14:10:59 2024 +0200 Commit: Xisco Fauli <[email protected]> CommitDate: Thu Oct 17 21:00:51 2024 +0200 tdf#163486: PVS: identical conditional expressions V581: The conditional expressions of the 'if' statements situated alongside each other are identical. Check lines: 507, 520. Change-Id: Ia376cad05bd4327662cd3b7adcbe43e25270da2f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175084 Tested-by: Jenkins Reviewed-by: Xisco Fauli <[email protected]> diff --git a/chart2/source/model/template/ChartTypeTemplate.cxx b/chart2/source/model/template/ChartTypeTemplate.cxx index 063335a3e626..e9ff7c04ca24 100644 --- a/chart2/source/model/template/ChartTypeTemplate.cxx +++ b/chart2/source/model/template/ChartTypeTemplate.cxx @@ -514,11 +514,8 @@ void ChartTypeTemplate::createCoordinateSystems( if( bOk ) return; // there are coordinate systems but they do not fit. So overwrite them. - } - //copy as much info from former coordinate system as possible: - if( !aCoordinateSystems.empty() ) - { + //copy as much info from former coordinate system as possible: rtl::Reference< BaseCoordinateSystem > xOldCooSys( aCoordinateSystems[0] ); sal_Int32 nMaxDimensionCount = std::min( xCooSys->getDimension(), xOldCooSys->getDimension() );
