basegfx/source/polygon/b2dpolygon.cxx | 6 ++---- binaryurp/source/incomingrequest.cxx | 2 +- cui/source/dialogs/SpellDialog.cxx | 2 +- dbaccess/source/ui/relationdesign/RelationTableView.cxx | 2 +- drawinglayer/source/tools/emfphelperdata.cxx | 2 +- fpicker/source/office/iodlg.cxx | 2 +- helpcompiler/source/HelpCompiler.cxx | 4 ++-- i18npool/source/breakiterator/breakiterator_unicode.cxx | 2 +- lingucomponent/source/languageguessing/guesslang.cxx | 2 +- oox/source/drawingml/customshapeproperties.cxx | 4 ++-- oox/source/drawingml/diagram/layoutatomvisitors.cxx | 2 +- oox/source/drawingml/textcharacterpropertiescontext.cxx | 2 +- package/source/xstor/owriteablestream.cxx | 2 +- sc/source/core/opencl/formulagroupcl.cxx | 2 +- sc/source/core/tool/interpr1.cxx | 4 ++-- sc/source/core/tool/interpr5.cxx | 4 ++-- sc/source/filter/xml/xmldrani.cxx | 2 +- sd/source/ui/slideshow/slideshowimpl.cxx | 2 +- sd/source/ui/view/DocumentRenderer.cxx | 2 +- sfx2/source/control/recentdocsviewitem.cxx | 2 +- sfx2/source/doc/oleprops.cxx | 2 +- svx/source/sdr/primitive2d/sdrdecompositiontools.cxx | 2 +- toolkit/source/awt/animatedimagespeer.cxx | 2 +- tools/source/fsys/urlobj.cxx | 2 +- vcl/inc/pdf/ExternalPDFStreams.hxx | 2 +- vcl/source/bitmap/bitmappaint.cxx | 2 +- vcl/source/control/notebookbar.cxx | 2 +- vcl/source/edit/textview.cxx | 2 +- vcl/source/filter/imet/ios2met.cxx | 2 +- vcl/source/filter/svm/SvmConverter.cxx | 2 +- vcl/source/gdi/pdfwriter_impl.cxx | 2 +- vcl/source/gdi/print.cxx | 2 +- vcl/unx/generic/printer/printerinfomanager.cxx | 2 +- vcl/unx/gtk3/gtkframe.cxx | 2 +- 34 files changed, 39 insertions(+), 41 deletions(-)
New commits: commit dd689fb9145bcb43f4be3b62fffb98d37666ffb1 Author: Caolán McNamara <[email protected]> AuthorDate: Sat Aug 17 14:37:04 2024 +0100 Commit: Caolán McNamara <[email protected]> CommitDate: Sun Aug 18 11:04:45 2024 +0200 cid#1557699 COPY_INSTEAD_OF_MOVE and cid#1557435 COPY_INSTEAD_OF_MOVE cid#1557307 COPY_INSTEAD_OF_MOVE cid#1557209 COPY_INSTEAD_OF_MOVE cid#1557192 COPY_INSTEAD_OF_MOVE cid#1557184 COPY_INSTEAD_OF_MOVE cid#1557183 COPY_INSTEAD_OF_MOVE cid#1557171 COPY_INSTEAD_OF_MOVE cid#1557150 COPY_INSTEAD_OF_MOVE cid#1557148 COPY_INSTEAD_OF_MOVE cid#1557123 COPY_INSTEAD_OF_MOVE cid#1557118 COPY_INSTEAD_OF_MOVE cid#1557116 COPY_INSTEAD_OF_MOVE cid#1557103 COPY_INSTEAD_OF_MOVE cid#1557078 COPY_INSTEAD_OF_MOVE cid#1557075 COPY_INSTEAD_OF_MOVE cid#1557071 COPY_INSTEAD_OF_MOVE cid#1557070 COPY_INSTEAD_OF_MOVE cid#1557067 COPY_INSTEAD_OF_MOVE cid#1557049 COPY_INSTEAD_OF_MOVE cid#1557046 COPY_INSTEAD_OF_MOVE cid#1557042 COPY_INSTEAD_OF_MOVE cid#1557036 COPY_INSTEAD_OF_MOVE cid#1557030 COPY_INSTEAD_OF_MOVE cid#1557024 COPY_INSTEAD_OF_MOVE cid#1557012 COPY_INSTEAD_OF_MOVE cid#1557009 COPY_INSTEAD_OF_MOVE cid#1557008 COPY_INSTEAD_OF_MOVE cid#1557004 COPY_INSTEAD_OF_MOVE cid#1556999 COPY_INSTEAD_OF_MOVE cid#1556992 COPY_INSTEAD_OF_MOVE cid#1556987 COPY_INSTEAD_OF_MOVE cid#1556984 COPY_INSTEAD_OF_MOVE cid#1556981 COPY_INSTEAD_OF_MOVE Change-Id: Id2687aa282f4e2d4b8053b73c7aa1a74a9516b16 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171974 Tested-by: Jenkins Reviewed-by: Caolán McNamara <[email protected]> diff --git a/binaryurp/source/incomingrequest.cxx b/binaryurp/source/incomingrequest.cxx index 6f4107693b73..dcb73af21809 100644 --- a/binaryurp/source/incomingrequest.cxx +++ b/binaryurp/source/incomingrequest.cxx @@ -189,7 +189,7 @@ bool IncomingRequest::execute_throw( args.push_back(inArguments_[0].getValue(t)); } else { assert(inArguments_.empty()); - retType = t; + retType = std::move(t); } break; } diff --git a/cui/source/dialogs/SpellDialog.cxx b/cui/source/dialogs/SpellDialog.cxx index 3851a01e596e..59ab182ca2b3 100644 --- a/cui/source/dialogs/SpellDialog.cxx +++ b/cui/source/dialogs/SpellDialog.cxx @@ -469,7 +469,7 @@ void SpellDialog::StartSpellOptDlg_Impl() std::unique_ptr<SfxTabPage> xPage = SvxLinguTabPage::Create(m_xOptionsDlg->get_content_area(), m_xOptionsDlg.get(), xSet.get()); static_cast<SvxLinguTabPage*>(xPage.get())->HideGroups( GROUP_MODULES ); m_xOptionsDlg->SetTabPage(std::move(xPage)); - weld::GenericDialogController::runAsync(m_xOptionsDlg, [this, xSet] (sal_uInt32 nResult) { + weld::GenericDialogController::runAsync(m_xOptionsDlg, [this, xSet=std::move(xSet)] (sal_uInt32 nResult) { if (RET_OK == nResult) { InitUserDicts(); diff --git a/dbaccess/source/ui/relationdesign/RelationTableView.cxx b/dbaccess/source/ui/relationdesign/RelationTableView.cxx index da82719b7a23..c2c07ceb710c 100644 --- a/dbaccess/source/ui/relationdesign/RelationTableView.cxx +++ b/dbaccess/source/ui/relationdesign/RelationTableView.cxx @@ -192,7 +192,7 @@ void ORelationTableView::AddConnection(const OJoinExchangeData& jxdSource, const pTabConnData->SetConnLine( 0, sSourceFieldName, sDestFieldName ); if ( bAskUser || m_pExistingConnection ) - m_pCurrentlyTabConnData = pTabConnData; // this implies that we ask the user what to do + m_pCurrentlyTabConnData = std::move(pTabConnData); // this implies that we ask the user what to do else { try diff --git a/drawinglayer/source/tools/emfphelperdata.cxx b/drawinglayer/source/tools/emfphelperdata.cxx index b9162a7a3ed7..d75219986bfa 100644 --- a/drawinglayer/source/tools/emfphelperdata.cxx +++ b/drawinglayer/source/tools/emfphelperdata.cxx @@ -1724,7 +1724,7 @@ namespace emfplushelper std::move(emptyVector), // EMF-PLUS has no DX-array {}, std::move(fontAttribute), - locale, + std::move(locale), color.getBColor()); } drawinglayer::primitive2d::Primitive2DReference aPrimitiveText(pBaseText); diff --git a/fpicker/source/office/iodlg.cxx b/fpicker/source/office/iodlg.cxx index 0c4376727aac..77038e96d500 100644 --- a/fpicker/source/office/iodlg.cxx +++ b/fpicker/source/office/iodlg.cxx @@ -1600,7 +1600,7 @@ bool SvtFileDialog::PrepareExecute() aFolderURL.removeSegment(); } - INetURLObject aObj = aFolderURL; + INetURLObject aObj = std::move(aFolderURL); if ( aObj.GetProtocol() == INetProtocol::File ) { // set folder as current directory diff --git a/helpcompiler/source/HelpCompiler.cxx b/helpcompiler/source/HelpCompiler.cxx index b9243265033c..57f3f5bca179 100644 --- a/helpcompiler/source/HelpCompiler.cxx +++ b/helpcompiler/source/HelpCompiler.cxx @@ -384,7 +384,7 @@ void myparser::traverse( xmlNodePtr parentNode ) ll.push_back(keyword); } if (!ll.empty()) - (*keywords)[anchor] = ll; + (*keywords)[anchor] = std::move(ll); } else if (branch.compare("contents") == 0) { @@ -410,7 +410,7 @@ void myparser::traverse( xmlNodePtr parentNode ) if (hidstr != "." && !hidstr.empty()) //simple case of explicitly named target { assert(!hidstr.empty()); - (*helptexts)[hidstr] = text; + (*helptexts)[hidstr] = std::move(text); } else //apply to list of "current" hids determined by recent bookmarks that have hid in their branch { diff --git a/i18npool/source/breakiterator/breakiterator_unicode.cxx b/i18npool/source/breakiterator/breakiterator_unicode.cxx index 6406158f558f..5992b6144b0b 100644 --- a/i18npool/source/breakiterator/breakiterator_unicode.cxx +++ b/i18npool/source/breakiterator/breakiterator_unicode.cxx @@ -286,7 +286,7 @@ void BreakIterator_Unicode::loadICUBreakIterator(const css::lang::Locale& rLocal throw uno::RuntimeException("Failed to create ICU BreakIterator: error " + OUString::createFromAscii(u_errorName(status))); } icuBI->mpValue = std::make_shared<BI_ValueData>(); - icuBI->mpValue->mpBreakIterator = pBI; + icuBI->mpValue->mpBreakIterator = std::move(pBI); theBIMap.insert( std::make_pair( aBIMapLocaleTypeKey, icuBI->mpValue)); } while (false); if (!icuBI->mpValue || !icuBI->mpValue->mpBreakIterator) { diff --git a/lingucomponent/source/languageguessing/guesslang.cxx b/lingucomponent/source/languageguessing/guesslang.cxx index db179c9bfdc9..d87542b889fb 100644 --- a/lingucomponent/source/languageguessing/guesslang.cxx +++ b/lingucomponent/source/languageguessing/guesslang.cxx @@ -202,7 +202,7 @@ uno::Sequence< Locale > SAL_CALL LangGuess_Impl::getAvailableLanguages( ) css::lang::Locale current_aRes; current_aRes.Language = OUString::createFromAscii( gs[i].GetLanguage() ); current_aRes.Country = OUString::createFromAscii( gs[i].GetCountry() ); - pRes[i] = current_aRes; + pRes[i] = std::move(current_aRes); } return aRes; diff --git a/oox/source/drawingml/customshapeproperties.cxx b/oox/source/drawingml/customshapeproperties.cxx index ff71d59912aa..447f5262b13f 100644 --- a/oox/source/drawingml/customshapeproperties.cxx +++ b/oox/source/drawingml/customshapeproperties.cxx @@ -196,7 +196,7 @@ void CustomShapeProperties::pushToPropSet( aAdjustmentVal.Value <<= adjustmentGuide.maFormula.toInt32(); aAdjustmentVal.State = PropertyState_DIRECT_VALUE; aAdjustmentVal.Name = adjustmentGuide.maName; - aAdjustmentSeqRange[ nAdjustmentIndex ] = aAdjustmentVal; + aAdjustmentSeqRange[ nAdjustmentIndex ] = std::move(aAdjustmentVal); } } else if ( aAdjustmentSeq.hasElements() ) { EnhancedCustomShapeAdjustmentValue aAdjustmentVal; @@ -205,7 +205,7 @@ void CustomShapeProperties::pushToPropSet( aAdjustmentVal.Name = adjustmentGuide.maName; if (nIndex < aAdjustmentSeq.getLength()) { - aAdjustmentSeqRange[nIndex] = aAdjustmentVal; + aAdjustmentSeqRange[nIndex] = std::move(aAdjustmentVal); ++nIndex; } } diff --git a/oox/source/drawingml/diagram/layoutatomvisitors.cxx b/oox/source/drawingml/diagram/layoutatomvisitors.cxx index 96cbd738ea66..482894ee159e 100644 --- a/oox/source/drawingml/diagram/layoutatomvisitors.cxx +++ b/oox/source/drawingml/diagram/layoutatomvisitors.cxx @@ -83,7 +83,7 @@ void ShapeCreationVisitor::visit(LayoutNode& rAtom) { pShape->setInternalName(rAtom.getName()); rAtom.addNodeShape(pShape); - mrDgm.getLayout()->getPresPointShapeMap()[pNewNode] = pShape; + mrDgm.getLayout()->getPresPointShapeMap()[pNewNode] = std::move(pShape); } } else diff --git a/oox/source/drawingml/textcharacterpropertiescontext.cxx b/oox/source/drawingml/textcharacterpropertiescontext.cxx index 923e14f2e794..9bee9c88106a 100644 --- a/oox/source/drawingml/textcharacterpropertiescontext.cxx +++ b/oox/source/drawingml/textcharacterpropertiescontext.cxx @@ -236,7 +236,7 @@ ContextHandlerRef TextCharacterPropertiesContext::onCreateContext( sal_Int32 aEl { oox::drawingml::Color theColor; theColor.setSrgbClr(colorAttrib.value()); - mrTextCharacterProperties.maUnderlineColor = theColor; + mrTextCharacterProperties.maUnderlineColor = std::move(theColor); } break; } diff --git a/package/source/xstor/owriteablestream.cxx b/package/source/xstor/owriteablestream.cxx index 437750525ae7..16e04ac6ce76 100644 --- a/package/source/xstor/owriteablestream.cxx +++ b/package/source/xstor/owriteablestream.cxx @@ -896,7 +896,7 @@ uno::Sequence< beans::PropertyValue > OWriteStream_Impl::InsertOwnProps( break; if (i == aResult.getLength()) aResult.realloc(i + 1); - aResult.getArray()[i] = aPropVal; + aResult.getArray()[i] = std::move(aPropVal); } return aResult; diff --git a/sc/source/core/opencl/formulagroupcl.cxx b/sc/source/core/opencl/formulagroupcl.cxx index 81a796886110..1a88b55c961c 100644 --- a/sc/source/core/opencl/formulagroupcl.cxx +++ b/sc/source/core/opencl/formulagroupcl.cxx @@ -2684,7 +2684,7 @@ void DynamicKernel::CreateKernel() } lastSecondKernelHash = lastOneKernelHash; lastSecondProgram = lastOneProgram; - lastOneKernelHash = KernelHash; + lastOneKernelHash = std::move(KernelHash); lastOneProgram = mpProgram; } mpKernel = clCreateKernel(mpProgram, kname.c_str(), &err); diff --git a/sc/source/core/tool/interpr1.cxx b/sc/source/core/tool/interpr1.cxx index ad5685c84b89..5bc3166dca59 100644 --- a/sc/source/core/tool/interpr1.cxx +++ b/sc/source/core/tool/interpr1.cxx @@ -7217,14 +7217,14 @@ void ScInterpreter::ScLookup() { ScMatrixRef pTempMat = GetNewMat( 1, nElems, /*bEmpty*/true ); pTempMat->PutDoubleVector( vArray, 0, 0); - pDataMat2 = pTempMat; + pDataMat2 = std::move(pTempMat); } else { ScMatrixRef pTempMat = GetNewMat( nElems, 1, /*bEmpty*/true ); for (size_t i=0; i < nElems; ++i) pTempMat->PutDouble( vArray[i], i, 0); - pDataMat2 = pTempMat; + pDataMat2 = std::move(pTempMat); } } } diff --git a/sc/source/core/tool/interpr5.cxx b/sc/source/core/tool/interpr5.cxx index af04d06897db..f282d5fe7169 100644 --- a/sc/source/core/tool/interpr5.cxx +++ b/sc/source/core/tool/interpr5.cxx @@ -1355,11 +1355,11 @@ void ScInterpreter::CalculateAddSub(bool _bSub) { double fVal; bool bFlag; - ScMatrixRef pMat = pMat1; + ScMatrixRef pMat = std::move(pMat1); if (!pMat) { fVal = fVal1; - pMat = pMat2; + pMat = std::move(pMat2); bFlag = true; // double - Matrix } else diff --git a/sc/source/filter/xml/xmldrani.cxx b/sc/source/filter/xml/xmldrani.cxx index 5708c74d2fa3..cf6cd7d3e651 100644 --- a/sc/source/filter/xml/xmldrani.cxx +++ b/sc/source/filter/xml/xmldrani.cxx @@ -303,7 +303,7 @@ std::unique_ptr<ScDBData> ScXMLDatabaseRangeContext::ConvertToDBData(const OUStr table::TableOrientation eOrient = mpQueryParam->bByRow ? table::TableOrientation_ROWS : table::TableOrientation_COLUMNS; aProperty.Value <<= eOrient; - aSortSequence.getArray()[nOldSize] = aProperty; + aSortSequence.getArray()[nOldSize] = std::move(aProperty); ScSortParam aParam; ScSortDescriptor::FillSortParam(aParam, aSortSequence); diff --git a/sd/source/ui/slideshow/slideshowimpl.cxx b/sd/source/ui/slideshow/slideshowimpl.cxx index 94ca9b708dc7..c8ae78fa7380 100644 --- a/sd/source/ui/slideshow/slideshowimpl.cxx +++ b/sd/source/ui/slideshow/slideshowimpl.cxx @@ -1564,7 +1564,7 @@ void SlideshowImpl::registerShapeEvents( Reference< XShapes > const & xShapes ) continue; // skip all others } - maShapeEventMap[ xShape ] = pEvent; + maShapeEventMap[ xShape ] = std::move(pEvent); if( mxListenerProxy.is() ) mxListenerProxy->addShapeEventListener( xShape ); diff --git a/sd/source/ui/view/DocumentRenderer.cxx b/sd/source/ui/view/DocumentRenderer.cxx index 3b8c62994b76..502df8396306 100644 --- a/sd/source/ui/view/DocumentRenderer.cxx +++ b/sd/source/ui/view/DocumentRenderer.cxx @@ -1950,7 +1950,7 @@ private: } else { - rInfo.maMap = aMap; + rInfo.maMap = std::move(aMap); PrepareScaledPage(*it, *pPage, ePageKind, rInfo); } } diff --git a/sfx2/source/control/recentdocsviewitem.cxx b/sfx2/source/control/recentdocsviewitem.cxx index b1fcdccb69dd..d5ae52e297d8 100644 --- a/sfx2/source/control/recentdocsviewitem.cxx +++ b/sfx2/source/control/recentdocsviewitem.cxx @@ -386,7 +386,7 @@ void RecentDocsViewItem::OpenDocument() // after select!!! sfx2::LoadRecentFile *const pLoadRecentFile = new sfx2::LoadRecentFile; pLoadRecentFile->xDispatch = xDispatch; - pLoadRecentFile->aTargetURL = aTargetURL; + pLoadRecentFile->aTargetURL = std::move(aTargetURL); pLoadRecentFile->aArgSeq = aArgsList; pLoadRecentFile->pView = &mrParentView; diff --git a/sfx2/source/doc/oleprops.cxx b/sfx2/source/doc/oleprops.cxx index 714f58c2f1af..8ba709111fce 100644 --- a/sfx2/source/doc/oleprops.cxx +++ b/sfx2/source/doc/oleprops.cxx @@ -1065,7 +1065,7 @@ void SfxOleSection::LoadProperty( SvStream& rStrm, sal_Int32 nPropId ) if( xProp ) { SetError( xProp->Load( rStrm ) ); - maPropMap[ nPropId ] = xProp; + maPropMap[ nPropId ] = std::move(xProp); } } diff --git a/svx/source/sdr/primitive2d/sdrdecompositiontools.cxx b/svx/source/sdr/primitive2d/sdrdecompositiontools.cxx index c04aef0a9604..b6d97a9fa39b 100644 --- a/svx/source/sdr/primitive2d/sdrdecompositiontools.cxx +++ b/svx/source/sdr/primitive2d/sdrdecompositiontools.cxx @@ -335,7 +335,7 @@ void SlideBackgroundFillPrimitive2D::get2DDecomposition( if(!getBuffered2DDecomposition()) { // remember last Fill - const_cast< SlideBackgroundFillPrimitive2D* >(this)->maLastFill = aFill; + const_cast< SlideBackgroundFillPrimitive2D* >(this)->maLastFill = std::move(aFill); } // use parent implementation diff --git a/toolkit/source/awt/animatedimagespeer.cxx b/toolkit/source/awt/animatedimagespeer.cxx index 3c5e5ee9c4bf..166d5bc679ee 100644 --- a/toolkit/source/awt/animatedimagespeer.cxx +++ b/toolkit/source/awt/animatedimagespeer.cxx @@ -338,7 +338,7 @@ namespace toolkit OSL_VERIFY( i_event.Element >>= aImageURLs ); ::std::vector< CachedImage > aImages; lcl_init( aImageURLs, aImages ); - maCachedImageSets[ position ] = aImages; + maCachedImageSets[ position ] = std::move(aImages); updateImageList_nothrow(); } diff --git a/tools/source/fsys/urlobj.cxx b/tools/source/fsys/urlobj.cxx index 2c23d67678ad..3a5c434ba303 100644 --- a/tools/source/fsys/urlobj.cxx +++ b/tools/source/fsys/urlobj.cxx @@ -1050,7 +1050,7 @@ bool INetURLObject::setAbsURIRef(std::u16string_view rTheAbsURIRef, OUStringBuffer aSynAuthority(64); if ( !bHasUser ) { - aSynAuthority = aSynUser; + aSynAuthority = std::move(aSynUser); } else { diff --git a/vcl/inc/pdf/ExternalPDFStreams.hxx b/vcl/inc/pdf/ExternalPDFStreams.hxx index b2936f01a898..67d12b556a5d 100644 --- a/vcl/inc/pdf/ExternalPDFStreams.hxx +++ b/vcl/inc/pdf/ExternalPDFStreams.hxx @@ -47,7 +47,7 @@ struct VCL_DLLPUBLIC ExternalPDFStream } else { - mpPDFDocument = pPDFDocument; + mpPDFDocument = std::move(pPDFDocument); } } return mpPDFDocument; diff --git a/vcl/source/bitmap/bitmappaint.cxx b/vcl/source/bitmap/bitmappaint.cxx index 7ad31ed0ed1f..ccfd14b3f760 100644 --- a/vcl/source/bitmap/bitmappaint.cxx +++ b/vcl/source/bitmap/bitmappaint.cxx @@ -369,7 +369,7 @@ bool Bitmap::Rotate(Degree10 nAngle10, const Color& rFillColor) pWriteAcc.reset(); } - aRotatedBmp = aNewBmp; + aRotatedBmp = std::move(aNewBmp); } else { diff --git a/vcl/source/control/notebookbar.cxx b/vcl/source/control/notebookbar.cxx index 4b6da5c4b573..bbba5ebde7b9 100644 --- a/vcl/source/control/notebookbar.cxx +++ b/vcl/source/control/notebookbar.cxx @@ -350,7 +350,7 @@ void NotebookBar::UpdateDefaultSettings() aStyleSet.SetToolTextColor(aTextColor); aAllSettings.SetStyleSettings(aStyleSet); - DefaultSettings = aAllSettings; + DefaultSettings = std::move(aAllSettings); } void NotebookBar::UpdatePersonaSettings() diff --git a/vcl/source/edit/textview.cxx b/vcl/source/edit/textview.cxx index 783bdd3de5da..3a4be751c234 100644 --- a/vcl/source/edit/textview.cxx +++ b/vcl/source/edit/textview.cxx @@ -270,7 +270,7 @@ void TextView::ImpPaint(vcl::RenderContext& rRenderContext, const Point& rStartP if (aFont.IsTransparent()) aColor = COL_TRANSPARENT; aFont.SetFillColor(aColor); - mpImpl->mpTextEngine->maFont = aFont; + mpImpl->mpTextEngine->maFont = std::move(aFont); } } diff --git a/vcl/source/filter/imet/ios2met.cxx b/vcl/source/filter/imet/ios2met.cxx index 1d1bcfa1c8d6..6e43c50f5986 100644 --- a/vcl/source/filter/imet/ios2met.cxx +++ b/vcl/source/filter/imet/ios2met.cxx @@ -1336,7 +1336,7 @@ void OS2METReader::ReadBezier(bool bGivenPos, sal_uInt16 nOrderLen) if( nNumPoints != aBezPoly.GetSize() ) aBezPoly.SetSize( nNumPoints ); - aPolygon = aBezPoly; + aPolygon = std::move(aBezPoly); } aAttr.aCurPos = aPolygon[ nNumPoints - 1 ]; diff --git a/vcl/source/filter/svm/SvmConverter.cxx b/vcl/source/filter/svm/SvmConverter.cxx index d14adcc30640..2b5a65b189ce 100644 --- a/vcl/source/filter/svm/SvmConverter.cxx +++ b/vcl/source/filter/svm/SvmConverter.cxx @@ -474,7 +474,7 @@ void SVMConverter::ImplConvertFromSVM1( SvStream& rIStm, GDIMetaFile& rMtf ) { rMtf.ReplaceAction( new MetaPolyPolygonAction( - aInputPolyPolygon), + std::move(aInputPolyPolygon)), nLastPolygonAction); } } diff --git a/vcl/source/gdi/pdfwriter_impl.cxx b/vcl/source/gdi/pdfwriter_impl.cxx index 54deb6230dd1..d46cbf0da80e 100644 --- a/vcl/source/gdi/pdfwriter_impl.cxx +++ b/vcl/source/gdi/pdfwriter_impl.cxx @@ -10456,7 +10456,7 @@ void PDFWriterImpl::setClipRegion( const basegfx::B2DPolyPolygon& rRegion ) basegfx::B2DPolyPolygon aRegion(rRegion); aRegion.transform(aCurrentTransform); - m_aGraphicsStack.front().m_aClipRegion = aRegion; + m_aGraphicsStack.front().m_aClipRegion = std::move(aRegion); m_aGraphicsStack.front().m_bClipRegion = true; m_aGraphicsStack.front().m_nUpdateFlags |= GraphicsStateUpdateFlags::ClipRegion; } diff --git a/vcl/source/gdi/print.cxx b/vcl/source/gdi/print.cxx index 308d7408c3c7..399f0286b6ca 100644 --- a/vcl/source/gdi/print.cxx +++ b/vcl/source/gdi/print.cxx @@ -1131,7 +1131,7 @@ bool Printer::SetOrientation( Orientation eOrientation ) { ImplUpdateJobSetupPaper( aJobSetup ); mbNewJobSetup = true; - maJobSetup = aJobSetup; + maJobSetup = std::move(aJobSetup); ImplUpdatePageData(); ImplUpdateFontList(); return true; diff --git a/vcl/unx/generic/printer/printerinfomanager.cxx b/vcl/unx/generic/printer/printerinfomanager.cxx index 610bbd2ab0bf..6091bc2e3639 100644 --- a/vcl/unx/generic/printer/printerinfomanager.cxx +++ b/vcl/unx/generic/printer/printerinfomanager.cxx @@ -858,7 +858,7 @@ void SystemQueueInfo::run() rParm.pHandler( aLines, aSysPrintQueues, &rParm ); std::unique_lock aGuard( m_aMutex ); m_bChanged = true; - m_aQueues = aSysPrintQueues; + m_aQueues = std::move(aSysPrintQueues); m_aCommand = OUString::createFromAscii( rParm.pPrintCommand ); #if OSL_DEBUG_LEVEL > 1 SAL_INFO("vcl.unx.print", "printing queue command: success."); diff --git a/vcl/unx/gtk3/gtkframe.cxx b/vcl/unx/gtk3/gtkframe.cxx index a180f467ae3a..7f812e1dd894 100644 --- a/vcl/unx/gtk3/gtkframe.cxx +++ b/vcl/unx/gtk3/gtkframe.cxx @@ -6028,7 +6028,7 @@ void GtkSalFrame::IMHandler::signalIMPreeditChanged( GtkIMContext* pIMContext, g pThis->m_aInputEvent.maText = sText; pThis->m_aInputEvent.mnCursorPos = nCursorPos; pThis->m_aInputEvent.mnCursorFlags = nCursorFlags; - pThis->m_aInputFlags = aInputFlags; + pThis->m_aInputFlags = std::move(aInputFlags); pThis->m_aInputEvent.mpTextAttr = pThis->m_aInputFlags.data(); SolarMutexGuard aGuard; commit c6a71f5daf8c8d1efa8b2273137c92a8ac2650b1 Author: Caolán McNamara <[email protected]> AuthorDate: Sat Aug 17 19:29:05 2024 +0100 Commit: Caolán McNamara <[email protected]> CommitDate: Sun Aug 18 11:04:35 2024 +0200 Related: ofz#70815 Timeout, don't need this copy Change-Id: I8d870a6e6743b98da3d0a173cff12748d513d8d9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171982 Tested-by: Jenkins Reviewed-by: Caolán McNamara <[email protected]> diff --git a/basegfx/source/polygon/b2dpolygon.cxx b/basegfx/source/polygon/b2dpolygon.cxx index 90634a377a72..b54570df36ac 100644 --- a/basegfx/source/polygon/b2dpolygon.cxx +++ b/basegfx/source/polygon/b2dpolygon.cxx @@ -683,8 +683,7 @@ public: void append(const basegfx::B2DPoint& rPoint) { mpBufferedData.reset(); // TODO: is this needed? - const auto aCoordinate = rPoint; - maPoints.append(aCoordinate); + maPoints.append(rPoint); if(moControlVector) { @@ -697,8 +696,7 @@ public: { assert(nCount > 0); mpBufferedData.reset(); - auto aCoordinate = rPoint; - maPoints.insert(nIndex, aCoordinate, nCount); + maPoints.insert(nIndex, rPoint, nCount); if(moControlVector) {
