basctl/source/basicide/baside3.cxx | 2 +- basegfx/source/polygon/b2dpolypolygoncutter.cxx | 2 +- basegfx/source/tools/bgradient.cxx | 2 +- basic/source/uno/namecont.cxx | 2 +- chart2/source/controller/chartapiwrapper/WrappedScaleProperty.cxx | 2 +- chart2/source/tools/InternalData.cxx | 6 ++---- chart2/source/view/charttypes/AreaChart.cxx | 2 +- connectivity/source/commontools/TDatabaseMetaDataBase.cxx | 2 +- cppuhelper/source/servicemanager.cxx | 2 +- drawinglayer/source/processor2d/vclmetafileprocessor2d.cxx | 2 +- drawinglayer/source/tools/converters.cxx | 2 +- editeng/source/misc/svxacorr.cxx | 2 +- filter/source/config/cache/filtercache.cxx | 2 +- fpicker/source/office/iodlg.cxx | 2 +- framework/source/services/pathsettings.cxx | 2 +- framework/source/uiconfiguration/ImageList.cxx | 2 +- helpcompiler/inc/HelpLinker.hxx | 3 ++- helpcompiler/source/HelpCompiler.cxx | 2 +- helpcompiler/source/HelpLinker.cxx | 7 +++---- idl/source/prj/parser.cxx | 2 +- libreofficekit/qa/gtktiledviewer/gtv-signal-handlers.cxx | 8 ++++---- lingucomponent/source/languageguessing/guesslang.cxx | 4 ++-- oox/source/export/drawingml.cxx | 2 +- reportdesign/source/filter/xml/xmlExport.cxx | 2 +- sc/source/core/data/column2.cxx | 2 +- sc/source/core/data/formulacell.cxx | 2 +- sc/source/filter/excel/xichart.cxx | 2 +- sc/source/ui/drawfunc/fuins2.cxx | 2 +- sc/source/ui/unoobj/docuno.cxx | 2 +- sd/source/console/PresenterTheme.cxx | 4 ++-- sd/source/filter/ppt/ppt97animations.cxx | 2 +- sd/source/ui/func/fuconrec.cxx | 2 +- sd/source/ui/func/fumorph.cxx | 2 +- sd/source/ui/table/TableDesignPane.cxx | 2 +- sd/source/ui/view/ViewShellManager.cxx | 2 +- slideshow/source/engine/slideview.cxx | 3 +-- sw/source/core/doc/DocumentDeviceManager.cxx | 2 +- sw/source/core/unocore/unocontentcontrol.cxx | 2 +- sw/source/filter/ww8/wrtw8nds.cxx | 2 +- sw/source/filter/ww8/ww8par5.cxx | 2 +- sw/source/uibase/shells/textsh1.cxx | 2 +- sw/source/uibase/uiview/viewling.cxx | 2 +- tools/source/fsys/urlobj.cxx | 2 +- ucb/source/ucp/package/pkgcontent.cxx | 2 +- vcl/source/bitmap/BitmapSimpleColorQuantizationFilter.cxx | 2 +- vcl/source/filter/idxf/dxf2mtf.cxx | 2 +- vcl/source/filter/ieps/ieps.cxx | 2 +- vcl/source/outdev/outdev.cxx | 2 +- vcl/unx/generic/printer/printerinfomanager.cxx | 2 +- xmloff/source/text/txtparae.cxx | 2 +- 50 files changed, 59 insertions(+), 62 deletions(-)
New commits: commit ec63dfe3f47fc6ce0f53312fdb47617a5355fd78 Author: Caolán McNamara <[email protected]> AuthorDate: Sun Aug 11 17:12:18 2024 +0100 Commit: Caolán McNamara <[email protected]> CommitDate: Sun Aug 11 20:15:02 2024 +0200 cid#1607249 silence bogus Overflowed integer argument Change-Id: Ib31c6f49a36f4f78bebb0abc164361c7a6e14190 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171733 Reviewed-by: Caolán McNamara <[email protected]> Tested-by: Jenkins diff --git a/oox/source/export/drawingml.cxx b/oox/source/export/drawingml.cxx index 42bda5729098..227d1aa43dcf 100644 --- a/oox/source/export/drawingml.cxx +++ b/oox/source/export/drawingml.cxx @@ -5356,7 +5356,7 @@ void DrawingML::WritePolyPolygon(const css::uno::Reference<css::drawing::XShape> && aPoly.GetFlags(j + 2) != PolyFlags::Control) { mpFS->startElementNS(XML_a, XML_cubicBezTo); - for (sal_uInt8 k = 0; k <= 2; ++k) + for (sal_uInt32 k = 0; k <= 2; ++k) { mpFS->singleElementNS(XML_a, XML_pt, XML_x, OString::number(aPoly[j + k].X() - aPos.X), XML_y, commit d7056b145691dab9a0220daeecf0625644e176a9 Author: Caolán McNamara <[email protected]> AuthorDate: Sun Aug 11 16:13:05 2024 +0100 Commit: Caolán McNamara <[email protected]> CommitDate: Sun Aug 11 20:14:54 2024 +0200 cid#1558088 COPY_INSTEAD_OF_MOVE and cid#1558080 COPY_INSTEAD_OF_MOVE cid#1558077 COPY_INSTEAD_OF_MOVE cid#1558055 COPY_INSTEAD_OF_MOVE cid#1558043 COPY_INSTEAD_OF_MOVE cid#1558039 COPY_INSTEAD_OF_MOVE cid#1558015 COPY_INSTEAD_OF_MOVE cid#1558014 COPY_INSTEAD_OF_MOVE cid#1558009 COPY_INSTEAD_OF_MOVE cid#1558002 COPY_INSTEAD_OF_MOVE cid#1557998 COPY_INSTEAD_OF_MOVE cid#1557996 COPY_INSTEAD_OF_MOVE cid#1557990 COPY_INSTEAD_OF_MOVE cid#1557986 COPY_INSTEAD_OF_MOVE cid#1557980 COPY_INSTEAD_OF_MOVE cid#1557971 COPY_INSTEAD_OF_MOVE cid#1557968 COPY_INSTEAD_OF_MOVE cid#1557967 COPY_INSTEAD_OF_MOVE cid#1557961 COPY_INSTEAD_OF_MOVE cid#1557959 COPY_INSTEAD_OF_MOVE cid#1557958 COPY_INSTEAD_OF_MOVE cid#1557956 COPY_INSTEAD_OF_MOVE cid#1557953 COPY_INSTEAD_OF_MOVE cid#1557949 COPY_INSTEAD_OF_MOVE cid#1557947 COPY_INSTEAD_OF_MOVE cid#1557940 COPY_INSTEAD_OF_MOVE cid#1557931 COPY_INSTEAD_OF_MOVE cid#1557930 COPY_INSTEAD_OF_MOVE cid#1557915 COPY_INSTEAD_OF_MOVE cid#1557913 COPY_INSTEAD_OF_MOVE cid#1557910 COPY_INSTEAD_OF_MOVE cid#1557886 COPY_INSTEAD_OF_MOVE cid#1557884 COPY_INSTEAD_OF_MOVE cid#1557880 COPY_INSTEAD_OF_MOVE cid#1557875 COPY_INSTEAD_OF_MOVE cid#1557871 COPY_INSTEAD_OF_MOVE cid#1557862 COPY_INSTEAD_OF_MOVE cid#1557847 COPY_INSTEAD_OF_MOVE cid#1557845 COPY_INSTEAD_OF_MOVE cid#1557844 COPY_INSTEAD_OF_MOVE cid#1557843 COPY_INSTEAD_OF_MOVE cid#1557838 COPY_INSTEAD_OF_MOVE cid#1557835 COPY_INSTEAD_OF_MOVE cid#1557834 COPY_INSTEAD_OF_MOVE cid#1557828 COPY_INSTEAD_OF_MOVE cid#1557823 COPY_INSTEAD_OF_MOVE cid#1557817 COPY_INSTEAD_OF_MOVE cid#1557813 COPY_INSTEAD_OF_MOVE cid#1557812 COPY_INSTEAD_OF_MOVE Change-Id: I55d4a920daa2d148683419169eb828325fd3c757 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171732 Tested-by: Jenkins Reviewed-by: Caolán McNamara <[email protected]> diff --git a/basctl/source/basicide/baside3.cxx b/basctl/source/basicide/baside3.cxx index f88bc9d44d5d..2d41616751ae 100644 --- a/basctl/source/basicide/baside3.cxx +++ b/basctl/source/basicide/baside3.cxx @@ -1084,7 +1084,7 @@ EntryDescriptor DialogWindow::CreateEntryDescriptor() ScriptDocument aDocument( GetDocument() ); OUString aLibName( GetLibName() ); LibraryLocation eLocation = aDocument.getLibraryLocation( aLibName ); - return EntryDescriptor( aDocument, eLocation, aLibName, OUString(), GetName(), OBJ_TYPE_DIALOG ); + return EntryDescriptor( std::move(aDocument), eLocation, aLibName, OUString(), GetName(), OBJ_TYPE_DIALOG ); } void DialogWindow::SetReadOnly (bool bReadOnly) diff --git a/basegfx/source/polygon/b2dpolypolygoncutter.cxx b/basegfx/source/polygon/b2dpolypolygoncutter.cxx index bec0c20fa7e4..38fd90778512 100644 --- a/basegfx/source/polygon/b2dpolypolygoncutter.cxx +++ b/basegfx/source/polygon/b2dpolypolygoncutter.cxx @@ -1081,7 +1081,7 @@ namespace basegfx::utils if(!aCandidateRange.overlaps(aTargetRange)) { aTarget.append(aCandidate); - b = aTarget; + b = std::move(aTarget); bCouldMergeSimple = true; break; } diff --git a/basegfx/source/tools/bgradient.cxx b/basegfx/source/tools/bgradient.cxx index d80f52974a35..225bebfe0f6b 100644 --- a/basegfx/source/tools/bgradient.cxx +++ b/basegfx/source/tools/bgradient.cxx @@ -529,7 +529,7 @@ void BColorStops::createSpaceAtStart(double fOffset) candidate.getStopColor()); } - *this = aNewStops; + *this = std::move(aNewStops); } // removeSpaceAtStart removes fOffset space from start by diff --git a/basic/source/uno/namecont.cxx b/basic/source/uno/namecont.cxx index 0edefa1676aa..90014a790dc5 100644 --- a/basic/source/uno/namecont.cxx +++ b/basic/source/uno/namecont.cxx @@ -623,7 +623,7 @@ void SfxLibraryContainer::init_Impl( const OUString& rInitialDocumentURL, if( aExtension == "xlc" ) { meInitMode = CONTAINER_INIT_FILE; - INetURLObject aLibPathInetObj( aInitUrlInetObj ); + INetURLObject aLibPathInetObj( std::move(aInitUrlInetObj) ); aLibPathInetObj.removeSegment(); maLibraryPath = aLibPathInetObj.GetMainURL( INetURLObject::DecodeMechanism::NONE ); } diff --git a/chart2/source/controller/chartapiwrapper/WrappedScaleProperty.cxx b/chart2/source/controller/chartapiwrapper/WrappedScaleProperty.cxx index 0edbf16bc9fb..35b8cd3040ea 100644 --- a/chart2/source/controller/chartapiwrapper/WrappedScaleProperty.cxx +++ b/chart2/source/controller/chartapiwrapper/WrappedScaleProperty.cxx @@ -297,7 +297,7 @@ void WrappedScaleProperty::setPropertyValue( tScaleProperty eScaleProperty, cons { TimeIncrement aTimeIncrement; rOuterValue >>= aTimeIncrement; - aScaleData.TimeIncrement = aTimeIncrement; + aScaleData.TimeIncrement = std::move(aTimeIncrement); bSetScaleData = true; break; } diff --git a/chart2/source/tools/InternalData.cxx b/chart2/source/tools/InternalData.cxx index b4638719f48b..c0cddac8bb82 100644 --- a/chart2/source/tools/InternalData.cxx +++ b/chart2/source/tools/InternalData.cxx @@ -297,8 +297,7 @@ bool InternalData::enlargeData( sal_Int32 nColumnCount, sal_Int32 nRowCount ) aNewData[ std::slice( nCol, m_nRowCount, nNewColumnCount ) ] ) = m_aData[ std::slice( nCol, m_nRowCount, m_nColumnCount ) ]; - m_aData.resize( nNewSize ); - m_aData = aNewData; + m_aData = std::move(aNewData); } m_nColumnCount = nNewColumnCount; m_nRowCount = nNewRowCount; @@ -451,8 +450,7 @@ void InternalData::deleteRow( sal_Int32 nAtIndex ) } m_nRowCount = nNewRowCount; - m_aData.resize( nNewSize ); - m_aData = aNewData; + m_aData = std::move(aNewData); // labels if( nAtIndex < static_cast< sal_Int32 >( m_aRowLabels.size())) diff --git a/chart2/source/view/charttypes/AreaChart.cxx b/chart2/source/view/charttypes/AreaChart.cxx index 13aaa7d16f3f..f5a73b966c4a 100644 --- a/chart2/source/view/charttypes/AreaChart.cxx +++ b/chart2/source/view/charttypes/AreaChart.cxx @@ -445,7 +445,7 @@ bool AreaChart::impl_createArea( VDataSeries* pSeries std::vector<std::vector<css::drawing::Position3D>> aClippedPoly; Clipping::clipPolygonAtRectangle( aPoly, pPosHelper->getScaledLogicClipDoubleRect(), aClippedPoly, false ); ShapeFactory::closePolygon(aClippedPoly); //again necessary after clipping - aPoly = aClippedPoly; + aPoly = std::move(aClippedPoly); } if(!ShapeFactory::hasPolygonAnyLines(aPoly)) diff --git a/connectivity/source/commontools/TDatabaseMetaDataBase.cxx b/connectivity/source/commontools/TDatabaseMetaDataBase.cxx index 0eba8e83c461..3ad805e7d3ab 100644 --- a/connectivity/source/commontools/TDatabaseMetaDataBase.cxx +++ b/connectivity/source/commontools/TDatabaseMetaDataBase.cxx @@ -162,7 +162,7 @@ Reference< XResultSet > SAL_CALL ODatabaseMetaDataBase::getTypeInfo( ) } aTypeInfoRows.push_back(aRow); } - m_aTypeInfoRows = aTypeInfoRows; + m_aTypeInfoRows = std::move(aTypeInfoRows); } } rtl::Reference<::connectivity::ODatabaseMetaDataResultSet> pResult = new ::connectivity::ODatabaseMetaDataResultSet(::connectivity::ODatabaseMetaDataResultSet::eTypeInfo); diff --git a/cppuhelper/source/servicemanager.cxx b/cppuhelper/source/servicemanager.cxx index 32b4976cf1e1..ddc8afcda681 100644 --- a/cppuhelper/source/servicemanager.cxx +++ b/cppuhelper/source/servicemanager.cxx @@ -871,7 +871,7 @@ void cppuhelper::ServiceManager::loadImplementation( || implementation->status == Data::Implementation::STATUS_LOADED)) { implementation->status = Data::Implementation::STATUS_LOADED; - implementation->constructorFn = ctor; + implementation->constructorFn = std::move(ctor); implementation->factory1 = f1; implementation->factory2 = f2; } diff --git a/drawinglayer/source/processor2d/vclmetafileprocessor2d.cxx b/drawinglayer/source/processor2d/vclmetafileprocessor2d.cxx index 0f6bf4c5c740..4435db4bd583 100644 --- a/drawinglayer/source/processor2d/vclmetafileprocessor2d.cxx +++ b/drawinglayer/source/processor2d/vclmetafileprocessor2d.cxx @@ -182,7 +182,7 @@ void fillPolyPolygonNeededToBeSplit(basegfx::B2DPolyPolygon& rPolyPolygon) if (aSplitted.count() != nPolyCount) { - rPolyPolygon = aSplitted; + rPolyPolygon = std::move(aSplitted); } } diff --git a/drawinglayer/source/tools/converters.cxx b/drawinglayer/source/tools/converters.cxx index 049c2db22aa4..f21ac499b073 100644 --- a/drawinglayer/source/tools/converters.cxx +++ b/drawinglayer/source/tools/converters.cxx @@ -113,7 +113,7 @@ AlphaMask implcreateAlphaMask(drawinglayer::primitive2d::Primitive2DContainer& r } const drawinglayer::primitive2d::Primitive2DReference xRef( new drawinglayer::primitive2d::ModifiedColorPrimitive2D(std::move(rSequence), - aBColorModifier)); + std::move(aBColorModifier))); const drawinglayer::primitive2d::Primitive2DContainer xSeq{ xRef }; // render diff --git a/editeng/source/misc/svxacorr.cxx b/editeng/source/misc/svxacorr.cxx index fb69464d2110..055d46879aa6 100644 --- a/editeng/source/misc/svxacorr.cxx +++ b/editeng/source/misc/svxacorr.cxx @@ -2093,7 +2093,7 @@ SvxAutoCorrect::SearchWordsInList( auto pRet = lcl_SearchWordsInList( &rList, rTxt, rStt, nEndPos ); if( pRet ) { - rLang = aLanguageTag; + rLang = std::move(aLanguageTag); return pRet; } } diff --git a/filter/source/config/cache/filtercache.cxx b/filter/source/config/cache/filtercache.cxx index b637f4cc3031..e92708ded4d7 100644 --- a/filter/source/config/cache/filtercache.cxx +++ b/filter/source/config/cache/filtercache.cxx @@ -444,7 +444,7 @@ void FilterCache::setItem( EItemType eType , // They can't be saved here and must be read on demand later, if they are needed. removeStatePropsFromItem(aItem); - rList[sItem] = aItem; + rList[sItem] = std::move(aItem); impl_addItem2FlushList(eType, sItem); } diff --git a/fpicker/source/office/iodlg.cxx b/fpicker/source/office/iodlg.cxx index cbfdd441329b..27049aa0aaa4 100644 --- a/fpicker/source/office/iodlg.cxx +++ b/fpicker/source/office/iodlg.cxx @@ -1317,7 +1317,7 @@ OUString SvtFileDialog::implGetInitialURL( const OUString& _rPath, std::u16strin } if ( !bIsInvalid ) - aURLParser = aParent; + aURLParser = std::move(aParent); } if ( !bIsInvalid && bIsFolder ) diff --git a/framework/source/services/pathsettings.cxx b/framework/source/services/pathsettings.cxx index a183cff67bff..133b819394a2 100644 --- a/framework/source/services/pathsettings.cxx +++ b/framework/source/services/pathsettings.cxx @@ -1170,7 +1170,7 @@ void PathSettings::impl_setPathValue( sal_Int32 nID , std::vector<OUString> lList = comphelper::sequenceToContainer<std::vector<OUString>>(lTmpList); if (! impl_isValidPath(lList)) throw css::lang::IllegalArgumentException(); - aChangePath.lInternalPaths = lList; + aChangePath.lInternalPaths = std::move(lList); } break; diff --git a/framework/source/uiconfiguration/ImageList.cxx b/framework/source/uiconfiguration/ImageList.cxx index 5fb0f44f65b6..f224ebcedc03 100644 --- a/framework/source/uiconfiguration/ImageList.cxx +++ b/framework/source/uiconfiguration/ImageList.cxx @@ -184,7 +184,7 @@ void ImageList::ImplAddImage( std::u16string_view aPrefix, const OUString &aName if (!aInsert) aInsert = Image( OUString::Concat("private:graphicrepository/") + aPrefix + aName ); - ImageAryData *pImg = new ImageAryData{ aName, nId, aInsert }; + ImageAryData *pImg = new ImageAryData{ aName, nId, std::move(aInsert) }; maImages.emplace_back( pImg ); if( !aName.isEmpty() ) maNameHash [ aName ] = pImg; diff --git a/helpcompiler/inc/HelpLinker.hxx b/helpcompiler/inc/HelpLinker.hxx index 9645f7c4c67c..22cd019ed2b8 100644 --- a/helpcompiler/inc/HelpLinker.hxx +++ b/helpcompiler/inc/HelpLinker.hxx @@ -81,7 +81,8 @@ private: /// @throws HelpProcessingException /// @throws BasicCodeTagger::TaggerException void link(); - static void addBookmark( FILE* pFile_DBHelp, std::string thishid, + static void addBookmark( FILE* pFile_DBHelp, + const std::string& thishid, const std::string& fileB, const std::string& anchorB, const std::string& jarfileB, const std::string& titleB ); }; diff --git a/helpcompiler/source/HelpCompiler.cxx b/helpcompiler/source/HelpCompiler.cxx index c27954c4cb1a..b9243265033c 100644 --- a/helpcompiler/source/HelpCompiler.cxx +++ b/helpcompiler/source/HelpCompiler.cxx @@ -485,7 +485,7 @@ void HelpCompiler::compile() actMod = actMod.substr(0, actMod.find('/')); } } - streamTable.document_module = actMod; + streamTable.document_module = std::move(actMod); xmlFreeDoc(docResolvedOrg); } diff --git a/helpcompiler/source/HelpLinker.cxx b/helpcompiler/source/HelpLinker.cxx index 4f52f9af4678..086ae3359ec6 100644 --- a/helpcompiler/source/HelpLinker.cxx +++ b/helpcompiler/source/HelpLinker.cxx @@ -222,15 +222,14 @@ namespace URLEncoder } } -void HelpLinker::addBookmark( FILE* pFile_DBHelp, std::string thishid, +void HelpLinker::addBookmark( FILE* pFile_DBHelp, + const std::string& thishid, const std::string& fileB, const std::string& anchorB, const std::string& jarfileB, const std::string& titleB) { HCDBG(std::cerr << "HelpLinker::addBookmark " << thishid << " " << fileB << " " << anchorB << " " << jarfileB << " " << titleB << std::endl); - thishid = URLEncoder::encode(thishid); - int fileLen = fileB.length(); if (!anchorB.empty()) fileLen += (1 + anchorB.length()); @@ -258,7 +257,7 @@ void HelpLinker::addBookmark( FILE* pFile_DBHelp, std::string thishid, if( pFile_DBHelp != nullptr ) { std::string aValueStr( dataB.begin(), dataB.end() ); - writeKeyValue_DBHelp( pFile_DBHelp, thishid, aValueStr ); + writeKeyValue_DBHelp( pFile_DBHelp, URLEncoder::encode(thishid), aValueStr ); } } diff --git a/idl/source/prj/parser.cxx b/idl/source/prj/parser.cxx index d3e796d52efc..f17046a2821d 100644 --- a/idl/source/prj/parser.cxx +++ b/idl/source/prj/parser.cxx @@ -429,7 +429,7 @@ void SvIdlParser::ReadInterfaceOrShellMethod( SvMetaAttribute& rAttr ) Read( '(' ); tools::SvRef<SvMetaType> xT(new SvMetaType() ); xT->SetRef(rAttr.GetType() ); - rAttr.aType = xT; + rAttr.aType = std::move(xT); rAttr.aType->SetType( MetaTypeType::Method ); if (ReadIf(')')) return; diff --git a/libreofficekit/qa/gtktiledviewer/gtv-signal-handlers.cxx b/libreofficekit/qa/gtktiledviewer/gtv-signal-handlers.cxx index 1f2520162c10..0f80a365ab0f 100644 --- a/libreofficekit/qa/gtktiledviewer/gtv-signal-handlers.cxx +++ b/libreofficekit/qa/gtktiledviewer/gtv-signal-handlers.cxx @@ -216,11 +216,11 @@ void recentUnoChanged( GtkWidget* pSelector, gpointer /* pItem */ ) g_free(pUnoCmd); } -static void addToRecentUnoCommands(GtvApplicationWindow* pWindow, const std::string& rUnoCmd, std::string rArgs) +static void addToRecentUnoCommands(GtvApplicationWindow* pWindow, const std::string& rUnoCmd, std::string aArgs) { GtvMainToolbar* pToolbar = gtv_application_window_get_main_toolbar(pWindow); - rArgs.erase(std::find(rArgs.begin(), rArgs.end(), ' ')); - const std::string rUnoCmdStr = rUnoCmd + " | " + rArgs; + aArgs.erase(std::find(aArgs.begin(), aArgs.end(), ' ')); + const std::string rUnoCmdStr = rUnoCmd + " | " + aArgs; // add to file @@ -276,7 +276,7 @@ void unoCommandDebugger(GtkWidget* pButton, gpointer /* pItem */) g_info("Generated UNO command: %s %s", sUnoCmd, aArguments.c_str()); lok_doc_view_post_command(LOK_DOC_VIEW(window->lokdocview), sUnoCmd, (aArguments.empty() ? nullptr : aArguments.c_str()), false); - addToRecentUnoCommands(window, sUnoCmd, aArguments); + addToRecentUnoCommands(window, sUnoCmd, std::move(aArguments)); g_free(sUnoCmd); } diff --git a/lingucomponent/source/languageguessing/guesslang.cxx b/lingucomponent/source/languageguessing/guesslang.cxx index 8069071531a5..db179c9bfdc9 100644 --- a/lingucomponent/source/languageguessing/guesslang.cxx +++ b/lingucomponent/source/languageguessing/guesslang.cxx @@ -224,7 +224,7 @@ uno::Sequence< Locale > SAL_CALL LangGuess_Impl::getEnabledLanguages( ) css::lang::Locale current_aRes; current_aRes.Language = OUString::createFromAscii( gs[i].GetLanguage() ); current_aRes.Country = OUString::createFromAscii( gs[i].GetCountry() ); - pRes[i] = current_aRes; + pRes[i] = std::move(current_aRes); } return aRes; @@ -246,7 +246,7 @@ uno::Sequence< Locale > SAL_CALL LangGuess_Impl::getDisabledLanguages( ) css::lang::Locale current_aRes; current_aRes.Language = OUString::createFromAscii( gs[i].GetLanguage() ); current_aRes.Country = OUString::createFromAscii( gs[i].GetCountry() ); - pRes[i] = current_aRes; + pRes[i] = std::move(current_aRes); } return aRes; diff --git a/reportdesign/source/filter/xml/xmlExport.cxx b/reportdesign/source/filter/xml/xmlExport.cxx index 27f0406057c8..8d1080f8f945 100644 --- a/reportdesign/source/filter/xml/xmlExport.cxx +++ b/reportdesign/source/filter/xml/xmlExport.cxx @@ -1204,7 +1204,7 @@ void ORptExport::exportAutoStyle(XPropertySet* _xProp,const Reference<XFormatted { // there is already a property but it has the wrong type // (integer not string); TODO: can we prevent it // getting added earlier? - (*iter) = aNumberStyleState; + (*iter) = std::move(aNumberStyleState); } } } diff --git a/sc/source/core/data/column2.cxx b/sc/source/core/data/column2.cxx index 2b0a88aef220..e99933785860 100644 --- a/sc/source/core/data/column2.cxx +++ b/sc/source/core/data/column2.cxx @@ -2141,7 +2141,7 @@ public: auto* pList = rDestDoc.GetSparklineList(mrDestColumn.GetTab()); pList->addSparkline(pNewSparkline); - miDestPosition = mrDestSparkline.set(miDestPosition, nDestRow, new sc::SparklineCell(pNewSparkline)); + miDestPosition = mrDestSparkline.set(miDestPosition, nDestRow, new sc::SparklineCell(std::move(pNewSparkline))); } }; diff --git a/sc/source/core/data/formulacell.cxx b/sc/source/core/data/formulacell.cxx index cf666cda931c..80abda16f2ca 100644 --- a/sc/source/core/data/formulacell.cxx +++ b/sc/source/core/data/formulacell.cxx @@ -4661,7 +4661,7 @@ struct ScDependantsCalculator mxGroup->mbPartOfCycle = true; if (pSuccessfulDependencies && !bHasSelfReferences) - *pSuccessfulDependencies = aRangeList; + *pSuccessfulDependencies = std::move(aRangeList); return !bHasSelfReferences; } diff --git a/sc/source/filter/excel/xichart.cxx b/sc/source/filter/excel/xichart.cxx index e5ad452c4f19..5189b60e229a 100644 --- a/sc/source/filter/excel/xichart.cxx +++ b/sc/source/filter/excel/xichart.cxx @@ -2865,7 +2865,7 @@ void XclImpChTypeGroup::ReadChDataFormat( XclImpStream& rStrm ) const XclChDataPointPos& rPos = xDataFmt->GetPointPos(); if( (rPos.mnSeriesIdx == 0) && (rPos.mnPointIdx == 0) && (xDataFmt->GetFormatIdx() == EXC_CHDATAFORMAT_DEFAULT) ) - mxGroupFmt = xDataFmt; + mxGroupFmt = std::move(xDataFmt); } void XclImpChTypeGroup::InsertDataSeries( Reference< XChartType > const & xChartType, diff --git a/sc/source/ui/drawfunc/fuins2.cxx b/sc/source/ui/drawfunc/fuins2.cxx index cac0c9f3e53a..6b9f63ab0963 100644 --- a/sc/source/ui/drawfunc/fuins2.cxx +++ b/sc/source/ui/drawfunc/fuins2.cxx @@ -457,7 +457,7 @@ FuInsertChart::FuInsertChart(ScTabViewShell& rViewSh, vcl::Window* pWin, ScDrawV bAutomaticMark = true; } - ScMarkData aMultiMark( aMark ); + ScMarkData aMultiMark(std::move(aMark)); aMultiMark.MarkToMulti(); ScRangeList aRanges; diff --git a/sc/source/ui/unoobj/docuno.cxx b/sc/source/ui/unoobj/docuno.cxx index 15a8c4bfd223..8fdbec2ba040 100644 --- a/sc/source/ui/unoobj/docuno.cxx +++ b/sc/source/ui/unoobj/docuno.cxx @@ -1864,7 +1864,7 @@ sal_Int32 SAL_CALL ScModelObj::getRendererCount(const uno::Any& aSelection, if (!pPrintFuncCache || !pPrintFuncCache->IsSameSelection(aStatus) || bUsePrintDialogSetting || bPrintAreaReset) { - pPrintFuncCache.reset(new ScPrintFuncCache(pDocShell, aMark, aStatus, aPrintPageSize, + pPrintFuncCache.reset(new ScPrintFuncCache(pDocShell, aMark, std::move(aStatus), aPrintPageSize, bPrintPageLandscape, bUsePrintDialogSetting)); } sal_Int32 nPages = pPrintFuncCache->GetPageCount(); diff --git a/sd/source/console/PresenterTheme.cxx b/sd/source/console/PresenterTheme.cxx index f877d20b1c3b..ef8cd5a3a29d 100644 --- a/sd/source/console/PresenterTheme.cxx +++ b/sd/source/console/PresenterTheme.cxx @@ -956,7 +956,7 @@ void ViewStyleContainer::ProcessViewStyle( PresenterTheme::SharedFontDescriptor pFont ( ReadContext::ReadFont(xFontNode, PresenterTheme::SharedFontDescriptor())); if (pFont) - pStyle->mpFont = pFont; + pStyle->mpFont = std::move(pFont); Reference<container::XHierarchicalNameAccess> xBackgroundNode ( PresenterConfigurationAccess::GetProperty(rxProperties, u"Background"_ustr), @@ -968,7 +968,7 @@ void ViewStyleContainer::ProcessViewStyle( rReadContext.mxCanvas, SharedBitmapDescriptor())); if (pBackground && pBackground->GetNormalBitmap().is()) - pStyle->mpBackground = pBackground; + pStyle->mpBackground = std::move(pBackground); mStyles.push_back(pStyle); } diff --git a/sd/source/filter/ppt/ppt97animations.cxx b/sd/source/filter/ppt/ppt97animations.cxx index db3a960a78d4..307fad11f515 100644 --- a/sd/source/filter/ppt/ppt97animations.cxx +++ b/sd/source/filter/ppt/ppt97animations.cxx @@ -671,7 +671,7 @@ void Ppt97Animation::createAndSetCustomAnimationEffect( SdrObject* pObj ) else pGroupEffect->setNodeType( presentation::EffectNodeType::AFTER_PREVIOUS ); } - pLastEffect = pGroupEffect; + pLastEffect = std::move(pGroupEffect); nIndex++; } } diff --git a/sd/source/ui/func/fuconrec.cxx b/sd/source/ui/func/fuconrec.cxx index fe4dde1ca152..1c0557705c6c 100644 --- a/sd/source/ui/func/fuconrec.cxx +++ b/sd/source/ui/func/fuconrec.cxx @@ -778,7 +778,7 @@ void FuConstructRectangle::SetLineEnds(SfxItemSet& rAttr, SdrObject const & rObj case SID_LINE_SQUARE_ARROW: { // connector with arrow end - rAttr.Put(XLineEndItem(SvxResId(RID_SVXSTR_ARROW), aArrow)); + rAttr.Put(XLineEndItem(SvxResId(RID_SVXSTR_ARROW), std::move(aArrow))); rAttr.Put(XLineEndWidthItem(nWidth)); } break; diff --git a/sd/source/ui/func/fumorph.cxx b/sd/source/ui/func/fumorph.cxx index 1de932fb68f5..3fd98a7425f3 100644 --- a/sd/source/ui/func/fumorph.cxx +++ b/sd/source/ui/func/fumorph.cxx @@ -373,7 +373,7 @@ void FuMorph::ImpInsertPolygons( if ( !pPageView ) return; - SfxItemSet aSet( aSet1 ); + SfxItemSet aSet( std::move(aSet1) ); rtl::Reference<SdrObjGroup> xObjGroup(new SdrObjGroup(mpView->getSdrModelFromSdrView())); SdrObjList* pObjList = xObjGroup->GetSubList(); const size_t nCount = rPolyPolyList3D.size(); diff --git a/sd/source/ui/table/TableDesignPane.cxx b/sd/source/ui/table/TableDesignPane.cxx index 54797bb3894c..dcac6a380874 100644 --- a/sd/source/ui/table/TableDesignPane.cxx +++ b/sd/source/ui/table/TableDesignPane.cxx @@ -893,7 +893,7 @@ static void FillCellInfoMatrix( const CellInfoVector& rStyle, const TableStyleSe xCellInfo = rStyle[sdr::table::body_style]; } - rMatrix[(nCol * nPreviewColumns) + nRow] = xCellInfo; + rMatrix[(nCol * nPreviewColumns) + nRow] = std::move(xCellInfo); } } } diff --git a/sd/source/ui/view/ViewShellManager.cxx b/sd/source/ui/view/ViewShellManager.cxx index bae997eb7446..c6fd5fa843ae 100644 --- a/sd/source/ui/view/ViewShellManager.cxx +++ b/sd/source/ui/view/ViewShellManager.cxx @@ -1028,7 +1028,7 @@ ShellDescriptor ViewShellManager::Implementation::CreateSubShell ( // Exit the loop when the shell has been successfully created. if (aResult.mpShell != nullptr) { - aResult.mpFactory = pFactory; + aResult.mpFactory = std::move(pFactory); aResult.mnId = nShellId; break; } diff --git a/slideshow/source/engine/slideview.cxx b/slideshow/source/engine/slideview.cxx index 2f10e457e910..5c5758bb2831 100644 --- a/slideshow/source/engine/slideview.cxx +++ b/slideshow/source/engine/slideview.cxx @@ -966,8 +966,7 @@ void SlideView::setClip( const basegfx::B2DPolyPolygon& rClip ) if( aNewClip != maClip ) { - maClip = aNewClip; - + maClip = std::move(aNewClip); updateClip(); } } diff --git a/sw/source/core/doc/DocumentDeviceManager.cxx b/sw/source/core/doc/DocumentDeviceManager.cxx index 29eeb9eec5f3..690a183e1fdc 100644 --- a/sw/source/core/doc/DocumentDeviceManager.cxx +++ b/sw/source/core/doc/DocumentDeviceManager.cxx @@ -215,7 +215,7 @@ void DocumentDeviceManager::setJobsetup(/*[in]*/ const JobSetup &rJobSetup ) setPrinter( p, true, true ); else { - mpPrt = p; + mpPrt = std::move(p); bDataChanged = true; } } diff --git a/sw/source/core/unocore/unocontentcontrol.cxx b/sw/source/core/unocore/unocontentcontrol.cxx index fcc6dc1f05ae..3328c5eafb73 100644 --- a/sw/source/core/unocore/unocontentcontrol.cxx +++ b/sw/source/core/unocore/unocontentcontrol.cxx @@ -718,7 +718,7 @@ void SAL_CALL SwXContentControl::setPropertyValue(const OUString& rPropertyName, = SwContentControlListItem::ItemsFromAny(rValue); if (m_pImpl->m_bIsDescriptor) { - m_pImpl->m_aListItems = aItems; + m_pImpl->m_aListItems = std::move(aItems); if (!m_pImpl->m_bComboBox && !m_pImpl->m_bDropDown) { diff --git a/sw/source/filter/ww8/wrtw8nds.cxx b/sw/source/filter/ww8/wrtw8nds.cxx index ccb3b1c0b6fd..0f4411ea32c9 100644 --- a/sw/source/filter/ww8/wrtw8nds.cxx +++ b/sw/source/filter/ww8/wrtw8nds.cxx @@ -808,7 +808,7 @@ FlyProcessingState SwWW8AttrIter::OutFlys(sal_Int32 nSwPos) } } m_rExport.m_bLinkedTextboxesHelperInitialized = false; - m_rExport.m_aLinkedTextboxesHelper[sLinkChainName] = aLinkedTextboxInfo; + m_rExport.m_aLinkedTextboxesHelper[sLinkChainName] = std::move(aLinkedTextboxInfo); } } ++linkedTextboxesIter; diff --git a/sw/source/filter/ww8/ww8par5.cxx b/sw/source/filter/ww8/ww8par5.cxx index 39295160adc4..a20379b4a92e 100644 --- a/sw/source/filter/ww8/ww8par5.cxx +++ b/sw/source/filter/ww8/ww8par5.cxx @@ -3486,7 +3486,7 @@ eF_ResT SwWW8ImplReader::Read_F_Tox( WW8FieldDesc* pF, OUString& rStr ) const SwPosition* pPos = m_pPaM->GetPoint(); - SwFltTOX aFltTOX( pBase ); + SwFltTOX aFltTOX(std::move(pBase)); // test if there is already a break item on this node if(SwContentNode* pNd = pPos->GetNode().GetContentNode()) diff --git a/sw/source/uibase/shells/textsh1.cxx b/sw/source/uibase/shells/textsh1.cxx index 68e0483b0b89..4b1212b288d9 100644 --- a/sw/source/uibase/shells/textsh1.cxx +++ b/sw/source/uibase/shells/textsh1.cxx @@ -1095,7 +1095,7 @@ void SwTextShell::Execute(SfxRequest &rReq) std::shared_ptr<weld::DialogController> pDialogController(pAbstractDialog->getDialogController()); weld::DialogController::runAsync(pDialogController, - [pAbstractDialog, &rWrtSh] (sal_Int32 nResult) { + [pAbstractDialog=std::move(pAbstractDialog), &rWrtSh] (sal_Int32 nResult) { if( RET_OK == nResult ) { sal_uInt16 nKind = pAbstractDialog->GetKind(); diff --git a/sw/source/uibase/uiview/viewling.cxx b/sw/source/uibase/uiview/viewling.cxx index 1231837ae657..da7bd54a863c 100644 --- a/sw/source/uibase/uiview/viewling.cxx +++ b/sw/source/uibase/uiview/viewling.cxx @@ -765,7 +765,7 @@ bool SwView::ExecSpellPopup(const Point& rPt) // Execute dispatch asynchronously ExecuteInfo* pExecuteInfo = new ExecuteInfo; pExecuteInfo->xDispatch = xDispatch; - pExecuteInfo->aTargetURL = aURL; + pExecuteInfo->aTargetURL = std::move(aURL); Application::PostUserEvent( LINK(nullptr, AsyncExecute , ExecuteHdl_Impl), pExecuteInfo ); } } diff --git a/tools/source/fsys/urlobj.cxx b/tools/source/fsys/urlobj.cxx index e965b32752d8..2c23d67678ad 100644 --- a/tools/source/fsys/urlobj.cxx +++ b/tools/source/fsys/urlobj.cxx @@ -4826,7 +4826,7 @@ void INetURLObject::CutLastName() aTemp.clearQuery(); if (!aTemp.removeSegment(LAST_SEGMENT, false)) return; - *this = aTemp; + *this = std::move(aTemp); } OUString INetURLObject::PathToFileName() const diff --git a/ucb/source/ucp/package/pkgcontent.cxx b/ucb/source/ucp/package/pkgcontent.cxx index 64f6eaa8d67a..a9c5407a6d4c 100644 --- a/ucb/source/ucp/package/pkgcontent.cxx +++ b/ucb/source/ucp/package/pkgcontent.cxx @@ -1965,7 +1965,7 @@ bool Content::exchangeIdentity( aGuard.clear(); if ( exchange( xNewId ) ) { - m_aUri = aNewUri; + m_aUri = std::move(aNewUri); if ( isFolder() ) { // Process instantiated children... diff --git a/vcl/source/bitmap/BitmapSimpleColorQuantizationFilter.cxx b/vcl/source/bitmap/BitmapSimpleColorQuantizationFilter.cxx index 4dc045be2d64..5819f4afb206 100644 --- a/vcl/source/bitmap/BitmapSimpleColorQuantizationFilter.cxx +++ b/vcl/source/bitmap/BitmapSimpleColorQuantizationFilter.cxx @@ -77,7 +77,7 @@ BitmapEx BitmapSimpleColorQuantizationFilter::execute(BitmapEx const& aBitmapEx) const MapMode aMap(aBitmap.GetPrefMapMode()); const Size aSize(aBitmap.GetPrefSize()); - aBitmap = aNewBmp; + aBitmap = std::move(aNewBmp); aBitmap.SetPrefMapMode(aMap); aBitmap.SetPrefSize(aSize); diff --git a/vcl/source/filter/idxf/dxf2mtf.cxx b/vcl/source/filter/idxf/dxf2mtf.cxx index 103458e9d019..53bdcfd98bc1 100644 --- a/vcl/source/filter/idxf/dxf2mtf.cxx +++ b/vcl/source/filter/idxf/dxf2mtf.cxx @@ -208,7 +208,7 @@ bool DXF2GDIMetaFile::SetFontAttribute(const DXFBasicEntity & rE, short nAngle, aFont.SetAlignment(ALIGN_BASELINE); aFont.SetOrientation(Degree10(nAngle)); if (aActFont!=aFont) { - aActFont=aFont; + aActFont=std::move(aFont); pVirDev->SetFont(aActFont); } diff --git a/vcl/source/filter/ieps/ieps.cxx b/vcl/source/filter/ieps/ieps.cxx index 8ec84cd9ba8e..b5dfcfa40b64 100644 --- a/vcl/source/filter/ieps/ieps.cxx +++ b/vcl/source/filter/ieps/ieps.cxx @@ -803,7 +803,7 @@ bool ImportEpsGraphic( SvStream & rStream, Graphic & rGraphic) aGraphic); } - GfxLink aGfxLink( aBuf, GfxLinkType::EpsBuffer ) ; + GfxLink aGfxLink(std::move(aBuf), GfxLinkType::EpsBuffer); aMtf.AddAction( static_cast<MetaAction*>( new MetaEPSAction( Point(), Size( nWidth, nHeight ), std::move(aGfxLink), aGraphic.GetGDIMetaFile() ) ) ); CreateMtfReplacementAction( aMtf, rStream, nOrigPos, nPSSize, nPosWMF, nSizeWMF, nPosTIFF, nSizeTIFF ); diff --git a/vcl/source/outdev/outdev.cxx b/vcl/source/outdev/outdev.cxx index 44806506aa32..b2ca6382bfac 100644 --- a/vcl/source/outdev/outdev.cxx +++ b/vcl/source/outdev/outdev.cxx @@ -698,7 +698,7 @@ void OutputDevice::ReMirror( vcl::Region &rRegion ) const aMirroredRegion.Union(rectangle); } - rRegion = aMirroredRegion; + rRegion = std::move(aMirroredRegion); } diff --git a/vcl/unx/generic/printer/printerinfomanager.cxx b/vcl/unx/generic/printer/printerinfomanager.cxx index d2f7173ffa26..ecfe13cbd247 100644 --- a/vcl/unx/generic/printer/printerinfomanager.cxx +++ b/vcl/unx/generic/printer/printerinfomanager.cxx @@ -450,7 +450,7 @@ void PrinterInfoManager::initialize() aPrinter.m_aAlternateFiles = find_it->second.m_aAlternateFiles; aPrinter.m_aAlternateFiles.insert( find_it->second.m_aFile ); } - m_aPrinters[ aPrinterName ] = aPrinter; + m_aPrinters[ aPrinterName ] = std::move(aPrinter); } } } diff --git a/xmloff/source/text/txtparae.cxx b/xmloff/source/text/txtparae.cxx index 87630d6bf0d0..87f3de90b4ff 100644 --- a/xmloff/source/text/txtparae.cxx +++ b/xmloff/source/text/txtparae.cxx @@ -2296,7 +2296,7 @@ void XMLTextParagraphExport::exportTextRangeEnumeration( { if (HyperlinkData aNewHyperlinkData(xPropSet); aNewHyperlinkData != aHyperlinkData) { - aHyperlinkData = aNewHyperlinkData; + aHyperlinkData = std::move(aNewHyperlinkData); oTextA.reset(); if (aHyperlinkData.addHyperlinkAttributes(GetExport())) {
