basegfx/source/polygon/b2dpolypolygoncutter.cxx | 2 +- binaryurp/source/reader.cxx | 4 ++-- connectivity/source/drivers/postgresql/pq_databasemetadata.cxx | 2 +- dbaccess/source/core/api/RowSetCache.cxx | 2 +- dbaccess/source/ui/misc/dsmeta.cxx | 2 +- lotuswordpro/source/filter/lwpbookmarkmgr.cxx | 4 ++-- oox/source/vml/vmlshape.cxx | 4 ++-- sc/inc/externalrefmgr.hxx | 2 +- sc/source/core/data/dptabsrc.cxx | 2 +- sc/source/core/tool/interpr5.cxx | 2 +- sc/source/ui/docshell/externalrefmgr.cxx | 2 +- svgio/source/svgreader/svgfedropshadownode.cxx | 2 +- svx/source/svdraw/svdfmtf.cxx | 2 +- sw/source/writerfilter/ooxml/OOXMLPropertySet.cxx | 2 +- ucb/source/ucp/webdav-curl/DAVResourceAccess.cxx | 2 +- unoidl/source/sourceprovider-parser.y | 2 +- vcl/source/bitmap/BitmapScaleConvolutionFilter.cxx | 2 +- vcl/source/bitmap/BitmapScaleSuperFilter.cxx | 2 +- vcl/source/gdi/print.cxx | 2 +- vcl/source/window/builder.cxx | 2 +- 20 files changed, 23 insertions(+), 23 deletions(-)
New commits: commit 4504d921a6ac45617ab700316182e68c3248a045 Author: Caolán McNamara <[email protected]> AuthorDate: Wed Jul 17 12:08:10 2024 +0100 Commit: Caolán McNamara <[email protected]> CommitDate: Wed Jul 17 21:49:14 2024 +0200 cid#1555694 COPY_INSTEAD_OF_MOVE and cid#1555695 COPY_INSTEAD_OF_MOVE cid#1555696 COPY_INSTEAD_OF_MOVE cid#1555705 COPY_INSTEAD_OF_MOVE cid#1555711 COPY_INSTEAD_OF_MOVE cid#1555713 COPY_INSTEAD_OF_MOVE cid#1555727 COPY_INSTEAD_OF_MOVE cid#1555742 COPY_INSTEAD_OF_MOVE cid#1555745 COPY_INSTEAD_OF_MOVE cid#1555749 COPY_INSTEAD_OF_MOVE cid#1555760 COPY_INSTEAD_OF_MOVE cid#1555773 COPY_INSTEAD_OF_MOVE cid#1555774 COPY_INSTEAD_OF_MOVE cid#1555778 COPY_INSTEAD_OF_MOVE cid#1555790 COPY_INSTEAD_OF_MOVE cid#1555831 COPY_INSTEAD_OF_MOVE cid#1555847 COPY_INSTEAD_OF_MOVE cid#1555851 COPY_INSTEAD_OF_MOVE cid#1555853 COPY_INSTEAD_OF_MOVE cid#1607763 COPY_INSTEAD_OF_MOVE cid#1607504 COPY_INSTEAD_OF_MOVE Change-Id: I991f15f12e773d325ed9725498df5725b049a858 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170625 Tested-by: Jenkins Reviewed-by: Caolán McNamara <[email protected]> diff --git a/basegfx/source/polygon/b2dpolypolygoncutter.cxx b/basegfx/source/polygon/b2dpolypolygoncutter.cxx index 4ad6eb5b219d..bec0c20fa7e4 100644 --- a/basegfx/source/polygon/b2dpolypolygoncutter.cxx +++ b/basegfx/source/polygon/b2dpolypolygoncutter.cxx @@ -1118,7 +1118,7 @@ namespace basegfx::utils } } - aResult = aResult2; + aResult = std::move(aResult2); } // third step: get result diff --git a/binaryurp/source/reader.cxx b/binaryurp/source/reader.cxx index 6930bd900124..9aa27ec7782f 100644 --- a/binaryurp/source/reader.cxx +++ b/binaryurp/source/reader.cxx @@ -330,8 +330,8 @@ void Reader::readMessage(Unmarshal & unmarshal) { } std::unique_ptr< IncomingRequest > req( new IncomingRequest( - bridge_, tid, oid, obj, type, functionId, synchronous, memberTd, - bSetter, std::move(inArgs), ccMode, cc)); + bridge_, tid, oid, std::move(obj), type, functionId, synchronous, + memberTd, bSetter, std::move(inArgs), ccMode, cc)); if (synchronous) { bridge_->incrementActiveCalls(); } diff --git a/connectivity/source/drivers/postgresql/pq_databasemetadata.cxx b/connectivity/source/drivers/postgresql/pq_databasemetadata.cxx index 0b471a92fa9c..76157bc4c305 100644 --- a/connectivity/source/drivers/postgresql/pq_databasemetadata.cxx +++ b/connectivity/source/drivers/postgresql/pq_databasemetadata.cxx @@ -1778,7 +1778,7 @@ css::uno::Reference< XResultSet > DatabaseMetaData::getPrimaryKeys( if( closeable.is() ) closeable->close(); } - ret[elements] = row; + ret[elements] = std::move(row); elements ++; } return new SequenceResultSet( diff --git a/dbaccess/source/core/api/RowSetCache.cxx b/dbaccess/source/core/api/RowSetCache.cxx index ae596d48d1d4..086e7a055201 100644 --- a/dbaccess/source/core/api/RowSetCache.cxx +++ b/dbaccess/source/core/api/RowSetCache.cxx @@ -627,7 +627,7 @@ void ORowSetCache::updateNumericObject( sal_Int32 columnIndex, const Any& x if ( rInsert[columnIndex] != aTemp ) { rInsert[columnIndex].setBound(true); - rInsert[columnIndex] = aTemp; + rInsert[columnIndex] = std::move(aTemp); rInsert[columnIndex].setModified(true); io_aRow[columnIndex] = rInsert[columnIndex]; diff --git a/dbaccess/source/ui/misc/dsmeta.cxx b/dbaccess/source/ui/misc/dsmeta.cxx index b3f141980553..9790e6cdc405 100644 --- a/dbaccess/source/ui/misc/dsmeta.cxx +++ b/dbaccess/source/ui/misc/dsmeta.cxx @@ -100,7 +100,7 @@ namespace dbaui aCurrentSet.put( rFeatureMapping.nItemID ); } - tmp[ pattern ] = aCurrentSet; + tmp[pattern] = std::move(aCurrentSet); } return tmp; }(); diff --git a/lotuswordpro/source/filter/lwpbookmarkmgr.cxx b/lotuswordpro/source/filter/lwpbookmarkmgr.cxx index 7e57cb59b276..918ba3e7bd1b 100644 --- a/lotuswordpro/source/filter/lwpbookmarkmgr.cxx +++ b/lotuswordpro/source/filter/lwpbookmarkmgr.cxx @@ -67,7 +67,7 @@ void LwpBookmarkMgr::AddXFBookmarkStart(const OUString& sName, XFBookmarkStart* auto xFind = iter->second; OUString totalName = xFind->GetDivision() + ":" + xFind->GetName(); xFind->SetName(totalName); - m_MapStart[totalName] = xFind; + m_MapStart[totalName] = std::move(xFind); m_MapStart[sName] = pMark; } } @@ -83,7 +83,7 @@ void LwpBookmarkMgr::AddXFBookmarkEnd(const OUString& sName, XFBookmarkEnd* pMar auto xFind = iter->second; OUString totalName = xFind->GetDivision() + ":" + xFind->GetName(); xFind->SetName(totalName); - m_MapEnd[totalName] = xFind; + m_MapEnd[totalName] = std::move(xFind); m_MapEnd[sName] = pMark; } } diff --git a/oox/source/vml/vmlshape.cxx b/oox/source/vml/vmlshape.cxx index d9a50e3084db..d0e77512ceeb 100644 --- a/oox/source/vml/vmlshape.cxx +++ b/oox/source/vml/vmlshape.cxx @@ -306,8 +306,8 @@ void ShapeBase::finalizeFragmentImport() aMergedFillModel.assignUsed(maTypeModel.maFillModel); maTypeModel.assignUsed( pShapeType->getTypeModel() ); - maTypeModel.maStrokeModel = aMergedStrokeModel; - maTypeModel.maFillModel = aMergedFillModel; + maTypeModel.maStrokeModel = std::move(aMergedStrokeModel); + maTypeModel.maFillModel = std::move(aMergedFillModel); } else { // Temporary fix, shapetype not found if referenced from different substream diff --git a/sc/inc/externalrefmgr.hxx b/sc/inc/externalrefmgr.hxx index 82441073cfd0..5716d15adcc1 100644 --- a/sc/inc/externalrefmgr.hxx +++ b/sc/inc/externalrefmgr.hxx @@ -219,7 +219,7 @@ public: sal_uInt16 nFileId, const OUString& rTabName, const ScRange& rRange); ScExternalRefCache::TokenArrayRef getRangeNameTokens(sal_uInt16 nFileId, const OUString& rName); - void setRangeNameTokens(sal_uInt16 nFileId, const OUString& rName, TokenArrayRef pArray); + void setRangeNameTokens(sal_uInt16 nFileId, const OUString& rName, const TokenArrayRef& pArray); bool isValidRangeName(sal_uInt16 nFileId, const OUString& rName) const; void setRangeName(sal_uInt16 nFileId, const OUString& rName); diff --git a/sc/source/core/data/dptabsrc.cxx b/sc/source/core/data/dptabsrc.cxx index 52e72455b2d1..ad8f2490f2ba 100644 --- a/sc/source/core/data/dptabsrc.cxx +++ b/sc/source/core/data/dptabsrc.cxx @@ -2408,7 +2408,7 @@ ScDPMember* ScDPMembers::getByIndex(sal_Int32 nIndex) const const std::vector<SCROW>& memberIndexs = pSource->GetData()->GetColumnEntries(nSrcDim); pNew.set(new ScDPMember(pSource, nDim, nHier, nLev, memberIndexs[nIndex])); } - maMembers[nIndex] = pNew; + maMembers[nIndex] = std::move(pNew); } return maMembers[nIndex].get(); diff --git a/sc/source/core/tool/interpr5.cxx b/sc/source/core/tool/interpr5.cxx index 2f4fe0f19fa1..406d379c7eec 100644 --- a/sc/source/core/tool/interpr5.cxx +++ b/sc/source/core/tool/interpr5.cxx @@ -2324,7 +2324,7 @@ bool ScInterpreter::CheckMatrix(bool _bLOG, sal_uInt8& nCase, SCSIZE& nCX, else pNewY->PutDouble(log(fVal), nElem); } - pMatY = pNewY; + pMatY = std::move(pNewY); } if (pMatX) diff --git a/sc/source/ui/docshell/externalrefmgr.cxx b/sc/source/ui/docshell/externalrefmgr.cxx index c9cde1cbf8f5..d1bbaa8a8197 100644 --- a/sc/source/ui/docshell/externalrefmgr.cxx +++ b/sc/source/ui/docshell/externalrefmgr.cxx @@ -751,7 +751,7 @@ ScExternalRefCache::TokenArrayRef ScExternalRefCache::getRangeNameTokens(sal_uIn return itr->second; } -void ScExternalRefCache::setRangeNameTokens(sal_uInt16 nFileId, const OUString& rName, TokenArrayRef pArray) +void ScExternalRefCache::setRangeNameTokens(sal_uInt16 nFileId, const OUString& rName, const TokenArrayRef& pArray) { std::unique_lock aGuard(maMtxDocs); diff --git a/svgio/source/svgreader/svgfedropshadownode.cxx b/svgio/source/svgreader/svgfedropshadownode.cxx index 23a6464d523e..994bd6f35160 100644 --- a/svgio/source/svgreader/svgfedropshadownode.cxx +++ b/svgio/source/svgreader/svgfedropshadownode.cxx @@ -153,7 +153,7 @@ void SvgFeDropShadowNode::apply(drawinglayer::primitive2d::Primitive2DContainer& // Append the original target aTempTarget.append(rTarget); - rTarget = aTempTarget; + rTarget = std::move(aTempTarget); pParent->addGraphicSourceToMapper(maResult, rTarget); } diff --git a/svx/source/svdraw/svdfmtf.cxx b/svx/source/svdraw/svdfmtf.cxx index 90d2c509f837..dc60301e6cb6 100644 --- a/svx/source/svdraw/svdfmtf.cxx +++ b/svx/source/svdraw/svdfmtf.cxx @@ -814,7 +814,7 @@ bool ImpSdrGDIMetaFileImport::CheckLastLineMerge(const basegfx::B2DPolygon& rSrc { basegfx::B2DPolygon aNew(rSrcPoly); aNew.append(aDstPoly, 1, aDstPoly.count() - 1); - aDstPoly = aNew; + aDstPoly = std::move(aNew); bOk = true; } else if(aDstPoly.getB2DPoint(0) == rSrcPoly.getB2DPoint(0)) diff --git a/sw/source/writerfilter/ooxml/OOXMLPropertySet.cxx b/sw/source/writerfilter/ooxml/OOXMLPropertySet.cxx index f29efe875aee..ddd40cbe0ea4 100644 --- a/sw/source/writerfilter/ooxml/OOXMLPropertySet.cxx +++ b/sw/source/writerfilter/ooxml/OOXMLPropertySet.cxx @@ -758,7 +758,7 @@ void OOXMLTable::resolve(Table & rTable) (rPropSet->getProperties()); if (pProperties) - pTable->entry(nPos, pProperties); + pTable->entry(nPos, std::move(pProperties)); ++nPos; } diff --git a/ucb/source/ucp/webdav-curl/DAVResourceAccess.cxx b/ucb/source/ucp/webdav-curl/DAVResourceAccess.cxx index dfe78feb2454..cf134baaebf6 100644 --- a/ucb/source/ucp/webdav-curl/DAVResourceAccess.cxx +++ b/ucb/source/ucp/webdav-curl/DAVResourceAccess.cxx @@ -866,7 +866,7 @@ void DAVResourceAccess::MOVE( rDestinationURI, DAVRequestEnvironment( new DAVAuthListener_Impl( xEnv, m_aURL ), - aHeaders ), + std::move(aHeaders) ), bOverwrite ); } catch (DAVException const& e) diff --git a/unoidl/source/sourceprovider-parser.y b/unoidl/source/sourceprovider-parser.y index 7eac15b67d73..28c13937561f 100644 --- a/unoidl/source/sourceprovider-parser.y +++ b/unoidl/source/sourceprovider-parser.y @@ -810,7 +810,7 @@ Found findEntity( for (std::size_t i = 0; i != rank; ++i) { t = unoidl::detail::SourceProviderType(&t); } - *typedefedType = t; + *typedefedType = std::move(t); typedefedType->typedefName = *name; } *entity = nullptr; diff --git a/vcl/source/bitmap/BitmapScaleConvolutionFilter.cxx b/vcl/source/bitmap/BitmapScaleConvolutionFilter.cxx index 56b2f3969a9e..ae6398386f85 100644 --- a/vcl/source/bitmap/BitmapScaleConvolutionFilter.cxx +++ b/vcl/source/bitmap/BitmapScaleConvolutionFilter.cxx @@ -355,7 +355,7 @@ bool ImplScaleConvolution(Bitmap& rBitmap, const double& rScaleX, const double& if(bResult) { rBitmap.AdaptBitCount(aResult); - rBitmap = aResult; + rBitmap = std::move(aResult); } return bResult; diff --git a/vcl/source/bitmap/BitmapScaleSuperFilter.cxx b/vcl/source/bitmap/BitmapScaleSuperFilter.cxx index 1b13fb817d1b..a5f478948c04 100644 --- a/vcl/source/bitmap/BitmapScaleSuperFilter.cxx +++ b/vcl/source/bitmap/BitmapScaleSuperFilter.cxx @@ -1026,7 +1026,7 @@ BitmapEx BitmapScaleSuperFilter::execute(BitmapEx const& rBitmap) const pWriteAccess.reset(); bRet = true; aBitmap.AdaptBitCount(aOutBmp); - aBitmap = aOutBmp; + aBitmap = std::move(aOutBmp); } } diff --git a/vcl/source/gdi/print.cxx b/vcl/source/gdi/print.cxx index 6dc7584c9add..907094e33d0d 100644 --- a/vcl/source/gdi/print.cxx +++ b/vcl/source/gdi/print.cxx @@ -1023,7 +1023,7 @@ bool Printer::Setup(weld::Window* pWindow, PrinterSetupMode eMode) { ImplUpdateJobSetupPaper( aJobSetup ); mbNewJobSetup = true; - maJobSetup = aJobSetup; + maJobSetup = std::move(aJobSetup); ImplUpdatePageData(); ImplUpdateFontList(); return true; diff --git a/vcl/source/window/builder.cxx b/vcl/source/window/builder.cxx index ed8d349f2dac..b35b4a581f04 100644 --- a/vcl/source/window/builder.cxx +++ b/vcl/source/window/builder.cxx @@ -3645,7 +3645,7 @@ VclPtr<vcl::Window> VclBuilder::handleObject(vcl::Window *pParent, stringmap *pA if (pParent) applyAtkProperties(pParent, aAtkProperties, bToolbarItem); if (pAtkProps) - *pAtkProps = aAtkProperties; + *pAtkProps = std::move(aAtkProperties); return nullptr; }
