New branch 'distro/collabora/co-24.04.4' available with the following commits:
commit 3709158c476d3931713e1be652f02aae1db91dd3
Author: Andras Timar <[email protected]>
Date: Tue Jun 18 09:54:21 2024 +0200
Bump version to 24.04.4.2
Change-Id: I953ddce457c7f23448128788fa6b68ae84fdd2ce
commit 22076f4997bdc0528eaa49213a08055080b60a95
Author: Pranam Lashkari <[email protected]>
Date: Mon Jun 17 00:34:40 2024 +0300
LOK: fixed incorrect Logic point calculation for Map mode
problem:
it was very difficult to select line in online,
specifically in writer if line is very think and
it was almost impossible to select line
Change-Id: Ib641cd3d9795b93d47c78bc8f57211f51714844d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168837
Tested-by: Caolán McNamara <[email protected]>
Reviewed-by: Caolán McNamara <[email protected]>
Tested-by: Jenkins CollaboraOffice <[email protected]>
commit 30ca6789a6d7562d79d3d86d787a50e2f699c226
Author: Mike Kaganski <[email protected]>
Date: Sun Jun 16 18:52:47 2024 +0500
LOK: Use frozen map instead of a chain of hundreds string comparisons
Besides expected performance improvement, this helped to find several
elements that were duplicated in the long list. Frozen map does not
allow duplication of the keys, helping avoid these mistakes.
Change-Id: I2192d0ed50b6b8611fd08715f713742a993b28dc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168961
Reviewed-by: Mike Kaganski <[email protected]>
Tested-by: Jenkins
(cherry picked from commit 58aca139242e6cfbb66c37bf40009d5201ff007f)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168937
Tested-by: Jenkins CollaboraOffice <[email protected]>
Reviewed-by: Miklos Vajna <[email protected]>
commit 41fee8b9f03166b355b983616a3a9bbd3670b8ee
Author: Mike Kaganski <[email protected]>
Date: Sun Jun 16 16:02:40 2024 +0500
LOK: Send view modes status change notifications
Change-Id: If9a36dcd447eef355f137b5afe16f917e9c0cfa3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168960
Reviewed-by: Mike Kaganski <[email protected]>
Tested-by: Jenkins
(cherry picked from commit a14ec822c9c571a32eb0565158f1976b2d0dbf28)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168936
Tested-by: Jenkins CollaboraOffice <[email protected]>
Reviewed-by: Miklos Vajna <[email protected]>
commit b85eaba0aa3084865cb8046afc7c92f5256660c4
Author: Mike Kaganski <[email protected]>
Date: Sun Jun 16 12:46:54 2024 +0500
LOK: differentiate page kinds in sd::ViewShellBase::getEditMode
E.g., sending a LOK_CALLBACK_GRAPHIC_VIEW_SELECTION payload, the
"mode" must be different for notes view and for normal view.
Change-Id: I1f328290087f3185b7bef69560b28df6adb82e90
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168917
Reviewed-by: Mike Kaganski <[email protected]>
Tested-by: Jenkins
(cherry picked from commit 4ff2e148fa25933e64b7bbecbcd3ed551ad686ab)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168934
Reviewed-by: Miklos Vajna <[email protected]>
Tested-by: Jenkins CollaboraOffice <[email protected]>
commit 1830986b444ad694b95bae2cad45a7504a006da1
Author: Henry Castro <[email protected]>
Date: Mon Jun 10 14:41:13 2024 -0400
lok: sw: fix PageDown position when cursor is not visible
If PageDown key is pressed and the cursor is not visible,
in the PageDown increment the new cursor position will not update,
cause the Visible area is the full document.
Signed-off-by: Henry Castro <[email protected]>
Change-Id: I57b9ae1e80cb8aaaa78867ee215d7e80de990aff
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168646
Tested-by: Jenkins CollaboraOffice <[email protected]>
Reviewed-by: Caolán McNamara <[email protected]>
commit 6cd89fa7a0b5fb570aad42e847863925fb0036b8
Author: Miklos Vajna <[email protected]>
Date: Tue Jun 11 10:49:29 2024 +0200
tdf#161443 DOCX import, table style: handle para border in table cell paras
Open the bugdoc, the in-table paragraphs have some top and bottom
paragraph borders in Word, not in Writer -- because the cell and
paragraph UNO object both have a property named TopBorder as mentioned
in commit 39c54c0ef837e0e23a676a4d1fa5da667e18939c (tdf#161443 DOCX
import, table style: fix para border leaking into cell border,
2024-06-07).
The previous fix avoided the problem that the unwanted border affects,
the cell, but re-routing the property to affect the in-table paragraph
were not done.
Fix the problem by adding 3 new meta-properties with a "Para" prefix for
all 4 border locations (top/left/bottom/right), this way the paragraph
borders defined in a table style can affect the in-table paragraphs, but
not the table cells.
Apart from the border itself, this also affected the border spacing,
which means that the position of all text inside and below the table is
now also correct. Unfortunately this also means we need to move away
from the constexpr frozen container that is only suitable for a limited
number of items:
sw/source/writerfilter/dmapper/PropertyIds.cxx:394:6: error: ‘constexpr’
evaluation operation count exceeds limit of 33554432 (use
‘-fconstexpr-ops-limit=’ to increase the limit)
Returning to std::unordered_map is good enough for our needs.
(cherry picked from commit 013300c751d7a9ede12c1bf1c784254d1c6c5433)
Change-Id: I478f274800a1d0b200f10226438ab4cfd4957b74
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168696
Reviewed-by: Caolán McNamara <[email protected]>
Tested-by: Jenkins CollaboraOffice <[email protected]>
commit 76e7f238476737e78767ecb5f520d61943e7c356
Author: Miklos Vajna <[email protected]>
Date: Fri Jun 7 09:14:21 2024 +0200
tdf#161443 DOCX import, table style: fix para border leaking into cell
border
Open the document with a single table, notice that start of the text in
A1 cell is missing.
Seems what happens is that the cell has some positive border distance,
then the para has the same negative left margin, so in total there is 0
left margin for the text, which makes this readable in Word. On our
side, we map the paragraph border from the table style to the
LeftBorderDistance property, then throw this on the cell object, which
gives us 0 border distance, so the negative para left margin results in
an unwanted shift of text towards the left: the start of the text is
hidden by clipping to make sure the painted text is inside the cell
frame. (Both paragraphs and cells have a LeftBorderDistance property, by
accident.)
Given that a visible paragraph border from table style is not actually
imported, first just do the minimal fix and make sure we don't import
paragraph borders from table style at all: this solves the problem of
unwanted 0 cell border distances and the full text is now readable.
In case the paragraph border in the table style would be actually
visible, that would be useful to route to the paragraphs in the cell,
that's not yet done here.
(cherry picked from commit 39c54c0ef837e0e23a676a4d1fa5da667e18939c)
Change-Id: I79907a2487c48659effcc55253b9d9881550284d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168660
Reviewed-by: Caolán McNamara <[email protected]>
Tested-by: Jenkins CollaboraOffice <[email protected]>
commit 73bce27b87ec75a9cbf16e282c36c8c7f223f239
Author: Caolán McNamara <[email protected]>
Date: Tue Jun 11 11:29:44 2024 +0100
more stale hyphenation data after skipping blanks
m_xHyphWord is stale if m_nBreakStart changes
turn maybeAdjustPositionsForBlockAdjust into a member
to make it easier to discard m_xHyphWord on change
to m_nBreakStart
Change-Id: I6ca37371bf6b8362ebd16a08594afcff3222fa12
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168666
Reviewed-by: Mike Kaganski <[email protected]>
Tested-by: Jenkins CollaboraOffice <[email protected]>
commit 39e565cd5259edb108fa0949469bdcb997206aeb
Author: Caolán McNamara <[email protected]>
Date: Mon Jun 10 12:41:14 2024 +0100
Resolves: tdf#161430 reindex the correct style if there are duplicate names
and
Related: tdf#161430 add test case to guard against its return
Change-Id: I6d4e96faef3ec6caa038edf7595f91f20d964807
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168479
Tested-by: Jenkins
Reviewed-by: Noel Grandin <[email protected]>
(cherry picked from commit 9fa0b6977ba8292bfcc313caf080733090974c3f)
Change-Id: Ia2b12ab696632a4f08fd4c20472646dcfd9058c6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168636
Tested-by: Jenkins CollaboraOffice <[email protected]>
Reviewed-by: Miklos Vajna <[email protected]>
commit f367ff8da1150a999a1dea35a6e26ed7108369bf
Author: Michael Meeks <[email protected]>
Date: Sat Jun 8 14:38:34 2024 +0100
Avoid potential negative array index access to cached text.
if ((nIndex != 0 || nLen != text.getLength()) && !skipGlyphSubsets)
seems unlikely to protect us from this:
/opt/rh/devtoolset-12/root/usr/include/c++/12/string_view:239:
constexpr const std::basic_string_view<_CharT, _Traits>::value_type&
std::basic_string_view<_CharT, _Traits>::operator[](size_type) const [with
_CharT = char16_t; _Traits = std::char_traits<char16_t>; const_reference =
const char16_t&; size_type = long unsigned int]: Assertion '__pos <
this->_M_len' failed.
coolwsd[16958] ... SIG Fatal signal received: SIGABRT code:
18446744073709551610 for address: 0x7300004e16
SalLayoutGlyphsCache::GetLayoutGlyphs(VclPtr<OutputDevice const>,
rtl::OUString const&, int, int, long, vcl::text::TextLayoutCache const*)
/home/collabora/jenkins/workspace/build_core_co-24.04_for_online_snapshot/vcl/source/gdi/impglyphitem.cxx:399
GetTextArray(OutputDevice const&, rtl::OUString const&, KernArray&,
int, int, bool, vcl::text::TextLayoutCache const*)
/home/collabora/jenkins/workspace/build_core_co-24.04_for_online_snapshot/include/rtl/ref.hxx:128
SwFntObj::GetTextSize(SwDrawTextInfo&)
/home/collabora/jenkins/workspace/build_core_co-24.04_for_online_snapshot/sw/source/core/txtnode/fntcache.cxx:766
SwSubFont::GetTextSize_(SwDrawTextInfo&)
/home/collabora/jenkins/workspace/build_core_co-24.04_for_online_snapshot/sw/source/core/txtnode/swfont.cxx:1022
SwTextSizeInfo::GetTextSize() const
/home/collabora/jenkins/workspace/build_core_co-24.04_for_online_snapshot/sw/source/core/inc/swfont.hxx:314
blind fix - but seeing a lot of these.
Change-Id: Icb6ca25e4b8c6ef8a5e5b89dfa01b56bb788378d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168575
Tested-by: Jenkins CollaboraOffice <[email protected]>
Tested-by: Caolán McNamara <[email protected]>
Reviewed-by: Caolán McNamara <[email protected]>
commit 6e7f5a14cb1b0c7ca31f6983a2f2ad60f5836af2
Author: Andras Timar <[email protected]>
Date: Fri Jun 7 10:56:45 2024 +0200
LOK: do not use deprecated .uno:BackColor
Change-Id: Ieb780d278cd45bf82a2b4acee0abd17af2dc71eb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168519
Tested-by: Jenkins CollaboraOffice <[email protected]>
Reviewed-by: Miklos Vajna <[email protected]>
commit 8518a87c2d380947487ef2778044c273062204aa
Author: Caolán McNamara <[email protected]>
Date: Fri Jun 7 12:11:22 2024 +0100
prep AutoFill menu in kit mode only
Change-Id: Id533d78e1433b616ce661e855dad0d571d24cf8a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168533
Tested-by: Jenkins CollaboraOffice <[email protected]>
Reviewed-by: Miklos Vajna <[email protected]>
commit 59e5329ff61b372c5b76032bb1eb2384402b55f4
Author: Caolán McNamara <[email protected]>
Date: Fri Jun 7 20:14:15 2024 +0100
stale hyphenation data after skipping blanks
what I see is that after skipping blanks that the m_xHyphWord remains
describing the word at the original m_nBreakStart, but we have changed
that m_nBreakStart and m_nBreakStart is now at the next word, so the
contents of m_xHyphWord bear no relationship to the current break
position.
Change-Id: I07c91495f0cd7ef6d78c0f0d5cef70070ebb6ff2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168564
Tested-by: Jenkins CollaboraOffice <[email protected]>
Reviewed-by: Caolán McNamara <[email protected]>
commit 24497d7bcf3126ef004efee9c4d106945b6b8add
Author: Caolán McNamara <[email protected]>
Date: Thu Jun 6 12:19:59 2024 +0100
if we don't have local help then Help::GetHelpText will be empty
anyway, so we can skip that work on Window::GetHelpText.
It might even be that by now all the a11y/extended-tips are in the local
.ui files and the whole fallback to local help is redundant and should
be removed. But that's not done here.
Change-Id: I03b759aba6d1619aff37ded6764fbe3b6ded9555
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168447
Reviewed-by: Miklos Vajna <[email protected]>
Tested-by: Jenkins CollaboraOffice <[email protected]>
commit 8df19d1565f128eb1f242aeea8d9a1a0252cdb23
Author: Michael Meeks <[email protected]>
Date: Fri May 24 21:45:44 2024 +0100
cool#9082 - lok: cleanup WakeUpThread before forking, then re-start.
It seems likely that this lingering briefly after various un-identified
and tough to reproduce, longer running operations in calc - which is a
big ScProgress user - caused problems with background save.
Change-Id: I1d0ec56c759dff30c48c8562b6400b57be4a25b2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168033
Reviewed-by: Caolán McNamara <[email protected]>
Tested-by: Caolán McNamara <[email protected]>
commit ac514873e2fc08a7fba77bf059666244cc91c7de
Author: Mike Kaganski <[email protected]>
Date: Wed Jun 5 10:43:07 2024 +0500
tdf#144752: UNDO/REDO: make sure to select the replaced content
In the specific case of the bug, the non-empty selection means that
the spell check won't skip the word with the cursor. But this also
establishes consistency with other Undo/Redo cases, which generally
select the text.
Change-Id: Ib7c1c911908dc59947e610d735907be7a363ca87
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168423
Reviewed-by: Mike Kaganski <[email protected]>
Tested-by: Jenkins
(cherry picked from commit 31f46cec1406bb39453f5d909da1321980b0e405)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168432
Reviewed-by: Miklos Vajna <[email protected]>
Tested-by: Jenkins CollaboraOffice <[email protected]>
commit dc3975399ecbfdfdbd71b0a46327c74b18070a9e
Author: Mike Kaganski <[email protected]>
Date: Wed Jun 5 00:41:03 2024 +0500
tdf#136294: trigger pending spellcheck in SwCursorShell::UpdateCursor
This allows to drop the partial fix created for tdf#124603 (except for unit
test). The problem solved in commit 4c91e94e892943ef5e031d65f6f42864233cb4cd
(tdf#92036: sw: fix idle spelling loop, 2015-09-09) is kept solved; when a
word is marked pending, this is signalled to the viewshell. SwCursorShell
stores that as a flag, which will then start an idle on cursor update, and
finally call SwViewShell::LayoutIdle, which does the spell checking. If the
cursor is still in the word that is pending the check, the cycle will
repeat,
trying spell checks only at cursor update, not as a busy loop.
Change-Id: I5dc77baabffa723e261d553e40d40e5ace4266bc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168413
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <[email protected]>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168422
Reviewed-by: Miklos Vajna <[email protected]>
Tested-by: Jenkins CollaboraOffice <[email protected]>
commit b0c6350504431f1eee1e6ac207179c9b64ffa591
Author: Henry Castro <[email protected]>
Date: Wed Jun 5 08:35:25 2024 -0400
Revert "tdf#160706 speed up loading conditional formatting rule in XLS (II)"
This reverts commit 13d39423a8bb70c08052fb02ef41cf3ea6f731d1.
Unfortunately, it breaks copy/pasting slide.
Change-Id: I1831aac9e672cf66dea658979e98855529b94b07
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168473
Tested-by: Jenkins CollaboraOffice <[email protected]>
Reviewed-by: Caolán McNamara <[email protected]>
